edge overlay

[Microfunguy]

This is useful for panoramas

I just use a Sigma 8mm fisheye.

However, I am not willing to buy a full-frame DSLR so I will use film for my spherical panos yet again this year.


David

[hiker_jon]

Hi,

Here is a updated (May 8, 2008) version of the edge_overlay code.

During shoot mode half or full press it adds an overlay based on the image edges.
Use the left,right,up,down buttons to shift the overlay.
The edge overlay is frozen when you take a shot and the frozen edges are displayed from then on when you half press.
When you shoot again it goes back to the original behavior:  showing the edges of the current image on half-press.
This behavior is useful when shooting stereo pairs.  For panoramas you would want to freeze the edges after every full press.


This version avoids drawing when menus are displayed
This version adds a grid that matches the Canon grid.
This version corrects flaky behavior caused by multiple calls during one full-press.

Code: C++

1.  
2. // Code to test the idea of an edge overlay
3. // Put                  edge_overlay();                 after the line histogram_process();
4.  
5.  
6. // Put the following after  the line #include "motion_detector.h" in main.c
7. #include "gui_draw.h"
8.  
9. // until the edge thresh is put into conf structure I have hardcoded the threshold  see "thresh" below
10. static char * imgbuf = 0;
11.  
12. #define MARGIN 30
13. #define CALCYMARGIN 3
14. #define EDGECOLOR 0x66
15. #define NSTAGES 4
16. #define XINC 6
17. #define YINC 2
18. #define XGRID1 120
19. #define XGRID2 240
20. #define YGRID1 80
21. #define YGRID2 160
22.  
23. void edge_overlay(){
24.         static int inmem=0;
25.         static int viewport_height;
26.         static int viewport_width;// screenwidth * 3
27.         static int viewport_size;
28.         static int shotTaken = 0;
29.         static int imgmem = 0;
30.         static int ymin = 0;
31.         static  int thresh = 40;
32.         static int xoffset = 0;
33.         static int yoffset = 0;
34.         static int full_press = 0;//cure for flaky behavior. due to multiple  returns to the scrip during one full press
35.         static char strbuf[7] = "Frozen";
36.         static unsigned char *img;
37.         int i, hi, c;
38.         int x, y, h, v, ymax, y1, x1, y2;
39.         char * ptrh1;
40.         char * ptrh2;
41.         char * ptrv1;
42.         char * ptrv2;
43.         char * optr;
44.        
45. //      if(!conf.edge_thresh) return;
46.        
47.         img = vid_get_viewport_fb();
48.     viewport_height = vid_get_viewport_height();
49.         viewport_width = screen_width * 3;
50.     viewport_size = viewport_height * screen_width;
51.         if(imgbuf == 0) imgbuf = malloc(viewport_size * 3);
52.                
53.         if((mode_get()&MODE_MASK) != MODE_PLAY) {
54.                 if (kbd_is_key_pressed(KEY_RIGHT)) {
55.                         xoffset -=XINC;
56.                 }
57.                 if (kbd_is_key_pressed(KEY_LEFT)) {
58.                         xoffset +=XINC;
59.                 }
60.                 if (kbd_is_key_pressed(KEY_DOWN)) {
61.                         yoffset -=YINC;
62.                 }
63.                 if (kbd_is_key_pressed(KEY_UP)) {
64.                         yoffset +=YINC;
65.                 }
66.  
67.                 if (kbd_is_key_pressed(KEY_SHOOT_HALF)||kbd_is_key_pressed(KEY_SHOOT_FULL)) {
68.                         if (kbd_is_key_pressed(KEY_SHOOT_FULL) && !full_press) {
69.                                 shotTaken = 1 - shotTaken;
70.                                 memcpy(imgbuf,img,viewport_size * 3);
71.                                 ymin = CALCYMARGIN;
72.                                 inmem = 1;
73.                                 full_press = 1;
74.                                 xoffset = 0;
75.                                 yoffset = 0;
76.                                 return;
77.                         }
78.                         if(shotTaken) {
79.                                 return;
80.                         }
81.                         memcpy(imgbuf,img,viewport_size * 3);
82.                         ymin = CALCYMARGIN;
83.                         inmem = 1;
84.                         xoffset = 0;
85.                         yoffset = 0;
86.                         return;
87.                 }
88.                 else full_press = 0;
89.                 if (inmem && (ymin < screen_height-CALCYMARGIN)) {
90.                         ymax = ymin + (screen_height - 2 * CALCYMARGIN) / NSTAGES;
91.                         if(ymax > screen_height - CALCYMARGIN) ymax = screen_height - CALCYMARGIN;
92.                         for (y=ymin; y<ymax; y++) {
93.                                 ptrh1 = imgbuf + y * viewport_width + 7;
94.                                 ptrh2 = imgbuf + y * viewport_width - 5;
95.                                 ptrv1 = imgbuf + (y + 1) * viewport_width + 1;
96.                                 ptrv2 = imgbuf + (y - 1) * viewport_width + 1;
97.                                 optr = imgbuf + y * viewport_width + 3;
98.                                 for (x=12; x<(screen_width- 4) * 3; x+=6) {
99.                                         h = ptrh1[x] - ptrh2[x];
100.                                         if(h  < 0) h = -h;
101.                                         v = ptrv1[x] - ptrv2[x];
102.                                         if(v  < 0) v = -v;
103.                                         optr[x] = h + v;
104.                                         h = ptrh1[x + 3] - ptrh2[x + 3];
105.                                         if(h  < 0) h = -h;
106.                                         v = ptrv1[x + 3] - ptrv2[x + 3];
107.                                         if(v  < 0) v = -v;
108.                                         optr[x + 2] = h + v;
109.                                 }
110.                         }
111.                         ymin += (screen_height - 2 * CALCYMARGIN) / NSTAGES;
112.                         return;
113.                 }
114.                 if(inmem &&(ymin >= screen_height-CALCYMARGIN) &&
115.                         ((gui_get_mode() == GUI_MODE_NONE) || (gui_get_mode() == GUI_MODE_ALT))){
116. //                              thresh = (conf.edge_thresh - 1) * 12;
117.                                 for (y=MARGIN; y<screen_height-MARGIN; y++) {
118.                                         y1 = y + yoffset;
119.                                         if((y1 < CALCYMARGIN) || (y1 >= screen_height - CALCYMARGIN)) {
120.                                                 for (x=MARGIN; x < screen_width - MARGIN; x+=2) {
121.                                                         draw_pixel(x, y, 0);
122.                                                         draw_pixel(x+1, y, 0);
123.                                                 }
124.                                         }
125.                                         else {
126.                                                 for (x=MARGIN; x < screen_width - MARGIN; x+=2) {
127.                                                         x1 = x + xoffset;
128.                                                         if((x1 < 12) || (x1 >= screen_width-13)) {
129.                                                                 draw_pixel(x, y, 0);
130.                                                                 draw_pixel(x+1, y, 0);
131.                                                         }
132.                                                         else {
133.                                                                 c = 0;
134.                                                                 if(imgbuf[y1 * viewport_width + x1 * 3 + 3]  > thresh)
135.                                                                         c = EDGECOLOR;
136.                                                                 draw_pixel(x, y, c);
137.                                                                 c = 0;
138.                                                                 if(imgbuf[y1 * viewport_width + x1 * 3 + 5]  > thresh)
139.                                                                         c = EDGECOLOR;
140.                                                                 draw_pixel(x+1, y, c);
141.                                                         }
142.                                                 }
143.                                 }
144.                                 for (y2=MARGIN; y2<screen_height-MARGIN; y2++) {
145.                                         draw_pixel(XGRID1,y2,0xff);
146.                                         draw_pixel(XGRID2,y2,0xff);
147.                                         if(y2 == YGRID1) for (x=MARGIN; x < screen_width - MARGIN; x++) draw_pixel(x,y2,0xff);
148.                                         if(y2 == YGRID2) for (x=MARGIN; x < screen_width - MARGIN; x++) draw_pixel(x,y2,0xff);
149.                                 }
150.                                 if(shotTaken) draw_string(30, 10, strbuf, conf.osd_color);
151.                         }
152.                         return;
153.                 }
154.         }
155.         else {
156.                 full_press = 0;
157.                 inmem = 0;
158.                 shotTaken = 0;
159.                 ymin = 0;
160.                 xoffset = 0;
161.                 yoffset = 0;
162.         }
163.         return;
164. }
165.  
166. //End of edge detector code.  next put                  edge_overlay();                 after the line histogram_process();
167.  
168.  

[PhyrePhoX]

Code: [Select]

(canon_menu_active==(int)&canon_menu_active-4) && (canon_shoot_menu_active==0)if this statement is true, neither canon menu nor the function menu are popped up.
dont ask me about the -4 thing, i copied it from the source, used it in my own function - it works. these get defined in stubs_min.s by the way

[hiker_jon]

Thanks,
That works.  I have modified the code I posted.

The previous behavior was:
When you press menu (ie Canon menu, not in alt mode) you see a live image plus my edge overlay in a different color frozen at the time you pressed menu.   I write to the screen using draw_pixel using 0 (for transparent) and a color 0x26.  So the 0 was overwriting the canon menu and causing the display to show the last image.  But why was my color changed?  Why does 0x26 have different meanings at different times?  I guess I have a lot to learn about how the screen works.

Jon

[PhyrePhoX]

canon keeps 4 different color palettes, one for record mode, one for playback and i think 1 each for menu and func menu.

[hiker_jon]

I have updated the code to fix some flakiness and changed the overlay color.  The code now displays the word "Frozen" when the edge overlay is frozen.

Jon

[vine]

I just tried it on my A560 and it works very well. Great addition to CHDK!

*EDIT
Surely it is supposed to work for the whole display? If I use your code without change It only acts on a smaller are in the center of the display (hope you know what I mean, here is an image of it: http://worldswithinworlds.de/misc_image_dump/PICT0079.JPG)
I guess I'll have to take a closer look at the code behind it after all

[Microfunguy]

Surely it is supposed to work for the whole display?

If it overlaps any on-screen display elements that are situated around the edges of the screen, you get annoying flickering.

[vine]

Thanks for clearing that up for me Microfunguy
Any suggestion on how to implement a quick and simple on/off option?

[Microfunguy]

Any suggestion on how to implement a quick and simple on/off option?

Well, i am using it with my own SDM build so I turn-off any OSD's when outline mode is enabled and I turn-off Canon displays with the DISPLAY button.

I have not studied the trunk CHDK build recently 

David

[Spinal]

In reply to A530 - remote control

Outline mode doesn't crash my A530, but I'm not entirely sure if it works properly. I tried it twice: I first took a photo of my keyboard and I saw yellow/orange dots at bright spots.
Then I took a photo of my window and almost the entire screen became yellow/orange, not just bright spots or anything.


-edit-
Attached are 2 photos, one of them looks like it could be normal, the other one looks completely f**ked up.. Hope this helps

[Microfunguy]

That is OK.
The first image has lots of fine detail so you do not get strong outlines.
The second image is junk left after taking the second photo of a stereo pair.
Half-press the shutter for about one second or switch to playback and back again to clear.


David