a few enhancements, bugfixes - done

[PhyrePhoX]

latest edit: some of things suggested in this thread got coded in this thread: remaining video time,overrides-cusomizations,no-raw@video,just _random_ stuff

edit: jump directly to : a few enhancements, bugfixes

Hi,

in this build i did the following:

- added wontollas diskspace icon (see Remaining RAW+JPG shots + filespace icon/text- done )
- added possibility to choose between horizontal or vertical spacebar
- added possibility to choose between three sizes of spacebar (1/4, 1/2 or full screen width/height)
- added possibility to choose between OSD clock with & without seconds (might come in handy if you want to make a shot at an EXACT moment)
- followed vit40's suggestion: in record mode, when you half-press shootbutton, now most icons (battery,filespace,raw status...) disappear - to maximize preview area
[- s3is (and other cameras which have seperate videobutton): in video mode, save_raw is disabled, this way you can shoot video and take pictures without interrupting video - this is untested, as i dont own an s3is. should work though.] - feature not working, implementation on hold!
- updated german.lng file



build for s3is ownsers (barney? ) attached

built against #313.
no errors during compilation.
as always: ugly code. please comment & make suggestions, report bugs and whatnot.
as you can see in my build #, it took me some time to figure everything out

edit: added zshare download link for archive of compiled binaries. man, everytime i upload something to zshare i feel like an old man on modem sorry for the generic threadtitle and archive filename, it's already late in germany and i couldnt think of any other.
edit #2: yes, if betatests are successful, i hope this is gonna be added to official trunk.

[Barney Fife]

Deleted

[Kalli]

- updated german.lng file

Hi PhyrePhoX

I can't find the file not in the archive nor wiki...

mfg Kalli

[brabl2]

Hi, this is nice feature.

- followed vit40's suggestion: in record mode, when you half-press shootbutton, now most icons (battery,filespace,raw status...) disappear - to maximize preview area

I would propose to keep battery info on the screen in case it is in red state.
Just imagine that your batteries are VERY low and you need to take at least 1 or 2 photos.
In this case battery info seems useful (for me) even if shootbutton is half-pressed.

Pavel

[Barney Fife]

Deleted

[PhyrePhoX]

hm, i thought i solved the problem. alright, i still think this can be done. will look into it later.
the sd card icon is not filled? that i really dont understand.

I would propose to keep battery info on the screen in case it is in red state.
Just imagine that your batteries are VERY low and you need to take at least 1 or 2 photos.
In this case battery info seems useful (for me) even if shootbutton is half-pressed.

good idea, same applies to the raw counter

@kalli: yes you are right, the german file is missing. will attach it later.

thanks for your responses so far.

[wontolla]

Great stuff Phox!.
Even the most expensive DSLR camera doesn't give you all these options. I have a DSLR user friend who just can't believe it when I talk about CHDK.

The SD Card icon is cool, but ... mine doesn't do anything.

Darn! It worked in my S3 and Phox's code looks fine. I'll try to find the problem tonight.

and someone lost a whole event when they inadvertently left RAW turned on too and shot a frame at the beginning of the video.

Yes, Her Majesty the Queen was very disappointed when she learned about my failure to record her reception parade. But I'll let her know PhyrePhox is working day and night so it will never happen again.

BTW Phox, your name and avatar remind me a Super Nintendo game which made a breakthrough in 3D graphics a long time ago. StarFox. Is it inspired on that game or I'm getting old and tend to remember the good old days more often?

[PhyrePhoX]

Yes, Her Majesty the Queen was very disappointed when she learned about my failure to record her reception parade. But I'll let her know PhyrePhox is working day and night so it will never happen again.

BTW Phox, your name and avatar remind me a Super Nintendo game which made a breakthrough in 3D graphics a long time ago. StarFox. Is it inspired on that game or I'm getting old and tend to remember the good old days more often?

working day and night... actually thats true, but during the day i work for my company

wow, you are the first one to see the resemblance, most people think i'm just a fanboy of the browser firefox and just write it in a fancy way actually i had this name way before the browser. it's inspired by a character in a book by neal stephenson, though my writing of it is unique (the placing of the capital letters). the icon/avatar is indeed from the game starfox, i like it because it is small and simple, i have it everywhere

[Barney Fife]

Deleted

[PhyrePhoX]

well, i guess the problem will be solved in no time, as wontolla also owns the s3is. maybe he will also find out more regarding the video+raw issue.

[PhyrePhoX]

hah, found out why barney is only seeing the empty frame of the sd card icon. actually, this means his sd card itself is empty. meaning: the fuller the sd card, the fuller the icon. i had my card always roughly at 50% filled so i didnt notice that wontolla implemented it this way.
the question now is: did he do this on purpose?
I'd rather have it the other way around - start with a full sd card icon (if card is empty regarding filespace) and have it vanish by turning transparent over time.
maybe wontolla can look into his function again to fix that, as i always get heavily confused and lost in the draw functions (i hate drawing by coords )

regarding the raw/video problem:

i implemented a small check in the raw function:

Code: [Select]

if ((conf.save_raw) & ((m&MODE_SHOOTING_MASK)!=MODE_VIDEO_STD))this works on my a620, and by working  i mean i can still shoot raw. i cant test shooting raw in video mode, as my cam doesnt support it. if i change the condition to

Code: [Select]

if ((conf.save_raw) & ((m&MODE_SHOOTING_MASK)==MODE_VIDEO_STD))  i can't shoot raw anymore. conclusion: on s3is MODE_SHOOTING_MASK doesnt return MODE_VIDEO_STD (for example) but

Code: [Select]

  (o&MODE_SHOOTING_MASK) == MODE_VIDEO_SPEED || 
  (o&MODE_SHOOTING_MASK) == MODE_VIDEO_COMPACT ||
          (o&MODE_SHOOTING_MASK) == MODE_VIDEO_MY_COLORS ||
          (o&MODE_SHOOTING_MASK) == MODE_VIDEO_COLOR_ACCENT ||
                  (o&MODE_SHOOTING_MASK) == MODE_VIDEO_TIME_LAPSE  )   )    on my a620 the mode always is video_std, regardless of the actual mode. is there an extra mode dial on s3is? i guess then the different modes actually come into effect. maybe an s3is owner/coder can confirm this.

[Barney Fife]

Deleted

[PhyrePhoX]

well the color can be set in visual menu (file space icon). color effects all icons (space bar & icon). but like i said, i guess it will be changed to being transparent when empty.

[wontolla]

wontolla implemented it this way. the question now is: did he do this on purpose?

Jejeje yes I did. I thought: "Well, if the battery icon looks full when full of energy, the memory icon should look full when full of photos". "Battery icon full? Good!. Memory icon full? Bad! time to swap cards!"
I do remember thinking people could get confused about this but I thought it can be easily changed if needed.
After two weeks I forgot this issue and yesterday when Barney reported the "malfunction" I didn't remember it was suppoused to behave like this! You know, I never have both my camera and internet connection at the same time to tests things.

maybe wontolla can look into his function again to fix that, as i always get heavily confused and lost in the draw functions

I will.
I know my icon code is ugly; I had to do it like that (line by line). At first I was drawing a simple square and then erase the little corner, but this looked bad because the corner kept blinking when the display refreshed.

The icon is pretty large though

Yep, I made it big because the corner thingy gets lost in a smaller icon. Remember I was just fooling around with the CHDK code for the first time, I never thought the icon would be used by other people.
IMO Phox's bar is much more useful for people like you and me concerned about "real state". The SD card icon is just fancy. The newbies will like it and as they get more experience they will disable it.
I can always make it smaller or transparent grey either way, just let me know.

BTW Barney, I didn't know you made the Golden Spiral, I use it all the time it rocks!

@PhyrePhox
I don't mean to be fussy but I noticed the horizontal bar can't be pushed all the way to the right corner of the screen (see figure). Is it possible for you to fix that if you got a chance?

[Barney Fife]

Deleted