Display (bitmap overlay)

srsa_4c

srsa_4c
One detail I'm not happy with is the vid_bitmap_refresh() implementation. This function is now called at least 10 times a second and it writes 2 entries in camera log.

As it turned out, the variant with two transfer_src_overlay calls doesn't write unnecessary camera log entries. The firmware, however, does lots of VTMLock/Unlock when using a mode with frequent display updates (face tracking, "scene intelligent auto"). I made the mistake of dumping camera log while in such mode.

I noticed that the "fallback" HDMI mode (probably 480p) is not handled correctly on my camera with the current code (I still need to dump the ximr struct to see what's going on). This results in completely garbage display. I'm able to force the camera into this mode with some of my HDMI devices, but I'm not sure if others can do that. Connecting the camera to a digital monitor/TV with less than full HD native resolution should in theory help.

philmoz

srsa_4c
I noticed that the "fallback" HDMI mode (probably 480p) is not handled correctly on my camera with the current code (I still need to dump the ximr struct to see what's going on). This results in completely garbage display. I'm able to force the camera into this mode with some of my HDMI devices, but I'm not sure if others can do that. Connecting the camera to a digital monitor/TV with less than full HD native resolution should in theory help.

@srsa_4c

Is it just the CHDK display that is garbled or does it affect the Canon OSD as well?

srsa_4c

philmoz
Is it just the CHDK display that is garbled or does it affect the Canon OSD as well?

Both are affected. The buffer dimensions and aspect ratios are different, so it's not too surprising. It remains to be seen whether the firmware's implementation (of that display mode) on different models is similar or different.

philmoz

CanonUser9000
I had been pointed to this thread due to the boring flickering of CHDK OSD and menues on DIGIC-6 cams. As far as I understood the discussion there are builds under development for M3 and G7X that try to avoid this and probably some other flaws.
I can offer to test those stuff on my SX700HS (that has DIGIC-6 proc too) if someone can provide an appropriate build.

@CanonUser9000

SX700 test versions uploaded to the link below.
Note the SX700 appears to have a different screen size to the other cameras already implemented so I've had to make some guesses here.

https://drive.google.com/drive/folders/1drk1xi6kMMIeF5xSqXgnpjGCffF8CVkd?usp=sharing

CanonUser9000

@philmoz:
Thanks a lot.
I've tested the bulid for FW version 100e: not flickering any more and all the menues can be accessed.

Note the SX700 appears to have a different screen size to the other cameras already implemented

To help alignment of the OSD and CHDK menues I've atteched some screen shoots in comparison with build 1.6.0-5727 (DE).

philmoz

CanonUser9000
To help alignment of the OSD and CHDK menues I've atteched some screen shoots in comparison with build 1.6.0-5727 (DE).

@CanonUser9000

I've uploaded a new version (file name is the same in Google Drive).

Can you see if this fixes the cropping on the right side.

CanonUser9000

@philmoz:

I've tested sx700hs-100e-1.6.0-5929-full.zip-20210601T083032Z-001:

OSD now perfectly aligned, no cropping any more, no flickering

Thank's a lot :😀

philmoz

CanonUser9000
OSD now perfectly aligned, no cropping any more, no flickering

@CanonUser9000

Thanks for the update.

When you have time can you please test zebra and edge overlay.

reyalp

I finally got around to trying the xmir build on g7x (thanks again philmoz for doing that 😀) and noticed CHDK histogram was wildly different from the trunk, which probably explains at least some of what pigeonhill saw in https://chdk.setepontos.com/d/14342/29

Turns out it was showing only the lower half, due to a THUMB_FW / LARGE_HISTO mixup. Update in r5938 should fix this (but not other various histogram bugs)

Note ifdefs depending on CAM_DRAW_RGBA in module / platform independent code breaks our portability rules and will need to be resolved before this gets merged into the trunk. Should be fine for development though if non-CAM_DRAW_RGBA aren't being built without a clean in between. (edit: oops 😳)

Other observations:
The UI is so stable and smooooooooth, even with Canon histogram or electronic level active. Huge improvement.
Zebra doesn't seem to draw at all on my g7x. Edge overlay works.

philmoz

reyalp
Turns out it was showing only the lower half, due to a THUMB_FW / LARGE_HISTO mixup. Update in r5938 should fix this (but not other various histogram bugs)

Thanks for that.

Note ifdefs depending on CAM_DRAW_RGBA in module / platform independent code breaks our portability rules and will need to be resolved before this gets merged into the trunk. Should be fine for development though if non-CAM_DRAW_RGBA aren't being built without a clean in between.

I thought this was covered by having CAM_DRAW_RGBA build into the .o4 and .o5 directories (makefile_base.inc).
Did I miss something?

reyalp

philmoz
I thought this was covered by having CAM_DRAW_RGBA build into the .o4 and .o5 directories (makefile_base.inc).
Did I miss something?

Nope, I totally missed that you'd already made them use separate object directories 😳

That said, in the long term, I'd definitely argue for converting all the d6 cams and eliminating the old style. It's already hard enough to maintain.

CanonUser9000

When you have time can you please test zebra and edge overlay.

on SX700:

edge overlay: works as expected, varios settings tested 😁

zebara: no display of anything, regardless of settings used 🙁

philmoz

CanonUser9000
zebara: no display of anything, regardless of settings used 🙁

Thanks for testing. I've uploaded a new build to Google Drive which should fix this (fingers crossed).

philmoz

reyalp
Zebra doesn't seem to draw at all on my g7x. Edge overlay works.

Should be fixed in revision 5940.

CanonUser9000

Should be fixed in revision 5940

regarding zebra: no zebra display with rev 5940 🙁

One finding more: during video recording OSD and grid are still missaligned in x-direction and somewhat croped (see att.)

philmoz

CanonUser9000
regarding zebra: no zebra display with rev 5940 🙁

Hmm, not sure about this - will need to think about it.

One finding more: during video recording OSD and grid are still missaligned in x-direction and somewhat croped (see att.)

Seeing the same on the G7X2 and G5X - not sure what is going on here.
The rightmost 3rd of the CHDK bitmap image seems to get shifted left to the centre.
@srsa_4c - any thoughts?

Edit: If I allocate a full size RGBA buffer and remove the x2 scaling for the CHDK layer the weirdness when recording movies does not happen.

reyalp

philmoz
Should be fixed in revision 5940.

Does appear to be fixed on G7X.

One thing I noticed is OSD settings don't get reset switching between xmir and old style, so stuff that was positioned at the edges is no longer visible. Just something to be aware of for now, but if/when we move it into the trunk, we might want to reset OSD positions or something. Or at least note it.

Another oddity:
If zebra is enabled, the histogram is drawn, but in half press it doesn't actually update. This appears to be the case regardless of the zebra "restore" settings.

The old style tends to blow the histogram away complete if zebra is actually drawing anything, but with "restore OSD" enabled, it does update in half press.

Earlier cameras have the "Draw over zebra" option, which could perhaps be re-enabled for xmir.

This is all minor, I'm just noting it because I ran into while trying to understand other histogram bugs.

CanonUser9000

regarding zebra: no zebra display with rev 5940 🙁

update: zebra on SX700

Only if the option "RGB-Zebra (overexp. only)" is aktivated overexposed area are marked correctly on the display. No zebra without this option. 😖

philmoz

CanonUser9000
Only if the option "RGB-Zebra (overexp. only)" is aktivated overexposed area are marked correctly on the display. No zebra without this option. 😖

Can you check the zebra color settings for over and under exposure (CHDK Settings -> Color Settings).
Make sure they are valid colours and not transparent.

reyalp

philmoz
Can you check the zebra color settings for over and under exposure (CHDK Settings -> Color Settings).
Make sure they are valid colours and not transparent.

Also, the thresholds may need to be adjusted. Some (mostly earlier digic 6) cams use values in the 16-235 ish rather than 0-255, so to see anything in zebra the thresholds need to be large.

« Previous Page Next Page »