A590IS porting...

reyalp

dvip
reyaldp,
ould it be a sensor dimensions error in the active area defined in camera.h or somewhere in the source code for the A590IS? Is there any way to trim the borders a bit there? About 15 pixels?

Yes, this is all in camera.h, and considering the many other problems in the a590 port, I wouldn't be at all surprised if it were wrong.

RaduP

I also have that border on my SD980, I thought it was normal. There are some things in camera.h where you can define the crop area, but I didn't investigate their use. I'll take a look in the DNG/RAW code and see what I can find, when I have some time.

dvip

@reyalp, I hope is just a simple sensor re-dimensions in
camera.h and a re-compile.

@RaduP, yes, there are some #define in camera.h I saw way
back. I hope it is possible to do a little trim there in the sensor
active area, or that it can be set right.

reyalp

dvip
@reyalp, I hope is just a simple sensor re-dimensions in
camera.h and a re-compile.

Yes, just needs someone who has the camera (or a raw from it) to figure out the correct dimensions.

If you don't know what to do, I think Whim has one, maybe he can do it.

RaduP

Well, modifying
#define CAM_ACTIVE_AREA_X1
#define CAM_ACTIVE_AREA_Y1
#define CAM_ACTIVE_AREA_X2
#define CAM_ACTIVE_AREA_Y2
helped.
However, I am a little disappointed that the file size did not change :/

dvip

@reyalp, I don't have a way to recompile it.
Nice to know that Whim has a Canon A590IS.

@RaduP, I hope these changes can be added to
the next A590IS build. It will make using RAW
even better. No more trim in PP, no more ugly
frame around the CRW/DNG.

RaduP

Those changes are camera dependent, so they won't work on any camera. Compiling CHDK is relatively easy, it doesn't require programming experience or anything.

whim

Compiling CHDK is relatively easy, it doesn't require programming experience or anything.

i would agree with that 😁

@dvip
I noticed that there's several other cams that have an 1/2.5" / 8 MP sensor, maybe we could have a shot first
at replacing the CAM_ACTIVE_blahs with those from ixus80, A720, etc ? Are you willing to test a couple of
binaries, if i compile & upload them ?

HTH,

wim

dvip

@wim, sure, I will test the binaries.
Hey, where is your A590-101b ? 😀

whim

@dvip

in it's place, but i think compiling/uploading is faster :lol

here's what I found out so far: there's 6 other cams with 1/2.5" / 8 MP sensors

of those, 5 use the same set of CAM_ACTIVE_AREA
(x1,y1,x2,y2) = (10, 8, 3302, 2474) cams: a720, ixus860, ixus950, sx100is, s5is

the ixus80 uses ( 6, 6, 3304, 2476)

while the a590 now has ( 8, 8, 3304, 2480)

which means we only need two test binaries.. ~~what firmware do you use ?~~ saw you're on 101b as well

later,

wim

edit: here's the links:

http://drop.io/chdkshellbeta/asset/chdk-a590-101b-0-9-8-822-10-8-style-zip
http://drop.io/chdkshellbeta/asset/chdk-a590-101b-0-9-8-822-6-6-style-zip
edit2: i kinda hope if 1 of these doesn't cure it, we can at least get an idea what (x1,y1,x2,y2) are 😁
edit3: just discovered why i hadn't noticed this black bar stuff before: Raw Therapee seems to chop it automatically ...

dvip

@whim,
chdk-a590-101b-0-9-8-822-6-6-style-zip is better, no more
double frame there like before.

The black line at the button is gone 😀
Now you just need to make the left, top, and right go
away and no more frame around RAW pictures.

Just don't trim too much... you can make our A590IS-101b
a 7 MP cam... LOL :lol

reyalp

Uhm. Here's how you do it:
- Take a CRW image.
- ~~Convert it to a grayscale without demosaicing (e.g. dcraw -D -W -4 , use -T if you want a tiff)~~ use rawconvert in the source tree CHDK tools directory
- load this image in an image viewer that supports the specified format
- possibly adjust the contrast until you can see the image (a direct to 16 bit conversion will be very dark)
- count how many pixels wide each black border is
- use the information above to calculate your active area!

edit:
~~You may be able to omit the -4 above to get an 8 bit image that will still be usable for this purpose.~~

whim

@reyalp

thanks, i'll give it a shot

wim

whim

OK, having followed the procedure i got my TIFF (Irfanview showed a size of 3298 x 2472)
After blowing it up to ~500% i'd say the black band widths are: 3 pix @left, 2 pix @top and 2 pix @right
Screenshots of Irfan showing the top left and bottom right corners of the tiff are here:
http://drop.io/chdkshellbeta/asset/top-left-png
http://drop.io/chdkshellbeta/asset/bottom-right-png

need some sleep now,
wim

reyalp

whim
OK, having followed the procedure i got my TIFF (Irfanview showed a size of 3298 x 2472)

Ugh, either irfanview is lying to you, or (more likely) dcraw is already removing some border pixels, since the dimensions in camera.h are

#define CAM_RAW_ROWPIX              3336   // for new 8 MP
#define CAM_RAW_ROWS                2480   // for new 8 MP

The CRW raw will definitely start out this size.

I have a tool that does a truly raw conversion of 12bit raws, I guess I'll add the ten bit stuff and post it, unless someone else already has one handy.

dvip

@whim,
That's fine for the outer black border.
But in order to avoid the other parallel border on
the active area I think it is better:

6 pixels @left, 5 pixels @top, 5 pixels @right

As I said before there are two borders, one very dark in the
outside and one that looks colorful parallel to the dark one
but in the inside, it looks like it is on top of the active area.

I counted the pixels using IrfanView too.
Thanks reyalp for taking a look too.

reyalp

If you post a CRW from this camera somewhere, I'll take a closer look. Make sure the image isn't badly underexposed, and that you don't have a badpixel.bin present.

You can upload to http://www.zshare.net/ or similar file hosting site.

whim

Here's a CRW (without badpixel.bin this time) http://drop.io/chdkshellbeta/asset/a590-test-crw

wim

PS ... and, i think it might be a good idea (for the graphically challenged, like me 😁) to add

#undef CAM_ACTIVE_AREA_X1
#undef CAM_ACTIVE_AREA_Y1
#undef CAM_ACTIVE_AREA_X2
#undef CAM_ACTIVE_AREA_Y2

to camera.h default section with some kind helpfull comment

dvip

@Whin
I noticed that in your A590IS the borders are wider:

The trim should be:

10 pixels @left, 13 pixels @top, 6 pixels @right

It looks like our CCDs are different.

Thanks for posting the RAW.

ewavr

reyalp
- Take a CRW image.
- Convert it to a grayscale without demosaicing (e.g. dcraw -D -W -4 , use -T if you want a tiff)
- load this image in an image viewer that supports the specified format
- possibly adjust the contrast until you can see the image (a direct to 16 bit conversion will be very dark)
- count how many pixels wide each black border is
- use the information above to calculate your active area!

Hmm, if I convert CRW from a710, no black borders in tiff file. Because dcraw crops image before converting to tiff using settings from other camera (a620).

« Previous Page Next Page »