Histogram

pigeonhill

1155

Histogram

« on: 23 / April / 2021, 06:49:35 »

Advertisements

@reyalp

Forgive me, however, I cant remember if I requested this before.

Is there any chance, the next time you refresh the builds, you could consider increasing the size of the red dots that show under and over exposure?

They are really difficult to see, especially for those of us with old eyes ;-)

Logged

reyalp

14082

Re: Histogram

« Reply #1 on: 23 / April / 2021, 13:21:05 »

Quote from: pigeonhill on 23 / April / 2021, 06:49:35

Forgive me, however, I cant remember if I requested this before.

Is there any chance, the next time you refresh the builds, you could consider increasing the size of the red dots that show under and over exposure?

They are really difficult to see, especially for those of us with old eyes ;-)

I think you did, and I ended up putting it off because it's not quite that simple. The dots are only tiny on digic 6 and later cams. I'll try to take another look.

Logged

Don't forget what the H stands for.

pigeonhill

1155

Re: Histogram

« Reply #2 on: 23 / April / 2021, 13:28:34 »

@reyalp

Sorry about the repeat request, and thanks for taking another look.

One thought I had was to turn the left and right axis red, rather than put a dot on the screen, ie flag the over or under in a clearer way.

But, bluntly, anything that makes things more readable would be great; although I recognise your time is tight and this is not a priority.

Cheers

Garry

Logged

pigeonhill

1155

Re: Histogram

« Reply #3 on: 23 / April / 2021, 17:27:22 »

@reyalp

I’ve just taken a quick look at the histogram module, and I think it may be simple to increase the size of the dots a little.

I’m afraid I can’t compile, so I’m not going to be able to test this tweak.

The current relevant code is:

Code: [Select]


if (conf.histo_layout != OSD_HISTO_LAYOUT_R_G_B)
        {
            if (under_exposed && conf.show_overexp)
            {
                draw_ellipse(conf.histo_pos.x+5, conf.histo_pos.y+5, 3, 3, BG_COLOR(hc2), DRAW_FILLED);
            }
            if (over_exposed && conf.show_overexp)
            {
                draw_ellipse(conf.histo_pos.x+HISTO_WIDTH-5, conf.histo_pos.y+5, 3, 3, BG_COLOR(hc2), DRAW_FILLED);
            }

I’m guessing all that needs to be changed, to test things, is the 3,3 to, say, 5,5, ie leaving the position of the dots as now.

If this simple tweak worked, we could then decide if we needed to make a more radical change, ie for the under/over to be clearer.

Logged

reyalp

14082

Re: Histogram

« Reply #4 on: 23 / April / 2021, 18:44:12 »

Quote from: pigeonhill on 23 / April / 2021, 17:27:22

I’m guessing all that needs to be changed, to test things, is the 3,3 to, say, 5,5, ie leaving the position of the dots as now.

If this simple tweak worked, we could then decide if we needed to make a more radical change, ie for the under/over to be clearer.

Updated in trunk 5850. The dots are now visually about the same size as on pre-digic 6 cams with with similar screen size.

Quote