changelog of trunk including comments / devtalk

reyalp

14080

Re: changelog of trunk including comments / devtalk

« Reply #290 on: 25 / March / 2021, 00:19:33 »

Advertisements

I noticed in DryOS r54 and later, Rec2PB (used in dryos switch_mode_usb) takes an argument. From the code, the argument should be a levent ID, or -1. For disassembly, our existing switch_mode_usb code would generally end up passing 0, since the mode argument is in r0.

Firmware that expect the argument could be identified by the string "AC:Rec2PB x Repost", but rather than adding stuff to the sig finders and a new define, in trunk 5798 I just made it pass -1 all the time.

PB2Rec still does not take arguments on these cams.

Logged

Don't forget what the H stands for.

reyalp

14080

Re: changelog of trunk including comments / devtalk

« Reply #291 on: 30 / June / 2021, 02:13:27 »

I checked in some fixes for the histogram in r5977. Long discussion with various tangents here

The main issues addressed are:
* Histogram would sample incorrect data when viewport width wasn't 720 or 960
* High res displays could overflow the histogram counter.

The changes are intended to be stay close to the old behavior (aside from the bugs) with intention of backporting it to the stable branch. I might try to do some additional optimization in the trunk after that's done.

Attached is some debugging code I used, for future reference. It times various stages parts of the process, displays viewport dimensions from CHDK and GetVRAM*PixelsSize, and the actual number of pixels sampled. It also allows drawing the sampled pixels on the viewport.

histo-debug-r5977.patch (9.78 kB - downloaded 31 times.)

Logged

Don't forget what the H stands for.

reyalp

14080

Re: changelog of trunk including comments / devtalk

« Reply #292 on: 04 / July / 2021, 02:49:13 »

In trunk r5981, I fixed some issues with the histogram used by script get_live_histo and custom auto iso:
* incorrect total for some viewport sizes
* ensure EVF and HDMI do not overflow ushort count
* ensure histogram data always initialized, make missing viewport buffer equivalent to black screen

Logged

Don't forget what the H stands for.

pigeonhill

1155

Re: changelog of trunk including comments / devtalk

« Reply #293 on: 04 / July / 2021, 03:34:57 »

@reyalp

Just downloaded r5981 on my M3 and noticed it's reverted to flashing all the time.

I thought you had incorporated the 'philmoz fixes'?

But I guess I wrong?

Logged

reyalp

14080

Re: changelog of trunk including comments / devtalk

« Reply #294 on: 04 / July / 2021, 03:40:56 »

Quote from: pigeonhill on 04 / July / 2021, 03:34:57

Just downloaded r5981 on my M3 and noticed it's reverted to flashing all the time.

I thought you had incorporated the 'philmoz fixes'?

The ximr drawing changes are not in the trunk.

The live histogram changes mentioned above probably aren't significant for you, but I did merge them into the ximr branch, so they'll be in philmoz's build whenever he updates.

Logged

Don't forget what the H stands for.

philmoz

3450

Re: changelog of trunk including comments / devtalk

« Reply #295 on: 04 / July / 2021, 03:52:47 »

@pigeonhill - ximr builds updated on Google drive with latest changes.

Logged

CHDK ports:
sx30is (1.00c, 1.00h, 1.00l, 1.00n & 1.00p)
g12 (1.00c, 1.00e, 1.00f & 1.00g)
sx130is (1.01d & 1.01f)
ixus310hs (1.00a & 1.01a)
sx40hs (1.00d, 1.00g & 1.00i)
g1x (1.00e, 1.00f & 1.00g)
g5x (1.00c, 1.01a, 1.01b)
g7x2 (1.01a, 1.01b, 1.10b)

pigeonhill

1155

Re: changelog of trunk including comments / devtalk

« Reply #296 on: 04 / July / 2021, 03:54:19 »

Cheers

Logged

reyalp

14080

Re: changelog of trunk including comments / devtalk

« Reply #297 on: 05 / July / 2021, 00:20:46 »

Histogram fixes above and Lua fixes from https://chdk.setepontos.com/index.php?topic=650.msg146578#msg146578 are merged to the 1.5 branch as of build 5987

Logged

Don't forget what the H stands for.

reyalp

14080

Re: changelog of trunk including comments / devtalk

« Reply #298 on: 31 / July / 2021, 20:31:50 »

In trunk 6003 I fixed shooting_get_user_av_id to return .id (the CHDK index / id) rather than prop_id (apex96) value. This appears to have gotten switched in r3035.

shooting_set_user_av_by_id correctly expected an id value. shooting_set_user_av_by_id_rel was broken, since it uses shooting_get_user_av_id to calculate the value for _set.

Despite changing long-standing behavior, I'll merge this to 1.5 as a bug fix (r6004), since the buggy behavior is unlikely to be useful.

« Last Edit: 31 / July / 2021, 21:10:04 by reyalp »

Logged

Don't forget what the H stands for.

Caefix

945
Sorry, busy deleting test shots...

Re: changelog of trunk including comments / devtalk

« Reply #299 on: 08 / June / 2022, 12:54:56 »

Quote from: reyalp on 04 / July / 2021, 03:40:56

Quote from: pigeonhill on 04 / July / 2021, 03:34:57
The ximr drawing changes are not in the trunk.

Code: [Select]

// md_detect.c --> void md_draw_grid()
#ifdef CAM_DRAW_RGBA
    //Drawing is on a buffer that is 1/2 width & height compared to the viewport.
    xoffset /= 2;
    yoffset /= 2;
#endif

Maybe modules with that #ifdef could already be merged to trunk...
Then for compiling ximr (modules only) @ home it was enough to add

Quote

include ../makefile_platform.inc
CAM_DRAW_RGBA = 1

to ../platform/../Makefile

« Last Edit: 08 / June / 2022, 15:36:31 by Caefix »

Logged

All lifetime is a loan from eternity.