playback key for script + key masks

reyalp

14114

« on: 02 / September / 2013, 16:05:53 »

Advertisements

re: http://chdk.setepontos.com/index.php?topic=650.msg104820#msg104820

Is there any reason not to add "playback" to the script key list? On some cameras it is also used for alt (and aliased to PRINT), so there might be some confusion when adjustable alt is involved.

edit:
Also, when adding support for these it's a good idea to check the key mask. Since mode, playback etc were not in the chdk key list at all for a long time, they might not be masked.

« Last Edit: 02 / September / 2013, 16:09:22 by reyalp »

Logged

Don't forget what the H stands for.

nafraf

1308

Re: playback key for script + key masks

« Reply #1 on: 02 / September / 2013, 23:17:14 »

I don't see any reason not to add KEY_PLAYBACK to the list.

In cameras without KEY_PRINT, ALT_MODE_BUTTON will be mandatory if alias to KEY_PRINT Is removed. (core/conf.c uses KEY_PRINT as default ALT button)

Maybe ubtest.bas script should include more keys (video, playback, mode, zoom in/out), patch in attachment.

playback_button_trunk3068.patch (1.86 kB - downloaded 35 times.)

Logged

lapser

1093

Re: playback key for script + key masks

« Reply #2 on: 03 / September / 2013, 02:01:40 »

Quote from: reyalp on 02 / September / 2013, 16:05:53

Is there any reason not to add "playback" to the script key list? On some cameras it is also used for alt (and aliased to PRINT), so there might be some confusion when adjustable alt is involved.

It's definitely a good idea. My script uses the display button, but there isn't one on the D20. The only unused buttons are playback and video, but both can be assigned as <alt>. The script checks for <display> OR <video> but I also need to accept <playback> in case <video> is <alt>.

Logged

EOS-M3_120f / SX50_100b / SX260_101a / G1X_100g / D20_100b
https://www.youtube.com/user/DrLapser/videos