if ((((cnt++) & 3) == 0) && ((camera_info.state.state_shooting_progress != SHOOTING_PROGRESS_PROCESSING) || recreview_hold || shooting_get_drive_mode())) // also redraw in continuous modes { if(camera_info.state.osd_off) { if(camera_info.state.osd_off&2) { draw_restore(); //clear screen first time camera_info.state.osd_off=1; //clear first time flag } } else gui_redraw(); }
Purpose: Hide all CHDK overlays, including OSD, Console, and bottom "<ALT>" line. This gives scripts a "clean slate" to draw on.
The attached patch adds this new Lua function to CHDK:
hide_osd(-1 | 0 | 1) -1 toggles OSD 1 hides OSD 0 shows OSD
I also added a test to do gui_redraw() in continuous mode even while processing a picture, since the last picture is being displayed along with the un-updated OSD and console. Try watching the OSD (without the patch) while taking pictures in continuous mode and you'll see it's not updating, and showing confusing info sometimes.
Including the currently loaded script title?
Not available for uBASIC?
I guess the toggle function is mostly useful if you tie it to a specific button and thus don't have to remember the current state?
Is this your continuous mode stuff or something generic?
We can add that later, if needed. Since uBasic and Lua are in modules, we could just repeat the luascript.c code in uBasic.
It's a problem outside of scripts too. Set the clock display to "seconds" and hold the shutter down in continuous mode to demonstrate. I think the screen display buffer address keeps changing with every new picture. Sometimes the clock even jumps back a little. I think that's when the camera wraps to an older screen display, and CHDK doesn't update the clock display. The patch seems to fix that.This problem also applies to the Lua drawing functions when you're drawing while taking pictures in continuous mode. You have to keep redrawing with the script.It might be better to check the screen buffer address, and force a redraw whenever it changes, rather than test for continuous mode. I haven't experimented with this idea, though.
So, per my previous posts about one change per patch file, this is seems to be something that belongs in a seperate patch / discussion? When you say "The patch seems to fix that" I don't get a warm fuzzy feeling it belongs in a discussion about hide_osd().
I'll take it out if you want. Both patches go in the same C statement, but I guess they are somewhat unrelated.
Based on this discussion, I'd say please take it out.
On a related note, I've been trying to find a "use case" for making this a CHDK menu option rather than a script command. Is there a case where you would want the CHDK icons off when you are not running a script but are in <ALT> mode? I can't think of any but its worth asking before committing this patch as just for scripts.
I'd like to hear from Phil and reyalp about the hide_osd() function. Maybe they know a better way of accomplishing the same thing?
I decided it was cleaner to put the hide_osd test at the beginning of gui_redraw() instead of in core_spytask(). I also took out the unrelated test for continuous mode, so main.c is unchanged now.
Started by 100 Script Writing
Started by trackuino LUA Scripting
Started by toinech Feature Requests
Started by Alarik General Discussion and Assistance
Started by DRmiE LUA Scripting
