Disabling Eyefi card

waterwingz

12138

Re: Disabling Eyefi card

« Reply #10 on: 08 / October / 2013, 09:17:41 »

Advertisements

Quote from: buttim on 08 / October / 2013, 09:03:15

I managed to convert the eyefi code into a flt.
I briefly tested it and noticed no differences in behavior.
Here is the patch (included a small addition for the G15 regarding key mappings).
Let me know if it seems to make any sense

Typically better not to mix patches - I'd suggest seperating them. You could just delete the first two entries in the patch file.

The process at this point is to post the patch file(s) here:

http://chdk.setepontos.com/index.php?topic=650.0

with a link to the appropriate forum thread describing what's been done.

Logged

Ported : A1200 SD940 G10 Powershot N G16

buttim

45

Re: Disabling Eyefi card

« Reply #11 on: 08 / October / 2013, 10:15:12 »

Typically better not to mix patches - I'd suggest seperating them. You could just delete the first two entries in the patch file.

The process at this point is to post the patch file(s) here:

http://chdk.setepontos.com/index.php?topic=650.0

with a link to the appropriate forum thread describing what's been done.
[/quote]

I followed your instructions, separated the modifications and posted them to the forum. Thanks for being so helpful. Hope I got it right

Logged

reyalp

14079

Re: Disabling Eyefi card

« Reply #12 on: 09 / October / 2013, 00:35:13 »

As mentioned in the patch thread, this has been added to the 1.3 trunk. Thanks to everyone who contributed.

Feedback from anyone who has these cards is welcome.

Also, if someone can add documentation to the 1.3 manual on the wiki http://chdk.wikia.com/wiki/CHDK_1.3.0_User_Manual that would be helpful. You can use chdkptp to make screenshots of the menus.

It occurs to me that being able to control the eyefi from script might be a useful addition.

Logged

Don't forget what the H stands for.

philmoz

3450

Re: Disabling Eyefi card

« Reply #13 on: 09 / October / 2013, 06:16:39 »

Quote from: reyalp on 09 / October / 2013, 00:35:13

As mentioned in the patch thread, this has been added to the 1.3 trunk. Thanks to everyone who contributed.

Feedback from anyone who has these cards is welcome.

Also, if someone can add documentation to the 1.3 manual on the wiki http://chdk.wikia.com/wiki/CHDK_1.3.0_User_Manual that would be helpful. You can use chdkptp to make screenshots of the menus.

It occurs to me that being able to control the eyefi from script might be a useful addition.

Looks good - a couple of comments on the module implementation:
- the module does not unload if there is no eye-fi card present
- the 'default_libeyefi' structure is not complete, calling any function without calling 'init' first will crash. Dummy entries should be added for all functions.
- duplicated code in gui.c functions could be re-factored to save space. At first glance some of the code in gui.c looks like it should belong in the module (but I haven't looked at it closely enough to say for sure).

Phil.

Logged

CHDK ports:
sx30is (1.00c, 1.00h, 1.00l, 1.00n & 1.00p)
g12 (1.00c, 1.00e, 1.00f & 1.00g)
sx130is (1.01d & 1.01f)
ixus310hs (1.00a & 1.01a)
sx40hs (1.00d, 1.00g & 1.00i)
g1x (1.00e, 1.00f & 1.00g)
g5x (1.00c, 1.01a, 1.01b)
g7x2 (1.01a, 1.01b, 1.10b)

buttim

45

Re: Disabling Eyefi card

« Reply #14 on: 09 / October / 2013, 06:21:51 »

Quote from: philmoz on 09 / October / 2013, 06:16:39

- the module does not unload if there is no eye-fi card present

can you give me a hint on how to do it?

Quote from: philmoz on 09 / October / 2013, 06:16:39

- the 'default_libeyefi' structure is not complete, calling any function without calling 'init' first will crash. Dummy entries should be added for all functions.

Ok. Are really dummy entries to be put in or stubss that load the module and call the actual function? (like in the init case)

Quote from: philmoz on 09 / October / 2013, 06:16:39

- duplicated code in gui.c functions could be re-factored to save space. At first glance some of the code in gui.c looks like it should belong in the module (but I haven't looked at it closely enough to say for sure).

Ok, I will hammer it a bit

Logged

philmoz

3450

Re: Disabling Eyefi card

« Reply #15 on: 09 / October / 2013, 17:20:18 »

Quote from: buttim on 09 / October / 2013, 06:21:51

Quote from: philmoz on 09 / October / 2013, 06:16:39
- the module does not unload if there is no eye-fi card present
can you give me a hint on how to do it?

If the _module_can_unload function returns non-zero then the system will unload the module. Modules like DNG.C use an internal 'running' flag to determine if they are still performing operations or can be unloaded.
The _module_unloader function will be called just before your module is removed, perform any needed cleanup here (freeing memory, etc).

Quote

Quote from: philmoz on 09 / October / 2013, 06:16:39
- the 'default_libeyefi' structure is not complete, calling any function without calling 'init' first will crash. Dummy entries should be added for all functions.
Ok. Are really dummy entries to be put in or stubss that load the module and call the actual function? (like in the init case)

The dummy entries just do nothing in the case that someone calls the function before the module is loaded - prevents crashes if someone tries to use the code in an unexpected manner.

Alternatively you could implement some or all the default functions to load the module and call init automatically - that way any of the functions can be safely called at any time.

Phil.

Logged

CHDK ports:
sx30is (1.00c, 1.00h, 1.00l, 1.00n & 1.00p)
g12 (1.00c, 1.00e, 1.00f & 1.00g)
sx130is (1.01d & 1.01f)
ixus310hs (1.00a & 1.01a)
sx40hs (1.00d, 1.00g & 1.00i)
g1x (1.00e, 1.00f & 1.00g)
g5x (1.00c, 1.01a, 1.01b)
g7x2 (1.01a, 1.01b, 1.10b)