cleanup of Show OSD menu item - page 2 - General Discussion and Assistance - CHDK Forum supplierdeeply
« previous next »
Pages: 1 [2]   Go Down

cleanup of Show OSD menu item

  • 15 Replies
  • 4820 Views
*

Offline waterwingz

  • ******
  • 12064
    • Waterwingz
Re: cleanup of Show OSD menu item
« Reply #10 on: 17 / October / 2013, 20:48:35 »
Advertisements
Quote from: philmoz on 17 / October / 2013, 01:26:02
Mainly concerned that nothing is substantially broken.
Doing a bit of script work today - made a point to enable & disable various OSD funtions.  Seems to be okay but its not exactly an exhaustive test  ( G10 ).

Quote
The debug display takes up most of the screen - not sure there's much point being able to move it?
Debug & misc values kind hog the top / middle of the screen.  Not a big deal - more a personal preference to be alble to push them off to one side.
Logged
Ported :   A1200    SD940   G10    Powershot N    G16
*

Offline philmoz

  • *****
  • 3226
    • Photos
Re: cleanup of Show OSD menu item
« Reply #11 on: 15 / November / 2013, 19:49:15 »
Updated version of the patch.
I've added some more state variables that record the current mode (camera & CHDK) - I think this makes the code easier to understand; but may not be to every ones liking.

Testing and comments appreciated.

AFAIK this doesn't change any of the existing OSD functionality - if no-one finds any major issues I'll add this to SVN.

Phil.
Logged
CHDK ports:
  sx30is (1.00c, 1.00h, 1.00l, 1.00n & 1.00p)
  g12 (1.00c, 1.00e, 1.00f & 1.00g)
  sx130is (1.01d & 1.01f)
  ixus310hs (1.00a & 1.01a)
  sx40hs (1.00d, 1.00g & 1.00i)
  g1x (1.00e, 1.00f & 1.00g)
  g5x (1.00c, 1.01a, 1.01b)
  g7x2 (1.01a, 1.01b, 1.10b)
*

Offline philmoz

  • *****
  • 3226
    • Photos
Re: cleanup of Show OSD menu item
« Reply #12 on: 17 / November / 2013, 06:46:39 »
Quote from: philmoz on 15 / November / 2013, 19:49:15
Updated version of the patch.
I've added some more state variables that record the current mode (camera & CHDK) - I think this makes the code easier to understand; but may not be to every ones liking.

Testing and comments appreciated.

AFAIK this doesn't change any of the existing OSD functionality - if no-one finds any major issues I'll add this to SVN.

Phil.

Added to trunk in revision 3232.

Fingers crossed it all works correctly; but in case anyone notices any strange behaviour please report it here.

Phil.
Logged
CHDK ports:
  sx30is (1.00c, 1.00h, 1.00l, 1.00n & 1.00p)
  g12 (1.00c, 1.00e, 1.00f & 1.00g)
  sx130is (1.01d & 1.01f)
  ixus310hs (1.00a & 1.01a)
  sx40hs (1.00d, 1.00g & 1.00i)
  g1x (1.00e, 1.00f & 1.00g)
  g5x (1.00c, 1.01a, 1.01b)
  g7x2 (1.01a, 1.01b, 1.10b)
*

Offline msl

  • *****
  • 1274
  • A720 IS, SX220 HS 1.01a
    • CHDK-DE links
Re: cleanup of Show OSD menu item
« Reply #13 on: 17 / November / 2013, 08:35:33 »
Thanks for your work.

I have tested a little bit and see one small issue. Live histogram -  option [shoot] - there is no histogram display, when I press 'shoot half'.

msl
Logged
CHDK-DE:  CHDK-DE links
*

Offline philmoz

  • *****
  • 3226
    • Photos
Re: cleanup of Show OSD menu item
« Reply #14 on: 17 / November / 2013, 14:03:51 »
Quote from: msl on 17 / November / 2013, 08:35:33
Thanks for your work.

I have tested a little bit and see one small issue. Live histogram -  option [shoot] - there is no histogram display, when I press 'shoot half'.

msl

Thanks, should be fixed in 3234.

Phil.
Logged
CHDK ports:
  sx30is (1.00c, 1.00h, 1.00l, 1.00n & 1.00p)
  g12 (1.00c, 1.00e, 1.00f & 1.00g)
  sx130is (1.01d & 1.01f)
  ixus310hs (1.00a & 1.01a)
  sx40hs (1.00d, 1.00g & 1.00i)
  g1x (1.00e, 1.00f & 1.00g)
  g5x (1.00c, 1.01a, 1.01b)
  g7x2 (1.01a, 1.01b, 1.10b)
*

Offline philmoz

  • *****
  • 3226
    • Photos
Re: cleanup of Show OSD menu item
« Reply #15 on: 17 / November / 2013, 17:33:30 »
One outstanding item in this cleanup is the call to 'gps_startup' (gps.c) in the 'gui_draw_osd' function (gui_osd.c).

The 'gps_startup' function creates a GPS task, and I don't really think the call belongs in the OSD draw function.
It also does not get called if the CHDK OSD is turned off, or if the shutter is half pressed.

I think the call should be moved; but I need someone who can test it. Any volunteers?

Phil.
Logged
CHDK ports:
  sx30is (1.00c, 1.00h, 1.00l, 1.00n & 1.00p)
  g12 (1.00c, 1.00e, 1.00f & 1.00g)
  sx130is (1.01d & 1.01f)
  ixus310hs (1.00a & 1.01a)
  sx40hs (1.00d, 1.00g & 1.00i)
  g1x (1.00e, 1.00f & 1.00g)
  g5x (1.00c, 1.01a, 1.01b)
  g7x2 (1.01a, 1.01b, 1.10b)
Pages: 1 [2]   Go Up
« previous next »
 

Related Topics