supplierdeeply

CAM_HAS_VARIABLE_ASPECT cleanup

  • 6 Replies
  • 890 Views
*

Offline reyalp

  • ******
  • 11336
CAM_HAS_VARIABLE_ASPECT cleanup
« on: 29 / December / 2013, 19:04:24 »
Advertisements
This confusing ifdef came to my attention in: http://chdk.setepontos.com/index.php?topic=11064.0

Per the comment (by philmoz I think) in

Quote
For older cameras (that do not define CAM_USES_ASPECT_CORRECTION) the
aspect ratio is controlled by the CAM_HAS_VARIABLE_ASPECT value
in platform_camera.h (camera_screen.has_variable_aspect). Defining
this value tells the code that the camera has a 16:9 LCD but can
also display a 4:3 image with black bars on the left and right.

Grepping the code confirms this and  is the only place it is used.

However, it was defined for a lot of cameras that do *not* have a 16:9 LCD but also define CAM_USES_ASPECT_CORRECTION. This has no effect beyond being confusing, since CAM_USES_ASPECT_CORRECTION avoids the old code path completely.

In trunk changeset 3285 I have removed this define from all cams that also have CAM_USES_ASPECT_CORRECTION set.

The affected cameras are
Code: [Select]
a1200
a1300
a2300
a2400
a3400
a4000
a810
ixus1000_sd4500
ixus115_elph100hs
ixus125_elph110hs
ixus220_elph300hs
ixus230_elph310hs
ixus300_sd4000
sx210is
sx220hs
sx230hs
While I'm pretty sure these are OK, I would appreciate anyone who has one of these cameras verifying that the zebra still works.

That leaves only sx1 using the CAM_HAS_VARIABLE_ASPECT. If we can fix this and find a tester, we can probably remove the define and associated variant of the zebra code completely.
Don't forget what the H stands for.

Re: CAM_HAS_VARIABLE_ASPECT cleanup
« Reply #1 on: 04 / December / 2014, 08:36:10 »
I have a ELPH 310 and the zebra doesn't seem to work at all, (using the button combinations shown) other features do work as far as I can tell.

Thank You

*

Offline koshy

  • *****
  • 775
Re: CAM_HAS_VARIABLE_ASPECT cleanup
« Reply #2 on: 04 / December / 2014, 14:40:50 »
While I'm pretty sure these are OK, I would appreciate anyone who has one of these cameras verifying that the zebra still works.
A1200
A1300
A810
IXUS 1000
IXUS 125

Are in the group of cameras I still have. The others I no longer do. I'll look at those five.

That leaves only sx1 using the CAM_HAS_VARIABLE_ASPECT. If we can fix this and find a tester, we can probably remove the define and associated variant of the zebra code completely.
The SX1 shoots RAW natively and I didn't get one as I had access to it when it was released. So, sorry I can't help with that.

*

Offline koshy

  • *****
  • 775
Re: CAM_HAS_VARIABLE_ASPECT cleanup
« Reply #3 on: 04 / December / 2014, 16:42:10 »
A1200: zebra works
A1300: zebra works
A810: zebra works
IXUS 1000: zebra works
IXUS 125: zebra works


*

Offline koshy

  • *****
  • 775
Re: CAM_HAS_VARIABLE_ASPECT cleanup
« Reply #4 on: 04 / December / 2014, 16:44:49 »
I have a ELPH 310 and the zebra doesn't seem to work at all, (using the button combinations shown) other features do work as far as I can tell.
You need to enable the CHDK zebra feature, maybe set Exposure compensation to +2 or so, point the camera to a lamp or something bright and press the shutter halfway to get the zebra to show up on the camera's display. Did you test it that way?

*

Offline reyalp

  • ******
  • 11336
Re: CAM_HAS_VARIABLE_ASPECT cleanup
« Reply #5 on: 04 / December / 2014, 21:22:58 »
Thanks for checking. Since the OP s about a year old, the change in question is almost certainly OK. Would be nice to fix the SX1, would let us clean up the zebra code quite a bit.

I guess craigar found this thread based on the mention of zebra. The cameras porting thread is usually a better place bugs.
Don't forget what the H stands for.

*

Offline koshy

  • *****
  • 775
Re: CAM_HAS_VARIABLE_ASPECT cleanup
« Reply #6 on: 05 / December / 2014, 08:41:39 »
Since the OP s about a year old, the change in question is almost certainly OK.
My mistake... With just one reply and the thing showing up at the top of the list I didn't read the date on the OP... Well, checking zebra on 5 cams didn't take all that long so just a little wasted time :)

 

Related Topics