supplierdeeply

An issue with the histogram display options

  • 7 Replies
  • 1051 Views
*

Offline msl

  • *****
  • 1235
  • A720 IS, SX220 HS 1.01a
    • CHDK inside
An issue with the histogram display options
« on: 17 / January / 2014, 07:39:56 »
Advertisements
We have three options for displaying of the histogram: 'don't', 'always', 'shoot'. An user from the German CHDK forum misses a fourth option: 'always only in record mode'

We have two possibilities: 1. Add a new option in histogram menu or 2. unload the histogram module when the OSD option 'hide in play mode' is active and the camera is in play mode.

I think, the second way is the better solution for the CHDK OSD concept.

msl
« Last Edit: 18 / January / 2014, 15:29:48 by msl »
German CHDK pages:  CHDK forum | CHDK inside | CHDK Twitter News by msl | Download CHDK-DE (Autobuild)
Note: SDM violates the GPL rules!

*

Offline msl

  • *****
  • 1235
  • A720 IS, SX220 HS 1.01a
    • CHDK inside
Re: An issue with the histogram display options
« Reply #1 on: 18 / January / 2014, 15:38:10 »
Attached is a solution for an additional option in the histogram menu: [Don't, Always, Rec, Shoot]. 'Rec' means, the histogram is displayed only in recording mode for photos.

msl

German CHDK pages:  CHDK forum | CHDK inside | CHDK Twitter News by msl | Download CHDK-DE (Autobuild)
Note: SDM violates the GPL rules!

*

Offline srsa_4c

  • ******
  • 3629
Re: An issue with the histogram display options
« Reply #2 on: 19 / January / 2014, 09:32:55 »
Attached is a solution for an additional option in the histogram menu: [Don't, Always, Rec, Shoot]. 'Rec' means, the histogram is displayed only in recording mode for photos.
Seems to work for me.
edit: tried your USB state patch as well, also working.
« Last Edit: 19 / January / 2014, 09:38:41 by srsa_4c »

*

Offline msl

  • *****
  • 1235
  • A720 IS, SX220 HS 1.01a
    • CHDK inside
Re: An issue with the histogram display options
« Reply #3 on: 19 / January / 2014, 12:42:30 »
Thanks for the reply.

If there are no other objections I will check in the patch.

msl
German CHDK pages:  CHDK forum | CHDK inside | CHDK Twitter News by msl | Download CHDK-DE (Autobuild)
Note: SDM violates the GPL rules!


*

Offline reyalp

  • ******
  • 11336
Re: An issue with the histogram display options
« Reply #4 on: 19 / January / 2014, 17:24:30 »
Thanks for doing this, it seems like a good idea to me.

One comment: this changes the meaning of the value in the users cfg, so if they hard "half" before it will now be rec. I'm not sure this is a big deal, the order of options is more logical the way you have it, but it could cause some confusion.
Don't forget what the H stands for.

*

Offline msl

  • *****
  • 1235
  • A720 IS, SX220 HS 1.01a
    • CHDK inside
Re: An issue with the histogram display options
« Reply #5 on: 20 / January / 2014, 04:10:16 »
Thanks for your statement.
I think, the new order is more important as a compatibility to the old configuration. This is 'only' the OSD configrationen and not the core.

A side effect could be, the user sees, something has changed. ;)

msl
German CHDK pages:  CHDK forum | CHDK inside | CHDK Twitter News by msl | Download CHDK-DE (Autobuild)
Note: SDM violates the GPL rules!

*

Offline philmoz

  • *****
  • 3070
    • Photos
Re: An issue with the histogram display options
« Reply #6 on: 20 / January / 2014, 04:46:49 »
Thanks for your statement.
I think, the new order is more important as a compatibility to the old configuration. This is 'only' the OSD configrationen and not the core.

A side effect could be, the user sees, something has changed. ;)

msl

I agree the more logical order is better.

Perhaps add a check in the 'config_restore_1_2()' function (conf.c) to convert the 'Shoot' value when loading a 1.2 config file into 1.3. At least this way users won't get a surprise when 1.3 becomes the stable version.

Phil.
CHDK ports:
  sx30is (1.00c, 1.00h, 1.00l, 1.00n & 1.00p)
  g12 (1.00c, 1.00e, 1.00f & 1.00g)
  sx130is (1.01d & 1.01f)
  ixus310hs (1.00a & 1.01a)
  sx40hs (1.00d, 1.00g & 1.00i)
  g1x (1.00e, 1.00f & 1.00g)

*

Offline msl

  • *****
  • 1235
  • A720 IS, SX220 HS 1.01a
    • CHDK inside
Re: An issue with the histogram display options
« Reply #7 on: 21 / January / 2014, 06:11:35 »
I have added the patch in r3326.

Maybe phil's proposal is useful.

msl

German CHDK pages:  CHDK forum | CHDK inside | CHDK Twitter News by msl | Download CHDK-DE (Autobuild)
Note: SDM violates the GPL rules!


 

Related Topics