Bug report: || fixed for: A3000, A3100, IXUS 130

koshy

1055

« on: 26 / June / 2014, 21:17:53 »

Advertisements

Hello all,

I'd like to report what might be a bug affecting the cameras A3000, A3100, IXUS 130.

When checking "write RAW" and "RAW in folder with JPEG" the DNG files do not get created. Instead there is the JPEG (e.g. IMG_1780.JPG) and an empty folder within the JPEG directory. The folder name is ETC_1780.TMP in the example. The folder is empty.
When "RAW in folder with JPEG" is unchecked the DNG files get created normally in their own folder.

I have tested this with around 40 other camera models and thus far these three are the only ones I had trouble of that nature with.

« Last Edit: 22 / July / 2014, 10:23:20 by koshy »

Logged

Koshy had a little ELPH which wasn't white as snow but everywhere that Koshy went the ELPH was sure to go. (actually an SD, but that detail ruins the rhyme...)

waterwingz

12058

Re: Bug report? A3000, A3100, IXUS 130

« Reply #1 on: 26 / June / 2014, 21:52:41 »

I'm guessing it's the same bug I noted here : Time for better folder naming for saving RAW/DNG ?

It's in the "Side Note" at the bottom of the first post. Philmoz was going to look and see if its a sigfinder problem.

Meanwhile, I have not exactly been flooded with comments about the patch I posted at the end of the thread. It's slow days in CHDK land.

Edit : 40 CHDK capable camera models? We really could have used you help with the upgrade testing to CHDK manual focus / SD override capability !

« Last Edit: 26 / June / 2014, 22:09:59 by waterwingz »

Logged

Ported : A1200 SD940 G10 Powershot N G16

reyalp

12868

Re: Bug report? A3000, A3100, IXUS 130

« Reply #2 on: 27 / June / 2014, 01:42:05 »

Quote from: koshy on 26 / June / 2014, 21:17:53

Hello all,

I'd like to report what might be a bug affecting the cameras A3000, A3100, IXUS 130.

The same fix used on other cameras can probably be used. If you post which firmware versions you have, we can make test builds.

Logged

Don't forget what the H stands for.

philmoz

3225

Re: Bug report? A3000, A3100, IXUS 130

« Reply #3 on: 27 / June / 2014, 04:53:37 »

Quote from: reyalp on 27 / June / 2014, 01:42:05

Quote from: koshy on 26 / June / 2014, 21:17:53
Hello all,

I'd like to report what might be a bug affecting the cameras A3000, A3100, IXUS 130.
The same fix used on other cameras can probably be used. If you post which firmware versions you have, we can make test builds.

I think it needs different values for the third parameter to _GetImageFolder.

For A3000 try 0x100
For IXUS140 and SX510 try 0x80

Note: some cameras set this value in the 'CAM_DATE_FOLDER_NAMING' #define.

Will try and add detection for this in finsig.
Edit: detection added in revisions 3480 & 3481 (trunk).

Phil.

« Last Edit: 27 / June / 2014, 05:55:25 by philmoz »

Logged

CHDK ports:
sx30is (1.00c, 1.00h, 1.00l, 1.00n & 1.00p)
g12 (1.00c, 1.00e, 1.00f & 1.00g)
sx130is (1.01d & 1.01f)
ixus310hs (1.00a & 1.01a)
sx40hs (1.00d, 1.00g & 1.00i)
g1x (1.00e, 1.00f & 1.00g)
g5x (1.00c, 1.01a, 1.01b)
g7x2 (1.01a, 1.01b, 1.10b)

koshy

1055

Re: Bug report? A3000, A3100, IXUS 130

« Reply #4 on: 27 / June / 2014, 07:10:58 »

Quote from: reyalp on 27 / June / 2014, 01:42:05

The same fix used on other cameras can probably be used. If you post which firmware versions you have, we can make test builds.

Firmware versions:

A3000: 100 d
A3100: 100 d
IXUS 130: 100 c

Quote from: philmoz on 27 / June / 2014, 04:53:37

Edit: detection added in revisions 3480 & 3481 (trunk).

Does that mean that it would be useful at this point for me to make auto builds and test this with the current trunk version?

Logged

Koshy had a little ELPH which wasn't white as snow but everywhere that Koshy went the ELPH was sure to go. (actually an SD, but that detail ruins the rhyme...)

philmoz

3225

Re: Bug report? A3000, A3100, IXUS 130

« Reply #5 on: 27 / June / 2014, 07:41:15 »

Quote from: koshy on 27 / June / 2014, 07:10:58

Quote from: reyalp on 27 / June / 2014, 01:42:05
The same fix used on other cameras can probably be used. If you post which firmware versions you have, we can make test builds.

Firmware versions:

A3000: 100 d
A3100: 100 d
IXUS 130: 100 c

Quote from: philmoz on 27 / June / 2014, 04:53:37
Edit: detection added in revisions 3480 & 3481 (trunk).

Does that mean that it would be useful at this point for me to make auto builds and test this with the current trunk version?

Not yet - I've added the detection; but haven't fixed the actual calls to GetImageFolder yet.

Edit: I've fixed the CAM_DATE_FOLDER_NAMING values and calls to GetImageFolder in revision 3484 (trunk only). Please retest the affected cameras once this is available on the autobuild server.

Phil.

« Last Edit: 27 / June / 2014, 08:42:01 by philmoz »

Logged

CHDK ports:
sx30is (1.00c, 1.00h, 1.00l, 1.00n & 1.00p)
g12 (1.00c, 1.00e, 1.00f & 1.00g)
sx130is (1.01d & 1.01f)
ixus310hs (1.00a & 1.01a)
sx40hs (1.00d, 1.00g & 1.00i)
g1x (1.00e, 1.00f & 1.00g)
g5x (1.00c, 1.01a, 1.01b)
g7x2 (1.01a, 1.01b, 1.10b)

waterwingz

12058

Re: Bug report? A3000, A3100, IXUS 130

« Reply #6 on: 27 / June / 2014, 09:29:33 »

Quote from: philmoz on 27 / June / 2014, 07:41:15

Not yet - I've added the detection; but haven't fixed the actual calls to GetImageFolder yet.

Edit: I've fixed the CAM_DATE_FOLDER_NAMING values and calls to GetImageFolder in revision 3484 (trunk only). Please retest the affected cameras once this is available on the autobuild server.

Do you think you'll be able to have the sigfinder add a note in stubs_entry.S or is this just something a person doing a port needs to be aware of?

And I guess it's okay to leave the shooting.c hack the way it is for those cameras that implemented it :

Code: [Select]

_GetImageFolder(buf,get_file_next_counter(),CAM_DATE_FOLDER_NAMING,time(NULL));
    strncpy(out,buf,15);
    out[15] = 0;

Logged

Ported : A1200 SD940 G10 Powershot N G16

koshy

1055

Re: Bug report? A3000, A3100, IXUS 130

« Reply #7 on: 27 / June / 2014, 12:53:33 »

Quote from: philmoz on 27 / June / 2014, 07:41:15

Edit: I've fixed the CAM_DATE_FOLDER_NAMING values and calls to GetImageFolder in revision 3484 (trunk only). Please retest the affected cameras

I built trunk 3484 (bless the author(s) of CHDK Shell) and have tested the three cameras. They are perfectly fine now and all write DNGs into the JPEG folder. Well done and a bug fix below 24 hours. If I come across more cameras that have this issue I'll let y'all know.

Logged

Koshy had a little ELPH which wasn't white as snow but everywhere that Koshy went the ELPH was sure to go. (actually an SD, but that detail ruins the rhyme...)

philmoz

3225

Re: Bug report? A3000, A3100, IXUS 130

« Reply #8 on: 27 / June / 2014, 17:30:56 »

Quote from: waterwingz on 27 / June / 2014, 09:29:33

Quote from: philmoz on 27 / June / 2014, 07:41:15
Not yet - I've added the detection; but haven't fixed the actual calls to GetImageFolder yet.

Edit: I've fixed the CAM_DATE_FOLDER_NAMING values and calls to GetImageFolder in revision 3484 (trunk only). Please retest the affected cameras once this is available on the autobuild server.
Do you think you'll be able to have the sigfinder add a note in stubs_entry.S or is this just something a person doing a port needs to be aware of?

Like this

Code: [Select]

//#define CAM_DATE_FOLDER_NAMING 0x400 // Found @0xff32467c (pass as 3rd param to GetImageFolder)

Quote

And I guess it's okay to leave the shooting.c hack the way it is for those cameras that implemented it :
Code: [Select]
_GetImageFolder(buf,get_file_next_counter(),CAM_DATE_FOLDER_NAMING,time(NULL)); strncpy(out,buf,15); out[15] = 0;

I left those alone for now - the code won't cause any problems, and can be removed after the fix is retested on the affected cameras.

Phil.

Logged

CHDK ports:
sx30is (1.00c, 1.00h, 1.00l, 1.00n & 1.00p)
g12 (1.00c, 1.00e, 1.00f & 1.00g)
sx130is (1.01d & 1.01f)
ixus310hs (1.00a & 1.01a)
sx40hs (1.00d, 1.00g & 1.00i)
g1x (1.00e, 1.00f & 1.00g)
g5x (1.00c, 1.01a, 1.01b)
g7x2 (1.01a, 1.01b, 1.10b)

koshy

1055

Re: Bug report? A3000, A3100, IXUS 130

« Reply #9 on: 12 / July / 2014, 14:39:13 »

Quote from: philmoz on 27 / June / 2014, 17:30:56

I left those alone for now - the code won't cause any problems, and can be removed after the fix is retested on the affected cameras.

I tested it once and it worked as reported, did you change anything else so that I should test it again?
If so which version do I need to build?

Logged

Koshy had a little ELPH which wasn't white as snow but everywhere that Koshy went the ELPH was sure to go. (actually an SD, but that detail ruins the rhyme...)