Flash hot shoe - override the switch - page 5 - General Discussion and Assistance - CHDK Forum
« previous next »
Pages: 1 2 3 4 [5]   Go Down

Flash hot shoe - override the switch

  • 42 Replies
  • 18075 Views
*

Offline philmoz

  • *****
  • 3450
    • Photos
Re: Flash hot shoe - override the switch
« Reply #40 on: 07 / October / 2014, 04:18:02 »
Advertisements
Quote from: srsa_4c on 04 / October / 2014, 10:26:47
Quote from: srsa_4c on 27 / September / 2014, 19:06:28
I'm now considering the usage of localized strings for the options...
New iteration, the only change is the location of the menu item and its wording. It's now fully localized.

Current wording is

Hotshoe override [Off/Empty/In use]

Since using language strings in enums has some overhead (needs a separate function), would it be possible to use enums that consist of language string IDs?

Quote from: philmoz on 27 / September / 2014, 18:22:07
Another suggestion that might make it easier to understand would be to use two-variable (bool for override enable / disable and an int for the forced state). The menu entry could then be a MENUITEM_STATE_VAL_PAIR so it shows with both the checkbox and value in the menu.
That would look better, but it would require an additional conf variable (waste of space for 2 bits of data IMHO) and additional RAM.

I hereby give permission to anyone to check this in - either in modified or unmodified form.

Added to trunk in revision 3645.

Also included a small change to allow language string num values to be used in menu item string arrays (to avoid the function overhead for a simple menu item).

Phil.
Logged
CHDK ports:
  sx30is (1.00c, 1.00h, 1.00l, 1.00n & 1.00p)
  g12 (1.00c, 1.00e, 1.00f & 1.00g)
  sx130is (1.01d & 1.01f)
  ixus310hs (1.00a & 1.01a)
  sx40hs (1.00d, 1.00g & 1.00i)
  g1x (1.00e, 1.00f & 1.00g)
  g5x (1.00c, 1.01a, 1.01b)
  g7x2 (1.01a, 1.01b, 1.10b)
*

Offline msl

  • *****
  • 1280
  • A720 IS, SX220 HS 1.01a
    • CHDK-DE links
Re: Flash hot shoe - override the switch
« Reply #41 on: 07 / October / 2014, 06:35:01 »
Thanks for this language option.

It would probably be better to place the new menu entry for hot shoe override after the entry "ONLY in video".

msl
Logged
CHDK-DE:  CHDK-DE links
*

Offline srsa_4c

  • ******
  • 4451
Re: Flash hot shoe - override the switch
« Reply #42 on: 07 / October / 2014, 13:36:18 »
Quote from: philmoz on 07 / October / 2014, 04:18:02
Added to trunk in revision 3645.

Also included a small change to allow language string num values to be used in menu item string arrays (to avoid the function overhead for a simple menu item).
Thanks for both!

Quote from: msl on 07 / October / 2014, 06:35:01
It would probably be better to place the new menu entry for hot shoe override after the entry "ONLY in video".
Good catch, I wasn't paying enough attention. Fixed that (and disabled the sx20) in changeset 3647.
Logged
Pages: 1 2 3 4 [5]   Go Up
« previous next »
 

Related Topics


SimplePortal © 2008-2014, SimplePortal