Please tell me if script have redundant lines. (proper use of shoot_half/full) - General Discussion and Assistance - CHDK Forum
« previous next »
Pages: [1]   Go Down

Please tell me if script have redundant lines. (proper use of shoot_half/full)

  • 3 Replies
  • 4538 Views
*

Offline Andre-K

  • **
  • 55
Please tell me if script have redundant lines. (proper use of shoot_half/full)
« on: 10 / October / 2014, 14:36:50 »
Advertisements
for years, I've been using a script with this code:  (on a Powershot S100)

Code: [Select]
    press("shoot_half")
    repeat sleep(50) until get_shooting() == true
    press("shoot_full")
    sleep(500)
    release("shoot_full")
    repeat sleep(50) until get_shooting() == false
    release("shoot_half")

Just recently, I reduced the sleep from 50 to 10ms to reduce latency (automated task)

I wonder whatever there is any reason to     "repeat sleep(50) until get_shooting() == false"  ?
what good does it do ? , can't I just release shoot_full then shoot_half ?
Also:  the sleep(500),   would it just if it was reduced to 200ms ? I don't remember the exact reason for why I set it to 500ms years ago.
Logged
*

Offline waterwingz

  • ******
  • 12140
    • Waterwingz
Re: Please tell me if script have redundant lines. (proper use of shoot_half/full)
« Reply #1 on: 10 / October / 2014, 17:03:43 »
Quote from: Andre-K on 10 / October / 2014, 14:36:50
I wonder whatever there is any reason to     "repeat sleep(50) until get_shooting() == false"  ? what good does it do ?
That's only there so that your script knows that the shot has actually completed.  If you did not do that test and looped back around to the initial press("shoot_half") you could go right through to the shoot_full without the camera having set focus and exposure for the next shot.


Quote
, can't I just release shoot_full then shoot_half ?what good does it do ?
When you release("shoot_full") it actually releases the "shoot_half" button press at the same time.  You have to do a release("shoot_full_only") if you want to prevent that.

Quote
Also:  the sleep(500),   would it just if it was reduced to 200ms ? I don't remember the exact reason for why I set it to 500ms years ago.
It's almost certainly picked because it is a fairly short value that seems to work on most cameras and in most shooting circumstances.   Your best bet is to test 200mS and see what happens.
Logged
Ported :   A1200    SD940   G10    Powershot N    G16
*

Offline Andre-K

  • **
  • 55
Re: Please tell me if script have redundant lines. (proper use of shoot_half/full)
« Reply #2 on: 10 / October / 2014, 17:28:06 »
Thank you, your first comment was actually about the first wait, between press_half and press_full.
That I understand.
The second one, between release_half and release_full  is pointless - right ?

I guess this will work just as fine.
Code: [Select]
press("shoot_half")
    repeat sleep(50) until get_shooting() == true
    press("shoot_full")
    sleep(200)
    release("shoot_half")
Logged
*

Offline waterwingz

  • ******
  • 12140
    • Waterwingz
Re: Please tell me if script have redundant lines. (proper use of shoot_half/full)
« Reply #3 on: 10 / October / 2014, 18:40:49 »
Quote from: Andre-K on 10 / October / 2014, 17:28:06
Thank you, your first comment was actually about the first wait, between press_half and press_full.
That I understand.
The second one, between release_half and release_full  is pointless - right ?

I guess this will work just as fine.
Code: [Select]
press("shoot_half")
  repeat sleep(50) until get_shooting() == true 
  press("shoot_full")
  sleep(200)
  release("shoot_half")

Note change in last line :
Code: [Select]
press("shoot_half")
repeat sleep(50) until get_shooting() == true
press("shoot_full")
sleep(200)
release("shoot_full")should work unless you do something like this :


Code: [Select]
repeat
    press("shoot_half")
    repeat sleep(50) until get_shooting() == true
    press("shoot_full")
    sleep(200)
    release("shoot_full")
until falseThen you need the sleep / get_shooting() == false after the release("shoot_full")


Logged
Ported :   A1200    SD940   G10    Powershot N    G16
Pages: [1]   Go Up
« previous next »
 

Related Topics


SimplePortal © 2008-2014, SimplePortal