Custom Colors : standardizing a semi-transparent grey - page 3 - General Discussion and Assistance - CHDK Forum
« previous next »
Pages: 1 2 [3] 4 5 6 7 8 ... 11   Go Down

Custom Colors : standardizing a semi-transparent grey

  • 106 Replies
  • 38046 Views
*

Offline philmoz

  • *****
  • 3450
    • Photos
Re: Custom Colors : standardizing a semi-transparent grey
« Reply #20 on: 22 / October / 2014, 17:17:52 »
Advertisements
Quote from: waterwingz on 22 / October / 2014, 09:34:13
Also ...

Quote from: philmoz on 22 / October / 2014, 04:28:28
3. Replace COLOR_SELECTED_FG and COLOR_SELECTED_BG.
These are only used for the menu 'cursor' highlight. I think they should simply default to COLOR_GREY_DK and COLOR_WHITE respectively (e.g. the inverse of the normal menu item colors).
In palette 16 ( three of my ports ) the cursor is blue & yellow.  That;'s what was used for all the menu screen shots in the User Manual :


I happen to think it looks nice & distinctive but personal tastes will vary.  If we want to standardize on simply inverse of the normal menu line then I guess that's okay.

I'm fine with blue & yellow as default cursor colors - easier to change one line of code than all the images in the user manual :)

Phil.
Logged
CHDK ports:
  sx30is (1.00c, 1.00h, 1.00l, 1.00n & 1.00p)
  g12 (1.00c, 1.00e, 1.00f & 1.00g)
  sx130is (1.01d & 1.01f)
  ixus310hs (1.00a & 1.01a)
  sx40hs (1.00d, 1.00g & 1.00i)
  g1x (1.00e, 1.00f & 1.00g)
  g5x (1.00c, 1.01a, 1.01b)
  g7x2 (1.01a, 1.01b, 1.10b)
*

Offline waterwingz

  • ******
  • 12140
    • Waterwingz
Re: Custom Colors : standardizing a semi-transparent grey
« Reply #21 on: 22 / October / 2014, 19:44:01 »
Quote from: philmoz on 22 / October / 2014, 17:10:51
Quote
Is this a good time to add   #define COLOR_TRANS_GREY  ..   take the risk of adding to the custom palette and default to COLOR_GREY_LT if not defined there ?
Still not sure about this one. Globally adding it to all the cameras with custom colors risks overwriting a used Canon color. Adding it to only some cameras means adding another palette definition so might want to hold off until some of the cleanup is done.
Seems like there are two choice to implement this:
  • Blindly add COLOR_TRANS_GREY to the custom color array and wait for anybody with one of the 47 custom palette enabled cameras to notice any whacky Canon colors.  Not a big risk - no crashes, just funny colors.  We fix anything found by either moving the patched array or changing it to #define COLOR_TRANS_GREY COLOR_GREY_LT (which the other 60+ cameras will be using anyway).
  • Add the extra custom color only to cameras that can be tested. The rest just get  #define COLOR_TRANS_GREY COLOR_GREY_LT 

Once this is implemented,   OSD text can use a semi-transparent background in both playback & shooting modes.  And script can safely use the tranparent background too.  MIght be nice to use it for the console background too.
Logged
Ported :   A1200    SD940   G10    Powershot N    G16
*

Offline koshy

  • *****
  • 1096
Re: Custom Colors : standardizing a semi-transparent grey
« Reply #22 on: 22 / October / 2014, 19:52:32 »
Quote from: waterwingz on 22 / October / 2014, 09:34:13
In palette 16 ( three of my ports ) the cursor is blue & yellow.  That;'s what was used for all the menu screen shots in the User Manual
I like it. The gray looks neutral and Blue / Yellow in that form is kind of a proven concept. Made me think of Pascal et al. back on my first own computer (DOS PC early 90s).
Logged
Koshy had a little ELPH which wasn't white as snow but everywhere that Koshy went the ELPH was sure to go. (actually an SD, but that detail ruins the rhyme...)
*

Offline koshy

  • *****
  • 1096
Re: Custom Colors : standardizing a semi-transparent grey
« Reply #23 on: 22 / October / 2014, 20:00:48 »
Quote from: waterwingz on 22 / October / 2014, 19:44:01
2 Add the extra custom color only to cameras that can be tested. The rest just get  #define COLOR_TRANS_GREY COLOR_GREY_LT
I'd go with route 2. I can test it on 80 models over some time (pretty busy right now).
That is the 68 that hit the market prior to 2010 (that is all CHDK supports except those that can shoot native RAW - being G9, G10, SX1, G11, S90) and 22 newer models.
Logged
Koshy had a little ELPH which wasn't white as snow but everywhere that Koshy went the ELPH was sure to go. (actually an SD, but that detail ruins the rhyme...)
*

Offline fabri22

  • ***
  • 208
Re: Custom Colors : standardizing a semi-transparent grey
« Reply #24 on: 23 / October / 2014, 09:57:40 »
Quote from: koshy on 22 / October / 2014, 19:52:32
I like it. The gray looks neutral and Blue / Yellow in that form is kind of a proven concept. Made me think of Pascal et al. back on my first own computer (DOS PC early 90s).
So, i will loose forever my "nearly canon stile" CHDK menu?  :(     ..."ubi maior minor cessat"...

« Last Edit: 24 / October / 2014, 09:29:39 by fabri22 »
Logged
*

Offline waterwingz

  • ******
  • 12140
    • Waterwingz
Re: Custom Colors : standardizing a semi-transparent grey
« Reply #25 on: 23 / October / 2014, 10:59:59 »


Quote from: fabri22 on 23 / October / 2014, 09:57:40
So, i will loose forever my "nearly canon stile" CHDK menu?  :(     ..."ubi maior minor cessat"...
This decision only affects the default colors used. You are still free to change most of the colors actually used via the color menu in CHDK Settings menu.

Logged
Ported :   A1200    SD940   G10    Powershot N    G16
*

Offline philmoz

  • *****
  • 3450
    • Photos
Re: Custom Colors : standardizing a semi-transparent grey
« Reply #26 on: 24 / October / 2014, 16:47:28 »
Quote from: waterwingz on 22 / October / 2014, 09:19:17
Can we move every camera that uses custom palettes into a common palette definintion / number ?

I've simplified things for cameras with custom colors (next update to SVN) - except for the A3300IS (palette 15).

If defines red as a Canon color instead of the custom color.

The comments states this is because the splash screen displays in white.
This was a problem with the custom colors early on; but I thought I fixed it.

Can someone with an A3300IS try changing CAM_BITMAP_PALETTE to 13 in platform_camera.h and test if the startup splash screen still shows correctly.

Phil.
Logged
CHDK ports:
  sx30is (1.00c, 1.00h, 1.00l, 1.00n & 1.00p)
  g12 (1.00c, 1.00e, 1.00f & 1.00g)
  sx130is (1.01d & 1.01f)
  ixus310hs (1.00a & 1.01a)
  sx40hs (1.00d, 1.00g & 1.00i)
  g1x (1.00e, 1.00f & 1.00g)
  g5x (1.00c, 1.01a, 1.01b)
  g7x2 (1.01a, 1.01b, 1.10b)
*

Offline waterwingz

  • ******
  • 12140
    • Waterwingz
Re: Custom Colors : standardizing a semi-transparent grey
« Reply #27 on: 24 / October / 2014, 18:02:00 »


Quote from: philmoz on 24 / October / 2014, 16:47:28
The comments states this is because the splash screen displays in white.  This was a problem with the custom colors early on; but I thought I fixed it.
My A1200's still do that. I thought we decided to just live with it?

Logged
Ported :   A1200    SD940   G10    Powershot N    G16
*

Offline philmoz

  • *****
  • 3450
    • Photos
Re: Custom Colors : standardizing a semi-transparent grey
« Reply #28 on: 24 / October / 2014, 18:29:42 »
Quote from: waterwingz on 24 / October / 2014, 18:02:00
Quote from: philmoz on 24 / October / 2014, 16:47:28
The comments states this is because the splash screen displays in white.  This was a problem with the custom colors early on; but I thought I fixed it.
My A1200's still do that. I thought we decided to just live with it?

You're probably right.
Looks like a timing thing, my G12 is fine; but the G1X briefly shows a white splash screen, then switches to correct colors.

I think I'll remove the special case for the A3300 and make it the same as the other cameras that implement custom colors.

Phil.
Logged
CHDK ports:
  sx30is (1.00c, 1.00h, 1.00l, 1.00n & 1.00p)
  g12 (1.00c, 1.00e, 1.00f & 1.00g)
  sx130is (1.01d & 1.01f)
  ixus310hs (1.00a & 1.01a)
  sx40hs (1.00d, 1.00g & 1.00i)
  g1x (1.00e, 1.00f & 1.00g)
  g5x (1.00c, 1.01a, 1.01b)
  g7x2 (1.01a, 1.01b, 1.10b)
*

Offline philmoz

  • *****
  • 3450
    • Photos
Re: Custom Colors : standardizing a semi-transparent grey
« Reply #29 on: 24 / October / 2014, 18:31:51 »
I think I'm finished butchering cleaning the palette.h file - hopefully haven't introduced too many mistakes or unexpected changes :)

Time to look at the transparent grey.

Phil.
Logged
CHDK ports:
  sx30is (1.00c, 1.00h, 1.00l, 1.00n & 1.00p)
  g12 (1.00c, 1.00e, 1.00f & 1.00g)
  sx130is (1.01d & 1.01f)
  ixus310hs (1.00a & 1.01a)
  sx40hs (1.00d, 1.00g & 1.00i)
  g1x (1.00e, 1.00f & 1.00g)
  g5x (1.00c, 1.01a, 1.01b)
  g7x2 (1.01a, 1.01b, 1.10b)
Pages: 1 2 [3] 4 5 6 7 8 ... 11   Go Up
« previous next »
 

Related Topics


SimplePortal © 2008-2014, SimplePortal