IXUS145/ELPH135 Porting attempt - page 11 - DryOS Development - CHDK Forum supplierdeeply

IXUS145/ELPH135 Porting attempt

  • 126 Replies
  • 52461 Views
*

Offline blackhole

  • *****
  • 765
  • A590IS 101b
    • Planetary astrophotography
Re: IXUS145/ELPH135 Porting attempt
« Reply #100 on: 04 / January / 2017, 03:53:37 »
Advertisements
I found using poke(0xa0e0,1), that 0xa0e0 is the nrflag address for darkframe control. Unfortunately, the hook below, only seems to be effective on the second shot at suppressing darkframe.  I think this happens in other ports as well. Not sure if this could be fixed by moving the hook earlier or not.
It probably could be fixed by moving the hook "upwards" - before the nrflag variable you found is read by the firmware.
Next possibility is to just find the fw variable (memory location) that is derived from that nrflag.
Other option is to introduce a custom hook that you can call when shooting starts (when expo overrides are applied). You can copy the nr related code from platform/generic/capt_seq.c .

I did none of the above in my ports with this problem, yet.


I had the same problem on the SX410.
Quote
Try moving the nr hook upwards, right after the "MOV     R4, R0 \n" instruction in the same function.
This solution works seamlessly.
Thanks!

*

Offline srsa_4c

  • ******
  • 4230
Re: IXUS145/ELPH135 Porting attempt
« Reply #101 on: 04 / January / 2017, 11:27:32 »
This solution works seamlessly.
Thanks for keeping an eye on this.
Since a modified sub_FF9B4AF8_my() (sx410 100c) is no longer needed, can you re-do the patch like I did in changeset 4748?

@62ndidiot
Same kind of change should also work on the ixus145. Can you verify it? I can do the code_gen part if needed.

*

Offline blackhole

  • *****
  • 765
  • A590IS 101b
    • Planetary astrophotography
Re: IXUS145/ELPH135 Porting attempt
« Reply #102 on: 04 / January / 2017, 14:31:17 »
This solution works seamlessly.
Thanks for keeping an eye on this.
Since a modified sub_FF9B4AF8_my() (sx410 100c) is no longer needed, can you re-do the patch like I did in changeset 4748?

@62ndidiot
Same kind of change should also work on the ixus145. Can you verify it? I can do the code_gen part if needed.
No problem.
Patch is replaced.

Re: IXUS145/ELPH135 Porting attempt
« Reply #103 on: 05 / January / 2017, 12:15:19 »
I'll verify that your suggestion works and post a diff unless @nafraf would like to take care of this along with whatever else may be cooking for this port ;)


Re: IXUS145/ELPH135 Porting attempt
« Reply #104 on: 05 / January / 2017, 16:14:22 »
Quote
@62ndidiot
Same kind of change should also work on the ixus145. Can you verify it? I can do the code_gen part if needed.
Yes it works as expected.
See the attached patch, which corrects the address of nrflag to 0xa0dc +4 and moves the -nr hook to the suggested location.

*

Offline nafraf

  • *****
  • 1308
Re: IXUS145/ELPH135 Porting attempt
« Reply #105 on: 05 / January / 2017, 20:03:28 »
@62ndidiot thanks.
Please test this patch, it is based on commit 4749 for sx410.

*

Offline srsa_4c

  • ******
  • 4230
Re: IXUS145/ELPH135 Porting attempt
« Reply #106 on: 05 / January / 2017, 20:31:28 »
Please test this patch, it is based on commit 4749 for sx410.
Looks good to me, please check it in if it tested OK.

Re: IXUS145/ELPH135 Porting attempt
« Reply #107 on: 05 / January / 2017, 20:31:43 »
Will test!
« Last Edit: 05 / January / 2017, 21:37:05 by 62ndidiot »


Re: IXUS145/ELPH135 Porting attempt
« Reply #108 on: 05 / January / 2017, 22:00:32 »
Quote
@62ndidiot thanks.
Please test this patch, it is based on commit 4749 for sx410.
Patched and tested! Works fine.

*

Offline nafraf

  • *****
  • 1308
Re: IXUS145/ELPH135 Porting attempt
« Reply #109 on: 06 / January / 2017, 19:18:07 »
Patch committed.
I think this port can be included in autobuild.
Is there any other bug to fix?

 

Related Topics