CHDK 1.4 release + bug reports - page 6 - CHDK Releases - CHDK Forum

CHDK 1.4 release + bug reports

  • 57 Replies
  • 17924 Views
*

Offline srsa_4c

  • ******
  • 4239
Re: CHDK 1.4 release + bug reports
« Reply #50 on: 14 / May / 2020, 11:32:58 »
Advertisements
Using pure #5163
Code: [Select]
--[[
@title file browser test
@chdk_version 1.3
]]

f = file_browser("A/CHDK/SCRIPTS")

print(f)
returns the expected nil, the later breaks script if folder chosen with "menu"

Edit2: Suspicious zone:  :blink: fselect.flt[5205] repairs #5229.
That is indeed a regression, introduced in r5227. The script doesn't break, it hangs as it doesn't get notified that the file browser got closed.
Following fixes the behaviour, but I'm not sure if that's the proper fix.
Code: [Select]
Index: modules/gui_fselect.c
===================================================================
--- modules/gui_fselect.c (revision 5491)
+++ modules/gui_fselect.c (working copy)
@@ -1460,7 +1460,7 @@
 
     gui_set_mode(gui_fselect_mode_old);
 
-    if (fselect_on_select && file)
+    if (fselect_on_select /*&& file*/)
     {
         fselect_on_select(file);
         // if called mode will return control to filemanager - we need to redraw it

*

Offline Caefix

  • ***
  • 230
  • Sorry, busy deleting test shots...
Re: CHDK 1.4 release + bug reports
« Reply #51 on: 14 / May / 2020, 15:14:39 »
Nice! :xmas
All lifetime is a loan from eternity.

*

Offline Caefix

  • ***
  • 230
  • Sorry, busy deleting test shots...
Re: CHDK 1.4 release + bug reports
« Reply #52 on: 15 / May / 2020, 15:27:54 »
 :o Another file_browser issue is with short file names or surprising upcasing like here:
The zip contains a tree for cam to look closer...
All lifetime is a loan from eternity.

*

Offline reyalp

  • ******
  • 12638
Re: CHDK 1.4 release + bug reports
« Reply #53 on: 15 / May / 2020, 17:58:15 »
Following fixes the behaviour, but I'm not sure if that's the proper fix.
Thanks for looking into this, and thanks Caefix for reporting.

Digging through the code a bit, I believe the fix is correct, so I checked it in. All the other callbacks used with libfselect->file_select are set up to accept NULL.

Note this bug did not apply to 1.4, because the 5227 commit was never merged. I merged both.
Don't forget what the H stands for.


*

Offline reyalp

  • ******
  • 12638
Re: CHDK 1.4 release + bug reports
« Reply #54 on: 15 / May / 2020, 17:59:31 »
:o Another file_browser issue is with short file names or surprising upcasing like here:
The zip contains a tree for cam to look closer...
Can you explain more specifically what the bug is here?
Don't forget what the H stands for.

*

Offline Caefix

  • ***
  • 230
  • Sorry, busy deleting test shots...
Re: CHDK 1.4 release + bug reports
« Reply #55 on: 16 / May / 2020, 09:38:03 »
S90 & Ix200,300 mix sfn & lfn.
Same scenario @Ix265 looks significantly better  8)
&& ;) CamĀ“s Editor can do more now...
https://chdk.setepontos.com/index.php?topic=14037.msg143417#msg143417
Edit: With 'alternative lfn support' set in 'misc' it displays always sfn.
« Last Edit: 16 / May / 2020, 11:48:05 by Caefix »
All lifetime is a loan from eternity.

*

Offline srsa_4c

  • ******
  • 4239
Re: CHDK 1.4 release + bug reports
« Reply #56 on: 16 / May / 2020, 11:54:49 »
S90 & Ix200,300 mix sfn & lfn.
Same scenario @Ix265 looks significantly better  8)

Edit: With 'alternative lfn support' set in 'misc' it displays always sfn.
Works as intended. Some (older) models have a very restricted file path length (lowest is about 32 characters). If a file's name would exceed the path limit, it will be presented in its short form.

*

Offline Caefix

  • ***
  • 230
  • Sorry, busy deleting test shots...
Re: CHDK 1.4 release + bug reports
« Reply #57 on: 16 / May / 2020, 12:25:46 »
 
Some (older) models have a very restricted file path length (lowest is about 32 characters). If a file's name would exceed the path limit, it will be presented in its short form.
:(
Edit: Btw. After moving clouds from A/Z/Clouds/ to A/Z/ less names are affected.
« Last Edit: 16 / May / 2020, 14:45:05 by Caefix »
All lifetime is a loan from eternity.


 

Related Topics