CHDK 1.4 release + bug reports

  • 45 Replies
  • 12074 Views
*

Offline ursamajor

  • **
  • 61
  • SX150IS, SX510HS
    • Per aspera ad astra...
Re: CHDK 1.4 release + bug reports
« Reply #40 on: 24 / January / 2017, 12:29:18 »
Advertisements
Aaa, sorry then, and thanks!
SX150IS (retired) :D, SX510HS

*

Offline srsa_4c

  • ******
  • 3727
Re: CHDK 1.4 release + bug reports
« Reply #41 on: 21 / April / 2018, 15:12:50 »
I wasn't sure where to post this, so I'm posting it here as it probably qualifies as a bug.

There is an issue affecting cameras that can record video in non-video modes.
When recording multiple videos without switching the camera off, the CHDK bitrate / remaining time display gets more and more incorrect with each recording.

I believe the logic inside gui_osd_draw_movie_time_left() (core/gui_osd.c) fails for recordings made in modes other than video.

The following patch seems to help, although I'm not sure it's optimal and without side effects.

Code: [Select]
Index: core/gui_osd.c
===================================================================
--- core/gui_osd.c (revision 5010)
+++ core/gui_osd.c (working copy)
@@ -618,6 +618,14 @@
             }
         }
     }
+#ifdef CAM_HAS_VIDEO_BUTTON
+    else {
+        // seems to be needed for cameras that can record video in non-video modes (dedicated movie button)
+        // without this workaround, bitrate / remaining time calculation will be incorrect for subsequent recordings
+        // todo: can this cause any side effects?
+        init = 0;
+    }
+#endif
 }
 
 void gui_osd_draw_ev(int is_osd_edit)

I first noticed this while working on the D6 movie support code, but managed to reproduce it on my Ixus115.
Can somebody with a dedicated movie button camera confirm the issue?

*

Offline blackhole

  • *****
  • 642
  • A590IS 101b
    • Planetary astrophotography
Re: CHDK 1.4 release + bug reports
« Reply #42 on: 22 / April / 2018, 10:39:28 »
I wasn't sure where to post this, so I'm posting it here as it probably qualifies as a bug.

There is an issue affecting cameras that can record video in non-video modes.
When recording multiple videos without switching the camera off, the CHDK bitrate / remaining time display gets more and more incorrect with each recording.

I believe the logic inside gui_osd_draw_movie_time_left() (core/gui_osd.c) fails for recordings made in modes other than video.

The following patch seems to help, although I'm not sure it's optimal and without side effects.

Code: [Select]
Index: core/gui_osd.c
===================================================================
--- core/gui_osd.c (revision 5010)
+++ core/gui_osd.c (working copy)
@@ -618,6 +618,14 @@
             }
         }
     }
+#ifdef CAM_HAS_VIDEO_BUTTON
+    else {
+        // seems to be needed for cameras that can record video in non-video modes (dedicated movie button)
+        // without this workaround, bitrate / remaining time calculation will be incorrect for subsequent recordings
+        // todo: can this cause any side effects?
+        init = 0;
+    }
+#endif
 }
 
 void gui_osd_draw_ev(int is_osd_edit)

I first noticed this while working on the D6 movie support code, but managed to reproduce it on my Ixus115.
Can somebody with a dedicated movie button camera confirm the issue?
I see something similar to a sx410 camera.
The remaining time after a dozen recorded clips starts to grow instead to falling.
Much stranger things happen if I delete the last recorded clip.
After deleting of the last recorded video,for the remaining time and data rate are displayed completely wrong data.
Regardless of the incorrect displayed data rate (KB/s), the size of the recorded file corresponds to the settings for the desired bitrate.
With the restart of the camera everything returns to normal.

*

Offline reyalp

  • ******
  • 11583
Re: CHDK 1.4 release + bug reports
« Reply #43 on: 23 / April / 2018, 02:06:22 »
I wasn't sure where to post this, so I'm posting it here as it probably qualifies as a bug.

There is an issue affecting cameras that can record video in non-video modes.
When recording multiple videos without switching the camera off, the CHDK bitrate / remaining time display gets more and more incorrect with each recording.

Can somebody with a dedicated movie button camera confirm the issue?
Good find. I confirmed this on elph130, and the patch seems to resolve it.

I don't see any obvious problems, but the but moving the record_running logic before the main if might make it easier to follow, as in the attached.
Don't forget what the H stands for.


*

Offline srsa_4c

  • ******
  • 3727
Re: CHDK 1.4 release + bug reports
« Reply #44 on: 24 / April / 2018, 14:15:25 »
Thanks for both of you. Meanwhile, I could confirm the existence of this issue on an old S3 IS too.
@reyalp
I'm OK with your patch, please check it in (both trunk and 1.4, I guess).

*

Offline reyalp

  • ******
  • 11583
Re: CHDK 1.4 release + bug reports
« Reply #45 on: 25 / April / 2018, 00:25:40 »
Thanks for both of you. Meanwhile, I could confirm the existence of this issue on an old S3 IS too.
@reyalp
I'm OK with your patch, please check it in (both trunk and 1.4, I guess).
Checked in, trunk r5011, 1.4 r5012
Don't forget what the H stands for.

 

Related Topics