#ifdef CAM_CHDK_HAS_EXT_VIDEO_TIME/*485*/ "Video without time limit"#endif "\0"#ifdef CAM_CHDK_HAS_EXT_VIDEO_TIME/*486*/ "Sensor may overheat during long recordings!"#endif "\0"
The lang_str.h output for conditional strings could simplified a bit:
Small update to the language string exclusion patch:- added more conditions to entries in lang_str_conditions.h- updated Makefile rules to rebuild output files when lang_str_conditions.h is changed- added support for negative logic in conditions (generates #ifndef... in lang_str.h)- simplified output for lang_str.h
I think CAM_REMOTE_USES_PRECISION_SYNC will need to be inverted (noticed on the a3200).
String # 279 does not appear to be used anywhere - we could set the conditional string to something like "___NOT_USED___" to exclude it from all builds.
Quote from: philmoz on 23 / March / 2016, 22:44:41String # 279 does not appear to be used anywhere - we could set the conditional string to something like "___NOT_USED___" to exclude it from all builds.Also a good idea. Since lang_str_conditions.h is a bit obscure, we could add a comment to core/gui_lang.h, so that the person modifying language strings gets a reminder. Alternatively, we could break compilation if lstrc_list[] is not (GUI_LANG_ITEMS+1) long...?
Quote from: srsa_4c on 24 / March / 2016, 21:20:53Quote from: philmoz on 23 / March / 2016, 22:44:41String # 279 does not appear to be used anywhere - we could set the conditional string to something like "___NOT_USED___" to exclude it from all builds.Also a good idea. Since lang_str_conditions.h is a bit obscure, we could add a comment to core/gui_lang.h, so that the person modifying language strings gets a reminder. Alternatively, we could break compilation if lstrc_list[] is not (GUI_LANG_ITEMS+1) long...?Fixed CAM_REMOTE_USES_PRECISION_SYNC, added ___NOT_USED___ and made makelang emit yet another check at the bottom of lang_str.h .Is it now OK to commit this?
QuoteIs it now OK to commit this?Looks good to me.
Is it now OK to commit this?
Started by reyalp « 1 2 3 4 5 » General Discussion and Assistance
Started by reyalp « 1 2 ... 19 20 » General Discussion and Assistance
Started by otosclerosi « 1 2 » LUA Scripting
Started by reyalp « 1 2 ... 6 7 » General Discussion and Assistance
Started by reyalp « 1 2 » General Discussion and Assistance
