This almost works:Code: (modules/user_menu_edit.c) [Select]// Call a function to process a menu item (may be a sub-menu loaded via a module)static void select_proc(){ CMenu* submenu; if (curr_menu->menu[gui_menu_curr_item].value) { ((void(*)(CMenu** arg))(curr_menu->menu[gui_menu_curr_item].value))(&submenu); gui_activate_sub_menu(submenu); }}Code: (core/gui.c) [Select]static void gui_submenu_proc(CMenu* submenu, int arg){ if (!arg) gui_activate_sub_menu(submenu); else *((CMenu**)arg) = submenu;}static void gui_misc_submenu(int arg){ if (misc_submenu.menu == 0) init_misc_submenu(); gui_submenu_proc(&misc_submenu, arg);}The editor can now enter the Miscellaneous menu, but fails to save it as an item. Any ideas?P. S. Since the root menu is also populated dynamically, the user menu is now always empty.
// Call a function to process a menu item (may be a sub-menu loaded via a module)static void select_proc(){ CMenu* submenu; if (curr_menu->menu[gui_menu_curr_item].value) { ((void(*)(CMenu** arg))(curr_menu->menu[gui_menu_curr_item].value))(&submenu); gui_activate_sub_menu(submenu); }}
static void gui_submenu_proc(CMenu* submenu, int arg){ if (!arg) gui_activate_sub_menu(submenu); else *((CMenu**)arg) = submenu;}static void gui_misc_submenu(int arg){ if (misc_submenu.menu == 0) init_misc_submenu(); gui_submenu_proc(&misc_submenu, arg);}
I'm not clear what you are trying to do.The current system works, the user menu can include any item from the Miscellaneous menu and can include modules.
Modules can have their own sub-menus (see the eyefi module) which show in the CHDK menu; but can't be added to the user menu (doing this is a hard problem to solve).
The user menu already provides a dynamic menu system, why does the whole CHDK menu need to be customisable?
What exactly are you trying to fix? What menus do you think need to be moved into modules?
Even if you do this, the modules are still not self-contained. A much more difficult issue to solve is the module language strings being contained in the common language files.
Quote from: philmoz on 17 / June / 2017, 21:02:26I'm not clear what you are trying to do.The current system works, the user menu can include any item from the Miscellaneous menu and can include modules.I believe the separate addition of modules is a hack. A proper solution would allow transparently adding items from Games and Tools submenus.QuoteModules can have their own sub-menus (see the eyefi module) which show in the CHDK menu; but can't be added to the user menu (doing this is a hard problem to solve).I don't understand what's so hard about it. My latest patch should have solved that, but I probably missed something trivial.
QuoteThe user menu already provides a dynamic menu system, why does the whole CHDK menu need to be customisable?I'm not trying to make the menus customizable, only to hide the unused items.QuoteWhat exactly are you trying to fix? What menus do you think need to be moved into modules?Once again, the intention is to make CHDK easier to use. IMO the user menu doesn't solve the clutter issue.
QuoteEven if you do this, the modules are still not self-contained. A much more difficult issue to solve is the module language strings being contained in the common language files.I only recently came across an old topic with a patch that was meant to solve that. The discussion there ended rather abruptly. I'll see if I can find it.P.S Here it is.
But by your own admission your patch doesn't work and also breaks the user menu?
You started the discussion wanting to move module specific menus into the modules - is this no longer the case?If you are still trying to do this, then again I ask, which menus do you think need moving (and why)?
If you want to try and finish this feel free; but I can assure you it is not going to be easy.
The intention was (and still is) to remove items specific to a module if it isn't there. From a quick look at the main menu the following could be cleaned up:RAW - _raw_op.fltEdge overlay - edgeovr.fltHistogram - histo.fltZebra - zebra.fltScript - ubasic.flt and lua.flt (this is a tricky one)
As I've said a couple times before, I see no reason to support installations without these modules. I appreciate that you've spent a lot of time going through the CHDK code and would like to contribute. I'm sorry to be negative about this, but it just doesn't feel like a good idea.
Making the user menu simpler, more intuitive or more flexible is certainly a worthwhile goal.
If you want to improve the CHDK UI, I'd encourage you to start by identifying what the problems are from a users POV, then proposing solutions, and then proposing implementation.
I understand. However, the objections I've heard so far were:that's not what we're used to, andthat would make the User's Guide obsoleteForgive me if I stand unconvinced.
I'm a novice CHDK user, and I find the menu clutter utterly annoying.
I then proposed removing unused items as a solution, and making the menus modular as an optional implementation.
My biggest objection is that I'm not convinced it solves any real problem, so it doesn't feel like a good use of my time. Ensuring this change causes no harm seems likely to take a lot of my time.My next objection is that it is likely to create problems, because now every part of the code has to gracefully handle the case where certain "standard" modules are missing.Finally, as a person who answers a large fraction of the end user questions on the forum, #2 isn't a trivial issue for me.
What is or isn't a module in CHDK is arbitrary, and the impacts of having a particular module present or not is not all obvious to users, so using the presence of modules as a way to customize the menu at install time does not seem like a good solution.
Can you modify the sequence to allow user's to only accept the license agreements they need / want? So if someone doesn't accept an SDM or ML license, the installation sequence disables the ability to load those but still allows CHDK (assuming the necessary licenses for CHDK are selected).
Started by reyalp General Discussion and Assistance
Started by tsvstar « 1 2 3 4 » General Discussion and Assistance
Started by msl General Discussion and Assistance
Started by waterwingz « 1 2 ... 5 6 » General Chat
Started by philmoz « 1 2 3 » General Discussion and Assistance
