I found no UI issues with the newest revision.
However, my opinion is that giving a hint about the current player can sometimes be useful (first time users, for example). The original version does this, but not the most straightforward way (the user's name is displayed rather than its color).
The attached screenshot was made with the below mod included (I added an arrowhead symbol in front of the current player's score).
Index: gui_reversi.c
===================================================================
--- gui_reversi.c (revision 5)
+++ gui_reversi.c (working copy)
@@ -306,7 +306,22 @@
//-------------------------------------------------------------------
static void redraw() {
uint x, y, mid;
+ char *plm1, *plm2;
+ if (InGame) {
+ if (CurrPlayer==FIELD_PLAYER1) {
+ plm1 = "\x10";
+ plm2 = " ";
+ }
+ else {
+ plm1 = " ";
+ plm2 = "\x10";
+ }
+ }
+ else {
+ plm1 = plm2 = " ";
+ }
+
draw_rectangle(field_x+cell_size*xPos, field_y+cell_size*yPos, field_x+cell_size*(xPos+1),
field_y+cell_size*(yPos+1), MAKE_COLOR(COLOR_RED,COLOR_RED), RECT_BORDER1);
x = camera_screen.disp_left+field_size, y = 40;
@@ -315,10 +330,12 @@
draw_string(x, y-10, "REVERSI", MAKE_COLOR(COLOR_BLUE, COLOR_WHITE));
sprintf(buf, " %d ", NumPl1);
draw_string(x+FONT_WIDTH*(7-strlen(buf))/2, y+FONT_HEIGHT*2, buf, MAKE_COLOR(COLOR_BLUE, COLOR_WHITE));
+ draw_string(x, y+FONT_HEIGHT*2, plm1, MAKE_COLOR(COLOR_BLUE, COLOR_WHITE));
draw_ellipse(x+FONT_WIDTH*1.5+(cell_size>>1), y+FONT_HEIGHT*3+(cell_size>>1),
(cell_size>>1)-4, (cell_size>>1)-4, COLOR_WHITE, DRAW_FILLED);
sprintf(buf, " %d ", NumPl2);
draw_string(x+FONT_WIDTH*(7-strlen(buf))/2, y+FONT_HEIGHT*6, buf, MAKE_COLOR(COLOR_BLUE, COLOR_WHITE));
+ draw_string(x, y+FONT_HEIGHT*6, plm2, MAKE_COLOR(COLOR_BLUE, COLOR_WHITE));
draw_ellipse(x+FONT_WIDTH*1.5+(cell_size>>1), y+FONT_HEIGHT*7+(cell_size>>1),
(cell_size>>1)-4, (cell_size>>1)-4, COLOR_BLACK, DRAW_FILLED);
}
Should this go in or the indicator-less version? Or, any better suggestions for the indicator?
