camera_list.csv (was Re: G7X II - need help finding led details.) - page 2 - General Discussion and Assistance

srsa_4c

4451

Re: camera_list.csv (was Re: G7X II - need help finding led details.)

« Reply #10 on: 29 / August / 2019, 16:56:01 »

Advertisements

Quote from: dmitrys on 29 / August / 2019, 16:48:26

IMHO adding a LED test to trunk wasn't such a great idea.

I guess Phil added the port so that there's something that utilizes the DIGIC 7 specific parts of the source. Since it's not in the csv, you should just ignore it.
BTW, you keep insulting main contributors of this project. I don't know if you do that intentionally or not, but you may want to change your attitude.

Logged

dmitrys

267

Re: camera_list.csv (was Re: G7X II - need help finding led details.)

« Reply #11 on: 29 / August / 2019, 17:16:31 »

@srsa_4c, I'm sorry but I don't see why any of my remarks are more offensive than this one:

Quote from: srsa_4c

Sounds like you need to fix your tool then.

In any case, I wasn't trying to insult anybody, just trying to help. Keep up the great work!

Logged

Author of CHIMP, Canon Hack Installation and Management Platform

reyalp

14118

Re: camera_list.csv (was Re: G7X II - need help finding led details.)

« Reply #12 on: 29 / August / 2019, 17:50:30 »

Quote from: dmitrys on 29 / August / 2019, 16:48:26

The tool was specifically designed to fail in such a case, so there's nothing to *fix* there.

camera_list.csv exists to support the batch build processes. By definition, every port that can appear in a standard batch build will be listed. Some additional ports may be listed with SKIP_AUTOBUILD. These ports must be complete enough to run the standard -noskip operations like stubs rebuild.

You are free to use camera_list.csv for other purposes, but you should not assume it meets any criteria beyond what the build process requires.

There is no requirement that every sub-directory of platform have a matching camera_list entry.

Quote

although IMHO adding a LED test to trunk wasn't such a great idea.

I disagree. Having the initial digic 7 work preserved and publicly accessible is desirable, and this is the correct place to put it.

Logged

Don't forget what the H stands for.

srsa_4c

4451

Re: camera_list.csv (was Re: G7X II - need help finding led details.)

« Reply #13 on: 29 / August / 2019, 17:57:30 »

Quote from: dmitrys on 29 / August / 2019, 17:16:31

I'm sorry but I don't see why any of my remarks are more offensive than this one

Let's just say, you're (very likely) a professional coder, who is expected to be able to deal with the things you're complaining about. My answer reflects that.

Logged

dmitrys

267

Re: camera_list.csv (was Re: G7X II - need help finding led details.)

« Reply #14 on: 31 / August / 2019, 08:10:06 »

Quote from: reyalp on 29 / August / 2019, 17:50:30

camera_list.csv exists to support the batch build processes. By definition, every port that can appear in a standard batch build will be listed. Some additional ports may be listed with SKIP_AUTOBUILD. These ports must be complete enough to run the standard -noskip operations like stubs rebuild.

Thank you very much for the detailed explanation.

I really appreciate the time and effort you put into explaining things that seem obvious to some but less so to others (like yours truly).

Now, I take it that g7x2 does run -noskip, so is there any reason for not adding it to camera_list?

Logged

Author of CHIMP, Canon Hack Installation and Management Platform

reyalp

14118

Re: camera_list.csv (was Re: G7X II - need help finding led details.)

« Reply #15 on: 31 / August / 2019, 14:22:19 »

Quote from: dmitrys on 31 / August / 2019, 08:10:06

Now, I take it that g7x2 does run -noskip, so is there any reason for not adding it to camera_list?

philmoz added the g7x2 code, so I'll leave it up to him to comment on whether he intentionally excluded it.

Logged

Don't forget what the H stands for.

philmoz

3450

Re: camera_list.csv (was Re: G7X II - need help finding led details.)

« Reply #16 on: 31 / August / 2019, 19:49:41 »

Quote from: dmitrys on 31 / August / 2019, 08:10:06

Now, I take it that g7x2 does run -noskip, so is there any reason for not adding it to camera_list?

It's not a working port, it's an experiment with DIGIC 7 that has so far failed to do anything but blink an LED and lock up the camera.

If you'd taken the time to read the thread you might understand this.

Having tools that prepare SD cards show this as a port sends the wrong message, and since said tools should be using the camera_list.csv file, then the G7X2 does not belong there.

The code is in SVN in case someone smarter than me can figure out how to progress DIGIC 7 support.

Logged

CHDK ports:
sx30is (1.00c, 1.00h, 1.00l, 1.00n & 1.00p)
g12 (1.00c, 1.00e, 1.00f & 1.00g)
sx130is (1.01d & 1.01f)
ixus310hs (1.00a & 1.01a)
sx40hs (1.00d, 1.00g & 1.00i)
g1x (1.00e, 1.00f & 1.00g)
g5x (1.00c, 1.01a, 1.01b)
g7x2 (1.01a, 1.01b, 1.10b)