Tweak to histogram.c: A proposal - General Discussion and Assistance - CHDK Forum supplierdeeply

Tweak to histogram.c: A proposal

  • 3 Replies
  • 269 Views
Tweak to histogram.c: A proposal
« on: 31 / January / 2020, 01:44:29 »
Advertisements
The current histogram has an under and over indicator, that is nearly impossible to see: certainly for those with older eyes and/or in difficult lighting conditions.

The indicators are simply too small.

My request/proposal is that we increase the indicator size from the current 5 to 7.

As I don't compile I can't test if this is 'good enough' or not, eg do we need to go to 9?

Anyway, assuming going from 5 to 7 is better, here is my proposed change to histogram.c


Re: Tweak to histogram.c: A proposal
« Reply #1 on: 31 / January / 2020, 12:31:48 »
 :-[

Oops
X and Y !!!!!


*

Offline reyalp

  • ******
  • 12593
Re: Tweak to histogram.c: A proposal
« Reply #2 on: 03 / February / 2020, 21:41:48 »
Can you please post any proposed change as a diff, attached to the post? Screenshots are really not helpful way to do this.

Also, I moved this thread to "CHDK Development / General Discussion and Assistance". This is the preferred place for discussion of CHDK code changes.
« Last Edit: 04 / February / 2020, 00:14:17 by reyalp »
Don't forget what the H stands for.

Re: Tweak to histogram.c: A proposal
« Reply #3 on: 04 / February / 2020, 00:11:57 »
@reyalp

Sorry for only supplying the screen shot.

Here is source and the diff on my github.

https://gist.github.com/pigeonhill/128d25c00f6edecbd8b1b2c089fa650d/revisions


 

Related Topics