Save RAW files in DNG format instead of RAW - page 5 - Feature Requests - CHDK Forum supplierdeeply

Save RAW files in DNG format instead of RAW

  • 392 Replies
  • 114574 Views
*

Offline PhyrePhoX

  • *****
  • 2254
  • make RAW not WAR
    • PhyreWorX
Re: Save RAW files in DNG format instead of RAW
« Reply #40 on: 13 / November / 2008, 07:57:27 »
Advertisements
yes, that is the reason, you need the badpixel.bin

*

Offline PhyrePhoX

  • *****
  • 2254
  • make RAW not WAR
    • PhyreWorX
Re: Save RAW files in DNG format instead of RAW
« Reply #41 on: 13 / November / 2008, 08:10:47 »
i gather you also write the exif stuff - do you write the canon values or the chdk (overridden) values?
For Av and Tv - overridden values. For ISO - Canon value, but this can be corrected.

Quote
hm, no build for the s3is, damn ;)
No problem, added (also S2, S5, SX100).

Many thanks to ArtDen and cppasm from russian forum.

so i guess adding dng support for cameras that are NOT in dng4ps yet is more difficult, unless we ignore the color profile and people set it themselves in the raw editing program of their choice. this would mean you could add dng support to the svn ;)
what happens if you take a shot without the badpixel.bin?
and what could be negative side-effects of that raw buffer caching? so far i havent seen any downside, unless you call significantly faster raw saving a downside ;)
also maybe you can leave that timecounter that shows how long raw saving takes in the final svn committ, perhaps with an option in the debug menu? this way you can also benchmark your sdcards and the raw vs dng vs caching thing.

again: great work!
oh and ps: your english is fine :)

pps: can we write the jpg exif as well now?

*

Offline ewavr

  • ****
  • 1057
  • A710IS
Re: Save RAW files in DNG format instead of RAW
« Reply #42 on: 13 / November / 2008, 09:37:46 »
what happens if you take a shot without the badpixel.bin?
Try it yourself - make 4 bytes long badpixel.bin with zero bytes contents (this mean one bad pixel with 0,0 coordinates).  My result - in attached image (dcraw, 100% crop).
Quote
and what could be negative side-effects of that raw buffer caching? so far i havent seen any downside, unless you call significantly faster raw saving a downside ;)
Maybe on some cameras in some cases this cause image artifacts - more testing is required.

Quote
pps: can we write the jpg exif as well now?
At present - no. But some time ago I found 'CreateHeader' task, which writes some EXIF info in JPEGs.

edit: 25 Nov.  Dummy badpixel.bin is removed. Use REAL bad pixels list instead it.
edit2: We can increase writing speed still more (saving time ~1.7s in my cam), but JPEG will be corrupted.  :)
« Last Edit: 25 / November / 2008, 15:32:43 by ewavr »

*

Offline PhyrePhoX

  • *****
  • 2254
  • make RAW not WAR
    • PhyreWorX
Re: Save RAW files in DNG format instead of RAW
« Reply #43 on: 13 / November / 2008, 10:00:30 »
well, some people even dont want jpgs to be saved. for real - if we can have the dngs with a useful colorprofile - why use jpg. perhaps make it an option - jpg / jpg+crw / jpg+dng / just crw / just dng + cache/no cache. this would make a lotta people happy ;) *

the output of the raw without the badpixel.bin looks similar to what i had found on my camera today, even though i DID use the badpixel.bin - i could not reproduce it though.

wow, dng support and MAYBE exif writing later. two of the most wanted features :)

* edit: in case of the ixus40 100k this feature already exists: the crw is written, the jpg isnt :D

edit: i GUESS that with dng, we cannot develop the raw in-camera anymore. which is why we should leave the "old crw" option in there. right?
« Last Edit: 13 / November / 2008, 10:04:54 by PhyrePhoX »


*

Offline ewavr

  • ****
  • 1057
  • A710IS
Re: Save RAW files in DNG format instead of RAW
« Reply #44 on: 13 / November / 2008, 10:20:53 »
the output of the raw without the badpixel.bin looks similar to what i had found on my camera today, even though i DID use the badpixel.bin - i could not reproduce it though.
This depends on RAW converter - Adobe Camera RAW successfilly eliminates single bad pixels (but not bad pixels blocks). Previous screenshot is made by FastStone Image Viewer (dcraw based).

Quote
that with dng, we cannot develop the raw in-camera anymore. which is why we should leave the "old crw" option in there. right?
Yes. But DNG can be easily converted to usual CHDK CRW and vice versa. "DNG develop" is also possible.

*

Offline PhyrePhoX

  • *****
  • 2254
  • make RAW not WAR
    • PhyreWorX
Re: Save RAW files in DNG format instead of RAW
« Reply #45 on: 13 / November / 2008, 10:24:59 »
ha, that was the reason, i was using faststone image viewer AND adobe camera raw, at least i think so.
wow, dng develop and i guess dng merge/average would be possible... very cool if that was available :)

*

Offline lrossel

  • **
  • 53
  • CHDK - Take it underwater
    • My Photos
Re: Save RAW files in DNG format instead of RAW
« Reply #46 on: 13 / November / 2008, 10:33:48 »
If you saw me on land, It was just the surface interval
G10 without CHDK

*

Offline Hacki

  • ****
  • 358
  • SX100
Re: Save RAW files in DNG format instead of RAW
« Reply #47 on: 13 / November / 2008, 11:35:51 »
edit2: We can increase writing speed still more (saving time ~1.7s in my cam), but JPEG will be corrupted.  :)

How? :)


*

Offline ewavr

  • ****
  • 1057
  • A710IS
Re: Save RAW files in DNG format instead of RAW
« Reply #48 on: 13 / November / 2008, 12:35:17 »
How? :)

In raw.c:

Code: (c) [Select]
#if DNG_SUPPORT
            if (conf.dng_raw&&get_dng_header()) {
     //      revert_bytes_order(get_raw_image_addr(), hook_raw_size());
     //      unpatch_bad_pixels_b();
             free_dng_header();
            }
#endif


*

Offline vit40

  • ****
  • 276
Re: Save RAW files in DNG format instead of RAW
« Reply #49 on: 13 / November / 2008, 14:11:01 »
Ewavr, checked version for A620, but can't turn DNG format feature on (pressing set on that menu item has no effect). Am I doing something wrong ?

Just an idea, don't know how much programming efforts is needed for this - what about separating a dng header into external file, that will be located somewhere on the SD card, similar to headers in DNG4PS version 1? That way, we can customize it way we want with exiftools, dngsetmatrix and other tools(changing color matrix and other tags), because header is a tiff structure . What do you think ?

 

Related Topics