A590IS porting... - page 69 - DryOS Development - CHDK Forum

A590IS porting...

  • 968 Replies
  • 397694 Views
*

Offline reyalp

  • ******
  • 14085
Re: A590IS porting...
« Reply #680 on: 28 / October / 2009, 16:37:40 »
Advertisements
I think a bigger trim is needed for whim's A590IS0-101b, so we can go
with his because it will work with mine as well.
This cannot be correct. All cameras of given model should have the same active area, this is a hardware feature.

Quote
4 Pixels @left, 3 Pixels @Top, 6 Pixels @right
How exactly are you determining this ? What software are you using ?
Don't forget what the H stands for.

*

Offline dvip

  • ****
  • 451
Re: A590IS porting...
« Reply #681 on: 28 / October / 2009, 17:19:16 »
>All cameras of given model should
>have the same active area, this is a hardware feature.

@reyalp,
There are two borders, the outer one which is black,
and another one parallel to it which seems to be
touching the active area and it is not well defined. You can see
them both in the raw file that whim posted. When I compare his
borders with mine his are bigger, so
if we crop using his file as a guide it should also work for mine.

I'm not sure if it is hardware/software what is causing
the difference. Technically the active area + other
hardware should be the same.

>How exactly are you determining this ? What software are you
>using ?

To count pixels and see if the borders are present I use
IrfanView. It's what I got. It is possible that IrfanView is not showing
everything. I think IrfanView's raw engine is dcraw based.



*

Offline dvip

  • ****
  • 451
Re: A590IS porting...
« Reply #682 on: 28 / October / 2009, 17:28:38 »
@whim,
The two new versions booted without problems.

a590-101b-0.9.8-824(reyalp@346).zip looks better.

but still needs some cropping:

X1 = 5,  Y1 = 8,  X2 = 3283,  Y2 = 2462

It still has a black border @rigth.
The other borders have that light border which
we don't know if it is hardware/software that
causes it. I assume they are on the active area.

« Last Edit: 28 / October / 2009, 17:52:58 by dvip »

*

Offline reyalp

  • ******
  • 14085
Re: A590IS porting...
« Reply #683 on: 28 / October / 2009, 18:07:46 »
To count pixels and see if the borders are present I use
IrfanView. It's what I got. It is possible that IrfanView is not showing
everything. I think IrfanView's raw engine is dcraw based.
Wait, are you looking at DNG or CRW ?

This setting only affects DNG. CRW has NO meta data, and the data always includes the entire sensor (the DNG always includes the entire sensor data too, but it has metadata to say which part is active) Some programs (such as DCRAW and those based on it) may do active area cropping based on some values hard coded in the program itself, but there is nothing CHDK can do to affect it.

To verify that the active area settings are correct, you must check the DNG.
Don't forget what the H stands for.


*

Offline whim

  • ******
  • 2046
  • A495/590/620/630 ixus70/115/220/230/300/870 S95
Re: A590IS porting...
« Reply #684 on: 28 / October / 2009, 18:38:13 »
Quote
a590-101b-0.9.8-824(reyalp@346).zip looks better.
than ....(reyalp@440) ? that's exactly the same sourcecode:
you either have a lot of phantasy, or your cam is bewitched  :D  (or maybe the 'shadow' varies with each pic ?)
i'm happy they work now, however; any idea why, did you change anything ?

@reyalp

LOL, was just gonna up a DNG i made with your new settings -> no black visible in RawTherapee 2.4.1 :

(attention, 10 MB)  http://drop.io/chdkshellbeta/asset/test-reyalp-dng


cheers,

wim


*

Offline dvip

  • ****
  • 451
Re: A590IS porting...
« Reply #685 on: 28 / October / 2009, 18:41:21 »
@reyalp, I am using DNG. I'm not sure if whim's was a
DNG/CRW. Maybe that's why there is a border difference.

Anyhow, I saw some progress in whim's drop.io files so I think
the borders should be gone soon... Now, let's hope it works for
all A590IS cams.


*

Offline dvip

  • ****
  • 451
Re: A590IS porting...
« Reply #686 on: 28 / October / 2009, 18:43:12 »
bewitched :)

>did you change anything ?

Nope, nothing was changed.


« Last Edit: 28 / October / 2009, 18:45:00 by dvip »

*

Offline reyalp

  • ******
  • 14085
Re: A590IS porting...
« Reply #687 on: 28 / October / 2009, 18:54:02 »
« Last Edit: 28 / October / 2009, 19:11:27 by reyalp »
Don't forget what the H stands for.


*

Offline whim

  • ******
  • 2046
  • A495/590/620/630 ixus70/115/220/230/300/870 S95
Re: A590IS porting...
« Reply #688 on: 28 / October / 2009, 19:22:43 »
Quote
I see a border in irfanview and gimp via ufraw.

i see some 'shadow' on the edges, no black border though in RT - i would say here's where my RT crop option
should come into play, if i were so inclined ... which i ain't

wim

edit: i think RT says size of image is 3288 x 2464 (in the Resize box, as "Full image size" FWIW)

edit2: when i send the image from RT to GIMP ("send to editor") GIMP reports this size too - could this just be
         they're all using dcraw, but different versions ?

edit3: here's the image loaded into RT, shows reported size (bottom right) and 'shadow in detail view
         http://drop.io/chdkshellbeta/asset/rt-test-reyalp-png
« Last Edit: 28 / October / 2009, 19:53:39 by whim »

*

Offline reyalp

  • ******
  • 14085
Re: A590IS porting...
« Reply #689 on: 28 / October / 2009, 20:17:06 »
Hrm, my math from last night doesn't make sense.  3336-36=3300 not 3324 ;)

edit: or 3330 as I put in the post :)

updated build with (copy pasted directly from the header!)
Code: [Select]
#define CAM_ACTIVE_AREA_X1 12
#define CAM_ACTIVE_AREA_Y1 10
#define CAM_ACTIVE_AREA_X2 3300
#define CAM_ACTIVE_AREA_Y2 2480

Note that if you wanted to crop the slightly distorted areas around the top and left,
X1 would be 16
Y1 would be 18 or so
The bottom/left seem clean all the way to the edge
« Last Edit: 28 / October / 2009, 20:29:13 by reyalp »
Don't forget what the H stands for.

 

Related Topics