changelog of trunk including comments / devtalk

  • 275 Replies
  • 60606 Views
*

Offline philmoz

  • *****
  • 2936
    • Photos
Re: changelog of trunk including comments / devtalk
« Reply #270 on: 17 / May / 2016, 04:44:07 »
Advertisements
There's something I'd like to note (here's probably more appropriate than in the bugreport thread).

In trunk r4623..4626, the sx530 (and also sx520) port gets the default, 'weak' version (from platform/generic/wrappers.c) of the vid_get_bitmap_active_palette() function in the final main.bin file. I have not found an explanation for this. There are other ports where this particular function is located in the port's 'lower' lib.c file, but the two I tried (s80, a590) build correctly.
The biggest noticeable difference is probably the content of platform/sx530hs/sub/100c/lib.c, which was only the above mentioned function. But I don't see how that should matter.


Builds correctly for me.
64 bit Linux, arm-none-eabi-gcc 4.9.3.


Phil.

CHDK ports:
  sx30is (1.00c, 1.00h, 1.00l, 1.00n & 1.00p)
  g12 (1.00c, 1.00e, 1.00f & 1.00g)
  sx130is (1.01d & 1.01f)
  ixus310hs (1.00a & 1.01a)
  sx40hs (1.00d, 1.00g & 1.00i)
  g1x (1.00e, 1.00f & 1.00g)

*

Offline srsa_4c

  • ******
  • 3275
Re: changelog of trunk including comments / devtalk
« Reply #271 on: 17 / May / 2016, 20:10:37 »
Builds correctly for me.
64 bit Linux, arm-none-eabi-gcc 4.9.3.
Strange.
I'm still on 32 bit, both arm-none-eabi-gcc 4.9.3 and my self-compiled arm-elf 4.6.4 toolchain produce a main.bin binary with the weak function:
Code: [Select]
003004c4 <vid_get_bitmap_active_palette>:
  3004c4: e3a00000 mov r0, #0 ; 0x0
  3004c8: e12fff1e bx lr
If I remove the weak vid_get_bitmap_active_palette() from platform/generic/wrappers.c, I get correct result:
Code: [Select]
00313c10 <vid_get_bitmap_active_palette>:
  313c10: e3a03a07 mov r3, #28672 ; 0x7000
  313c14: e59302a4 ldr r0, [r3, #676]
  313c18: e12fff1e bx lr
Above happens when building the sx520 and sx530 ports using trunk revision 4626.
Issue was originally reported by blackhole who is using Windows (and very likely 32 bit toolchain).

*

Offline reyalp

  • ******
  • 10168
Re: changelog of trunk including comments / devtalk
« Reply #272 on: 18 / May / 2016, 01:06:18 »
Strange.
I'm still on 32 bit, both arm-none-eabi-gcc 4.9.3 and my self-compiled arm-elf 4.6.4 toolchain produce a main.bin binary with the weak function:
Very strange  :-[

I built sx530hs 100c using 32 bit arm-none-eabi-gcc 4.9.3 on windows 7 (64 bit, but shouldn't matter), and got the correct vid_get_bitmap_active_palette

I would like to get rid of all the weak stuff, but I think it would need some other system to fall back to the defaults rather than having them copied in every platform or a hand-maintained camera.h defines.

edit:
If you haven't already, it might be looking to see if any other weak functions are wrong, especially ones in the same files as vid_get_bitmap_active_palette
« Last Edit: 18 / May / 2016, 01:12:28 by reyalp »
Don't forget what the H stands for.

*

Offline srsa_4c

  • ******
  • 3275
Re: changelog of trunk including comments / devtalk
« Reply #273 on: 27 / May / 2016, 13:19:53 »
The stable autobuild is down. Does not seem to be related to my latest commit.
Quote
Compiling branch 'release-1_4'...

make: *** empty string invalid as file name.  Stop.
child process exited abnormally

***FATAL***: Error occured during compilation.


*

Online msl

  • *****
  • 1193
  • A720 IS, SX220 HS 1.01a
    • CHDK inside
Re: changelog of trunk including comments / devtalk
« Reply #274 on: 27 / May / 2016, 15:18:36 »
The stable autobuild is down.
Strange. CHDK-DE autobuild rev.4634 was successful. Maybe an issue on the server.

msl
German CHDK pages:  CHDK forum | CHDK inside | CHDK Twitter News by msl | Download CHDK-DE (Autobuild)
Note: SDM violates the GPL rules!

*

Offline Hacki

  • ****
  • 353
  • SX100
Re: changelog of trunk including comments / devtalk
« Reply #275 on: 27 / May / 2016, 16:35:10 »

Its working again, no idea what that was. Didnt need to fix anything, just restart the build.


Best guess is that the SVN checkout terminated early (due to some assembla f-up) and the build started on an incomplete sourcetree?


« Last Edit: 27 / May / 2016, 16:38:04 by Hacki »

 

Related Topics