changelog of trunk including comments / devtalk - page 21 - General Discussion and Assistance - CHDK Forum supplierdeeply
« previous next »
Pages: 1 ... 16 17 18 19 20 [21] 22 23 24 25 26 ... 30   Go Down

changelog of trunk including comments / devtalk

  • 299 Replies
  • 227176 Views
*

Offline srsa_4c

  • ******
  • 4451
Re: changelog of trunk including comments / devtalk
« Reply #200 on: 06 / September / 2014, 17:39:08 »
Advertisements
Quote from: waterwingz on 06 / September / 2014, 17:17:04
AFAIK, it already does provide the same functionality.  However the data is provides is mostly accessed via the get_usb_power() function
I see, I did not attempt to overview the whole remote related code, I just found one relevant occurrence of CAM_REMOTE_AtoD_CHANNEL and thought it meant partial support.

set_remote_sampling_period() or even set_remote_sample_rate() ? :)
Logged
*

Offline waterwingz

  • ******
  • 12138
    • Waterwingz
Re: changelog of trunk including comments / devtalk
« Reply #201 on: 06 / September / 2014, 17:42:32 »
Quote from: srsa_4c on 06 / September / 2014, 17:39:08
I see, I did not attempt to overview the whole remote related code, I just found one relevant occurrence of CAM_REMOTE_AtoD_CHANNEL and thought it meant partial support.
It's done that way because not every camera has a battery 3rd terminal (A series for example) so it's supposed to be enabled on a "per camera" basis as needed and after testing on that model.
Logged
Ported :   A1200    SD940   G10    Powershot N    G16
*

Offline msl

  • *****
  • 1280
  • A720 IS, SX220 HS 1.01a
    • CHDK-DE links
Re: changelog of trunk including comments / devtalk
« Reply #202 on: 06 / September / 2014, 19:04:53 »
The last discussion shows the problem. All suggestions are more from the perspective of the developers and less of the end user. In this case the recent name is a good choice.

All proposals describe more or less the background of the function and not what they affect.

set_remote_timing() seems to be a good consensus.

msl
Logged
CHDK-DE:  CHDK-DE links
*

Offline waterwingz

  • ******
  • 12138
    • Waterwingz
Re: changelog of trunk including comments / devtalk
« Reply #203 on: 06 / September / 2014, 19:50:13 »
Quote from: msl on 06 / September / 2014, 19:04:53
All proposals describe more or less the background of the function and not what they affect.
Then another choice might be  enable_accurate_remote() or set_accurate_remote_timing()

Quote
set_remote_timing() seems to be a good consensus.
I can live with that.

Can we go back and rename some other functions?  ( switch_mode_usb() ...)
Logged
Ported :   A1200    SD940   G10    Powershot N    G16
*

Offline reyalp

  • ******
  • 14079
Re: changelog of trunk including comments / devtalk
« Reply #204 on: 06 / September / 2014, 20:30:37 »
Quote from: waterwingz on 06 / September / 2014, 19:50:13
Quote
set_remote_timing() seems to be a good consensus.
I can live with that.
Likewise.

Quote
Can we go back and rename some other functions?  ( switch_mode_usb() ...)
No. Not for 1.3 at least. If we are going to break compatibility in 1.4, I'm not against a major re-organization.

IMO renaming a recently added function that has only existed in the dev branch is significantly less disruptive than renaming something that has been around forever.

FWIW, switch_mode_usb should actually be redundant now, because set_record does the right thing if USB power is present. Then again set_record was another hated name I am responsible for....
Logged
Don't forget what the H stands for.
*

Offline reyalp

  • ******
  • 14079
Re: changelog of trunk including comments / devtalk
« Reply #205 on: 07 / December / 2014, 20:47:39 »
Quote from: reyalp on 06 / September / 2014, 20:30:37
Quote from: waterwingz on 06 / September / 2014, 19:50:13
Quote
set_remote_timing() seems to be a good consensus.
I can live with that.
Likewise.
Ugh. I'd forgotten about this. I've renamed it in trunk r3776.

I left the old name there as an alias in lua to give people a chance to update scripts. I'll take it out in the next few days. I just renamed in it ubasic, because I doubt many are using it.
Logged
Don't forget what the H stands for.
*

Offline waterwingz

  • ******
  • 12138
    • Waterwingz
Re: changelog of trunk including comments / devtalk
« Reply #206 on: 07 / December / 2014, 21:13:32 »
Quote from: reyalp on 07 / December / 2014, 20:47:39
Quote from: reyalp on 06 / September / 2014, 20:30:37
Quote from: waterwingz on 06 / September / 2014, 19:50:13
Quote
set_remote_timing() seems to be a good consensus.
I can live with that.
Likewise.
Ugh. I'd forgotten about this. I've renamed it in trunk r3776.

I left the old name there as an alias in lua to give people a chance to update scripts. I'll take it out in the next few days. I just renamed in it ubasic, because I doubt many are using it.
Fine with me but I'd thought we were going to let this slide until 1.4 and include it in a general cleanup of Lua return status true/false vs 0/1 ?   (ie. take the pain in one big hit )
Logged
Ported :   A1200    SD940   G10    Powershot N    G16
*

Offline reyalp

  • ******
  • 14079
Re: changelog of trunk including comments / devtalk
« Reply #207 on: 07 / December / 2014, 21:21:40 »
Quote from: waterwingz on 07 / December / 2014, 21:13:32
Fine with me but I'd thought we were going to let this slide until 1.4 and include it in a general cleanup of Lua return status true/false vs 0/1 ?   (ie. take the pain in one big hit )
That wasn't my understanding. I thought the consensus was to use this name and leave the rest. I just didn't get around to doing it after we agreed on the name.
Logged
Don't forget what the H stands for.
*

Offline msl

  • *****
  • 1280
  • A720 IS, SX220 HS 1.01a
    • CHDK-DE links
Re: changelog of trunk including comments / devtalk
« Reply #208 on: 21 / December / 2014, 05:06:53 »
After the changeset 3821 and 3826 we had a problem with the German autobuild. The puffer for the language strings is too small.
Code: [Select]
/tools/makelang.c
line  66         char buf[200]But:
Code: [Select]
/core/gui_mbox.c
line  23         #define MAX_LINES       8
line  24         #define MAX_WIDTH      35The puffer should be 289 ((35  + CR) * 8 + EOF).

msl
Logged
CHDK-DE:  CHDK-DE links
*

Offline philmoz

  • *****
  • 3450
    • Photos
Re: changelog of trunk including comments / devtalk
« Reply #209 on: 21 / December / 2014, 05:10:42 »
Quote from: msl on 21 / December / 2014, 05:06:53
After the changeset 3821 and 3826 we had a problem with the German autobuild. The puffer for the language strings is too small.
Code: [Select]
/tools/makelang.c
line  66         char buf[200]But:
Code: [Select]
/core/gui_mbox.c
line  23         #define MAX_LINES       8
line  24         #define MAX_WIDTH      35The puffer should be 289 ((35  + CR) * 8 + EOF).

msl

Thanks, updated in revision 3835 (I set it to 500 just to be sure).

Phil.
Logged
CHDK ports:
  sx30is (1.00c, 1.00h, 1.00l, 1.00n & 1.00p)
  g12 (1.00c, 1.00e, 1.00f & 1.00g)
  sx130is (1.01d & 1.01f)
  ixus310hs (1.00a & 1.01a)
  sx40hs (1.00d, 1.00g & 1.00i)
  g1x (1.00e, 1.00f & 1.00g)
  g5x (1.00c, 1.01a, 1.01b)
  g7x2 (1.01a, 1.01b, 1.10b)
Pages: 1 ... 16 17 18 19 20 [21] 22 23 24 25 26 ... 30   Go Up
« previous next »
 

Related Topics