changelog of trunk including comments / devtalk - page 28 - General Discussion and Assistance - CHDK Forum

changelog of trunk including comments / devtalk

  • 288 Replies
  • 148817 Views
*

Online philmoz

  • *****
  • 3107
    • Photos
Re: changelog of trunk including comments / devtalk
« Reply #270 on: 17 / May / 2016, 04:44:07 »
Advertisements
There's something I'd like to note (here's probably more appropriate than in the bugreport thread).

In trunk r4623..4626, the sx530 (and also sx520) port gets the default, 'weak' version (from platform/generic/wrappers.c) of the vid_get_bitmap_active_palette() function in the final main.bin file. I have not found an explanation for this. There are other ports where this particular function is located in the port's 'lower' lib.c file, but the two I tried (s80, a590) build correctly.
The biggest noticeable difference is probably the content of platform/sx530hs/sub/100c/lib.c, which was only the above mentioned function. But I don't see how that should matter.


Builds correctly for me.
64 bit Linux, arm-none-eabi-gcc 4.9.3.


Phil.

CHDK ports:
  sx30is (1.00c, 1.00h, 1.00l, 1.00n & 1.00p)
  g12 (1.00c, 1.00e, 1.00f & 1.00g)
  sx130is (1.01d & 1.01f)
  ixus310hs (1.00a & 1.01a)
  sx40hs (1.00d, 1.00g & 1.00i)
  g1x (1.00e, 1.00f & 1.00g)

*

Offline srsa_4c

  • ******
  • 3907
Re: changelog of trunk including comments / devtalk
« Reply #271 on: 17 / May / 2016, 20:10:37 »
Builds correctly for me.
64 bit Linux, arm-none-eabi-gcc 4.9.3.
Strange.
I'm still on 32 bit, both arm-none-eabi-gcc 4.9.3 and my self-compiled arm-elf 4.6.4 toolchain produce a main.bin binary with the weak function:
Code: [Select]
003004c4 <vid_get_bitmap_active_palette>:
  3004c4: e3a00000 mov r0, #0 ; 0x0
  3004c8: e12fff1e bx lr
If I remove the weak vid_get_bitmap_active_palette() from platform/generic/wrappers.c, I get correct result:
Code: [Select]
00313c10 <vid_get_bitmap_active_palette>:
  313c10: e3a03a07 mov r3, #28672 ; 0x7000
  313c14: e59302a4 ldr r0, [r3, #676]
  313c18: e12fff1e bx lr
Above happens when building the sx520 and sx530 ports using trunk revision 4626.
Issue was originally reported by blackhole who is using Windows (and very likely 32 bit toolchain).

*

Offline reyalp

  • ******
  • 11902
Re: changelog of trunk including comments / devtalk
« Reply #272 on: 18 / May / 2016, 01:06:18 »
Strange.
I'm still on 32 bit, both arm-none-eabi-gcc 4.9.3 and my self-compiled arm-elf 4.6.4 toolchain produce a main.bin binary with the weak function:
Very strange  :-[

I built sx530hs 100c using 32 bit arm-none-eabi-gcc 4.9.3 on windows 7 (64 bit, but shouldn't matter), and got the correct vid_get_bitmap_active_palette

I would like to get rid of all the weak stuff, but I think it would need some other system to fall back to the defaults rather than having them copied in every platform or a hand-maintained camera.h defines.

edit:
If you haven't already, it might be looking to see if any other weak functions are wrong, especially ones in the same files as vid_get_bitmap_active_palette
« Last Edit: 18 / May / 2016, 01:12:28 by reyalp »
Don't forget what the H stands for.

*

Offline srsa_4c

  • ******
  • 3907
Re: changelog of trunk including comments / devtalk
« Reply #273 on: 27 / May / 2016, 13:19:53 »
The stable autobuild is down. Does not seem to be related to my latest commit.
Quote
Compiling branch 'release-1_4'...

make: *** empty string invalid as file name.  Stop.
child process exited abnormally

***FATAL***: Error occured during compilation.


*

Offline msl

  • *****
  • 1261
  • A720 IS, SX220 HS 1.01a
    • CHDK-DE links
Re: changelog of trunk including comments / devtalk
« Reply #274 on: 27 / May / 2016, 15:18:36 »
The stable autobuild is down.
Strange. CHDK-DE autobuild rev.4634 was successful. Maybe an issue on the server.

msl
CHDK-DE:  CHDK-DE links

*

Offline Hacki

  • ****
  • 358
  • SX100
Re: changelog of trunk including comments / devtalk
« Reply #275 on: 27 / May / 2016, 16:35:10 »

Its working again, no idea what that was. Didnt need to fix anything, just restart the build.


Best guess is that the SVN checkout terminated early (due to some assembla f-up) and the build started on an incomplete sourcetree?


« Last Edit: 27 / May / 2016, 16:38:04 by Hacki »

*

Offline srsa_4c

  • ******
  • 3907
Re: changelog of trunk including comments / devtalk
« Reply #276 on: 27 / April / 2019, 16:23:51 »
I'm planning to add exmem related information to the sigfinders.
The attached patch is not final, just posting it in case it might conflict with something unpublished.
DIGIC II...5 at the moment.
It adds and corrects stubs for exmem_alloc and exmem_free, also adds a few more related functions to the csv files. Provides a list of exmem types, adds 3 variables that could be used to get information about exmem allocations.

edit:
Committed in r5187 and r5188. Exmem functions are not identified on ixusw_sd430 and sx430is due to large differences, these need to be done manually. D6 is still todo.
« Last Edit: 07 / May / 2019, 19:33:33 by srsa_4c »

*

Offline srsa_4c

  • ******
  • 3907
Re: changelog of trunk including comments / devtalk
« Reply #277 on: 11 / May / 2019, 15:19:15 »
Second part of the exmem related work, for finsig_thumb2.
It appears to work correctly, but - as usual - I might be doing something in a way that is not desired. Can someone take a look?

With this, exmem related coverage in stubs_entry files becomes almost 100%. The 2 problem cameras are ixusw_sd430 and sx430is, where exmem_alloc and/or exmem_free are not identified by the sigfinder.


*

Offline reyalp

  • ******
  • 11902
Re: changelog of trunk including comments / devtalk
« Reply #278 on: 11 / May / 2019, 16:11:32 »
Second part of the exmem related work, for finsig_thumb2.
It appears to work correctly, but - as usual - I might be doing something in a way that is not desired. Can someone take a look?
Nice. Seems fine to me. My only suggestion is to put a name in the rule instead of the empty string, like:
Code: [Select]
{sig_match_exmem_vars,"exmem_types_table", "ExMem.View_FW"},
This is just so printing the rule name gives a useful, unique value.

Also, I noticed that the Canon firmware of g7x2 changed in your diff (the stubs seem compatible, so it's just a little diff noise)
Don't forget what the H stands for.

*

Offline srsa_4c

  • ******
  • 3907
Re: changelog of trunk including comments / devtalk
« Reply #279 on: 11 / May / 2019, 16:35:03 »
My only suggestion is to put a name in the rule instead of the empty string, like:
Code: [Select]
{sig_match_exmem_vars,"exmem_types_table", "ExMem.View_FW"},
This is just so printing the rule name gives a useful, unique value.
Will do that, thanks.
Quote
Also, I noticed that the Canon firmware of g7x2 changed in your diff (the stubs seem compatible, so it's just a little diff noise)
Yes, the g7x2 dump that was shared with us is 101b, Phil's camera is 101a. I'll make a temporary franken-dump to produce the desired output.

edit:
Committed in r5194 and 5195.
« Last Edit: 11 / May / 2019, 17:04:37 by srsa_4c »

 

Related Topics