changelog of trunk including comments / devtalk - page 5 - General Discussion and Assistance - CHDK Forum supplierdeeply
« previous next »
Pages: 1 2 3 4 [5] 6 7 8 9 10 ... 30   Go Down

changelog of trunk including comments / devtalk

  • 299 Replies
  • 204254 Views
*

Offline PhyrePhoX

  • *****
  • 2254
  • make RAW not WAR
    • PhyreWorX
Re: changelog of trunk including comments / devtalk
« Reply #40 on: 28 / January / 2009, 17:05:48 »
Advertisements
1. oh, sure, didnt notice that i could directly do that there, will add it in next committ (in a few minutes)
2. uhm, i dont know O_o
Logged
*

Offline whim

  • ******
  • 2046
  • A495/590/620/630 ixus70/115/220/230/300/870 S95
Re: changelog of trunk including comments / devtalk
« Reply #41 on: 28 / January / 2009, 17:06:22 »
@ewavr

if i were 1 i'd probably blame 'sh' : it's just too forgiving and seems to silently correct path errors  ;)

seriously: this a habit question, any programmer will (or so i imagine) decide to either code path
variables with or without path separator; once you're used to 'your' standard it's hard not to slip up
when your editing someone elses code that uses the other standard ...

wim

Logged
*

Offline ewavr

  • ****
  • 1057
  • A710IS
Re: changelog of trunk including comments / devtalk
« Reply #42 on: 28 / January / 2009, 17:22:27 »
This works under Windows:
Code: [Select]
$(PAKWIF) $(topdir)bin/PS.FIR  $(topdir)/bin/main.bin  $(PLATFORMID) 0x01000101
and this don't (output file not created):
Code: [Select]
$(PAKWIF) $(topdir)/bin/PS.FIR  $(topdir)/bin/main.bin  $(PLATFORMID) 0x01000101
Logged
*

Offline whim

  • ******
  • 2046
  • A495/590/620/630 ixus70/115/220/230/300/870 S95
Re: changelog of trunk including comments / devtalk
« Reply #43 on: 05 / February / 2009, 08:31:51 »
@ewavr

submitted a patch to Mantis (issue 0000225) - hopefully this will prevent the spreading of this by cut/paste ...  :D

wim
Logged
*

Offline whim

  • ******
  • 2046
  • A495/590/620/630 ixus70/115/220/230/300/870 S95
Re: changelog of trunk including comments / devtalk
« Reply #44 on: 15 / February / 2009, 18:35:51 »
@reyalp

GCC (3 + 4) consistently warns on build 710:

Quote
luascript.c: In function `luaCB_md_detect_motion':
luascript.c:500: warning: control reaches end of non-void function

reported on Mantis here: http://chdk.kernreaktor.org/mantis/view.php?id=234

wim
Logged
*

Offline reyalp

  • ******
  • 13938
Re: changelog of trunk including comments / devtalk
« Reply #45 on: 15 / February / 2009, 18:54:59 »
lua_error will prevent that from actually happening, but I'll fix the warning.

BTW, the 710 checking fixes a fairly serious (and seriously stupid!) bug I introduced in md back in 684. Not quite sure how I missed that in testing :(
Logged
Don't forget what the H stands for.
*

Offline reyalp

  • ******
  • 13938
Re: changelog of trunk including comments / devtalk
« Reply #46 on: 14 / March / 2009, 18:44:51 »
#720
* preliminary 12bpp support (my sd990 code + ewavr sx10 code).
  Curves are disabled for 12 bpp
  sd990 and sx10 sections included in camera.h as examples, the rest of the code isn't.
* Digic IV memory layout support with CAM_UNCACHED_BIT
* make g9 stubs_entry.S match what is generated from SVN

This will hopefully help other people working on 12bpp and digic IV cams.
Logged
Don't forget what the H stands for.
*

Offline PhyrePhoX

  • *****
  • 2254
  • make RAW not WAR
    • PhyreWorX
Re: changelog of trunk including comments / devtalk
« Reply #47 on: 14 / April / 2009, 18:49:19 »
hey guys, planning to committ a huge patch in the next days.
it is not finished yet, here is first version attached.
99% of the changes have been coded by PlasmaHH (an irc guy :D)

basically it fixes a lot of warnings (and enables warning options for gcc), adds long time exposure for ixus950 and also introduces a better handling of the long exposure time thingy - also it enables you to set longer times than 64 seconds (so you dont have to use the factor stuff).

however, i am yet unclear about the compiler options.

a) somehow the hostccflag "-Wextra" isnt accepted in gcc 4.3.3, BUT it can be used in the "normal cflags"
b) enabling things like "-Wextra" gives a tremendous amount of warnings when you compile stuff. some warnings can be ignored, others should be corrected.
solution to b) would be: add a flag to buildconf.inc (that enables "debugging") and also squash the warnings by fixing the code

i invite everybody who know how to use a patch to test and comment the diff.



p.s. Used whims chdk shell for first time in months, boy, this thing is great :)
Logged
*

Offline reyalp

  • ******
  • 13938
Re: changelog of trunk including comments / devtalk
« Reply #48 on: 14 / April / 2009, 23:53:22 »
using unsigned for things that are really unsigned is nice.

Adding casts for long is silly. Since long and int refer to the same thing, it would be better to just not use long anywhere. If CHDK ever gets ported to a platform where sizeof(long) != sizeof(int) whoever does it will be in a world of hurt anyway, and casts won't help them.

I'd prefer to see the functionality changes in a separate commit from the warning cleanup.

Also
Code: [Select]
-const char* img_prefixes[NUM_IMG_PREFIXES]={ "IMG_", "CRW_", "SND_" /*, "AUT_", "ETC_","SDR_", "MVI_", "MRK_"*/};
-const char* img_exts[NUM_IMG_EXTS]={ ".JPG", ".CRW", ".CR2", ".THM", ".WAV"/*, ".AVI", ".MRK"*/};
+const char* img_prefixes[NUM_IMG_PREFIXES]={ "IMG_", "CRW_", "SND_", "crw_" , "AUT_", "ETC_","SDR_", "MVI_", "MRK_"};
+const char* img_exts[NUM_IMG_EXTS]={ ".JPG", ".CRW", ".CR2", ".THM", ".WAV", ".AVI", ".MRK", ".DNG" };
???

Particularly CRW_ and crw_ are almost certainly wrong, and dng doesn't belong there either. I don't remember if I left the others commented for a particular reason.
Logged
Don't forget what the H stands for.
*

Offline PhyrePhoX

  • *****
  • 2254
  • make RAW not WAR
    • PhyreWorX
Re: changelog of trunk including comments / devtalk
« Reply #49 on: 18 / April / 2009, 08:44:37 »
checked in the new buildconf.inc flag "OPT_WARNINGS" (#743). if set, compiler will throw out warnings by the dozen.
somehow i couldnt manage to set the hostcc flags for gcc 4, thats why i commented them out. weird.

attached example errors.txt for s3is, gcc 3.4 (created with chdk shell)
« Last Edit: 18 / April / 2009, 08:46:14 by PhyrePhoX »
Logged
Pages: 1 2 3 4 [5] 6 7 8 9 10 ... 30   Go Up
« previous next »
 

Related Topics