Bug Reports against Recent Builds -- Report bugs here - page 21 - CHDK Releases - CHDK Forum

Bug Reports against Recent Builds -- Report bugs here

  • 281 Replies
  • 100845 Views
*

Offline philmoz

  • *****
  • 3332
    • Photos
Re: Bug Reports against Recent Builds -- Report bugs here
« Reply #200 on: 14 / December / 2012, 16:21:54 »
Advertisements
The int_incr in core/gui_menu.c should be initialized to 1 by default.
Currently, if shortcuts are used to adjust manual focus, the int_incr is zero unless you opened the CHDK menu first.  Zero is not a very useful value for a multiplier -- the keys to increase or decrease have no affect.
Making sure it's initial value is 1 fixes the problem.
Code: [Select]
Index: core/gui_menu.c
=============================================================================
--- core/gui_menu.c     (revision 2375)
+++ core/gui_menu.c     (working copy)
@@ -37,7 +37,7 @@
 static int          x, y;
 static int          w, wplus, num_lines;
 static int          len_bool, len_int, len_enum, len_space, len_br1, len_br2, cl_rect;
-static int          int_incr;
+static int          int_incr=1;
 static unsigned char *item_color;
 
 //-------------------------------------------------------------------
This is for 1.2 unstable, I haven't checked if this affects 1.1.



Thanks, fixed in revision 2379. Only affects the trunk (1.2) version.

Phil.
CHDK ports:
  sx30is (1.00c, 1.00h, 1.00l, 1.00n & 1.00p)
  g12 (1.00c, 1.00e, 1.00f & 1.00g)
  sx130is (1.01d & 1.01f)
  ixus310hs (1.00a & 1.01a)
  sx40hs (1.00d, 1.00g & 1.00i)
  g1x (1.00e, 1.00f & 1.00g)
  g5x (1.00c, 1.01a, 1.01b)
  g7x2 (1.01a, 1.01b, 1.10b)

*

Offline lapser

  • *****
  • 1093
get_dof_info() not working
« Reply #201 on: 17 / January / 2013, 13:23:08 »
get_dof_info() returns all 0 values since luascript.c was moved to a module. I think the culprit is this statement in luascript.c:

DOF_TYPE dof_values;

dof_values is declared extern in shooting.h, so it really shouldn't be re-declared in luascript.c, should it?  I tried to put it in the module export list, but that doesn't compile. So I'll leave it to philmoz to fix it.

Attached is my test focusing script that works with trunk 2414 but returns all 0's in trunk 2483

[EDIT] I figured out a quick and dirty fix:

Code: [Select]
//in shooting.h
//extern void shooting_update_dof_values();
extern DOF_TYPE shooting_update_dof_values();

//in shooting.c
//void shooting_update_dof_values()
DOF_TYPE shooting_update_dof_values()
{
     . . . . . .
//  return
  return dof_values;
}

//in luascript.c
static int luaCB_get_dofinfo( lua_State* L )
{
//  shooting_update_dof_values();
  dof_values=shooting_update_dof_values();
« Last Edit: 17 / January / 2013, 13:51:14 by lapser »
EOS-M3_120f / SX50_100b / SX260_101a / G1X_100g / D20_100b
https://www.youtube.com/user/DrLapser/videos

*

Offline philmoz

  • *****
  • 3332
    • Photos
Re: Bug Reports against Recent Builds -- Report bugs here
« Reply #202 on: 17 / January / 2013, 14:13:55 »
get_dof_info() returns all 0 values since luascript.c was moved to a module. I think the culprit is this statement in luascript.c:

DOF_TYPE dof_values;

dof_values is declared extern in shooting.h, so it really shouldn't be re-declared in luascript.c, should it?  I tried to put it in the module export list, but that doesn't compile. So I'll leave it to philmoz to fix it.

Attached is my test focusing script that works with trunk 2414 but returns all 0's in trunk 2483


Good catch, should be fixed in revision 2489.

Phil.
CHDK ports:
  sx30is (1.00c, 1.00h, 1.00l, 1.00n & 1.00p)
  g12 (1.00c, 1.00e, 1.00f & 1.00g)
  sx130is (1.01d & 1.01f)
  ixus310hs (1.00a & 1.01a)
  sx40hs (1.00d, 1.00g & 1.00i)
  g1x (1.00e, 1.00f & 1.00g)
  g5x (1.00c, 1.01a, 1.01b)
  g7x2 (1.01a, 1.01b, 1.10b)

*

Offline lapser

  • *****
  • 1093
Re: Bug Reports against Recent Builds -- Report bugs here
« Reply #203 on: 17 / January / 2013, 19:03:03 »
Good catch, should be fixed in revision 2489.
I've attached my complete fix if you need it. You may want to fix it in a different way. My way gets rid of a global variable, which is what caused the confusion.

I caught this bug on top of a mountain when my time lapse program wouldn't focus at the hyperfocal distance like it used to. It was below freezing, with a breeze, so my fingers were pretty numb by the time I got it working.
[EDIT] oops, you beat me to it. Good job!
« Last Edit: 17 / January / 2013, 19:04:40 by lapser »
EOS-M3_120f / SX50_100b / SX260_101a / G1X_100g / D20_100b
https://www.youtube.com/user/DrLapser/videos


Re: Bug Reports against Recent Builds -- Report bugs here
« Reply #204 on: 19 / January / 2013, 13:06:40 »
Hello!  I have a problem with CHDK for Canon PowerShot sx 110 is and some other models. Russian doesn't work.

Re: Bug Reports against Recent Builds -- Report bugs here
« Reply #205 on: 19 / January / 2013, 14:14:27 »
Hello!  I have a problem with CHDK for Canon PowerShot sx 110 is and some other models. Russian doesn't work.
Please provide more details with this report.   What does "doesn't work" mean?  Do you mean that there is no Russian option in the Visual Settings | Language menu ?  Or that you select Russian in that menu and nothing happens?  Or that some text is in Russian but other text is still in English? 
Ported :   A1200    SD940   G10    Powershot N    G16

*

Offline fe50

  • ******
  • 3132
  • IXUS50 & 860, SX10 Star WARs-Star RAWs
    • fe50
Re: Bug Reports against Recent Builds -- Report bugs here
« Reply #206 on: 19 / January / 2013, 19:21:20 »
Hello!  I have a problem with CHDK for Canon PowerShot sx 110 is and some other models. Russian doesn't work.
Did you choose the correct code page ?
Select Win1251 for russian language...

--> http://chdk.wikia.com/wiki/Languages

*

Offline srsa_4c

  • ******
  • 4426
Re: Bug Reports against Recent Builds -- Report bugs here
« Reply #207 on: 24 / January / 2013, 01:17:25 »
While testing my Ixus30 port with current trunk code I have noticed something that might be related to the recently reported S5IS problem.
If I start the cam in play mode, navigate to the enhanced photo operations menu and press half shoot, the cam crashes. The romlog appears to indicate an ND filter related crash (unknown state). Since I can't figure out how the menu works, I'd like to ask for help.

The crash only happens in that submenu (the selected menu item doesn't matter), nowhere else.
The crash doesn't happen after the cam is switched to rec mode (of course, ND gets initialized). The cam has #define CAM_HAS_ND_FILTER 1, and I believe that the play/rec state is correctly reported.
I suspect that the submenu in question somehow ignores the play/rec state (under specific conditions). If needed, I can of course upload a diff for this port.
I haven't been able to reproduce this on the Ixus110.

edit: attachment removed
« Last Edit: 27 / January / 2013, 19:47:36 by srsa_4c »


*

Offline philmoz

  • *****
  • 3332
    • Photos
Re: Bug Reports against Recent Builds -- Report bugs here
« Reply #208 on: 24 / January / 2013, 02:41:58 »
While testing my Ixus30 port with current trunk code I have noticed something that might be related to the recently reported S5IS problem.
If I start the cam in play mode, navigate to the enhanced photo operations menu and press half shoot, the cam crashes. The romlog appears to indicate an ND filter related crash (unknown state). Since I can't figure out how the menu works, I'd like to ask for help.

The crash only happens in that submenu (the selected menu item doesn't matter), nowhere else.
The crash doesn't happen after the cam is switched to rec mode (of course, ND gets initialized). The cam has #define CAM_HAS_ND_FILTER 1, and I believe that the play/rec state is correctly reported.
I suspect that the submenu in question somehow ignores the play/rec state (under specific conditions). If needed, I can of course upload a diff for this port.
I haven't been able to reproduce this on the Ixus110.

Can you upload the ROMLOG and corresponding main.dump file for the build that caused the crash please.

Phil.
CHDK ports:
  sx30is (1.00c, 1.00h, 1.00l, 1.00n & 1.00p)
  g12 (1.00c, 1.00e, 1.00f & 1.00g)
  sx130is (1.01d & 1.01f)
  ixus310hs (1.00a & 1.01a)
  sx40hs (1.00d, 1.00g & 1.00i)
  g1x (1.00e, 1.00f & 1.00g)
  g5x (1.00c, 1.01a, 1.01b)
  g7x2 (1.01a, 1.01b, 1.10b)

*

Offline srsa_4c

  • ******
  • 4426
Re: Bug Reports against Recent Builds -- Report bugs here
« Reply #209 on: 24 / January / 2013, 06:54:32 »
Can you upload the ROMLOG and corresponding main.dump file for the build that caused the crash please.
Sure, however note that the romlog is quite different and I found no way to get it out into a file yet. It's located at the start of the ROM dump (starts at 0xff800000).
Also attached is the source diff and the main.dump (see updated previous post).

update:
ixus40, CHDK trunk: same issue
ixus65: no problem

ixus30:
- forced rec_mode_active() to return 0, issue remains

edit: attachment removed to save space
« Last Edit: 27 / January / 2013, 19:47:00 by srsa_4c »

 

Related Topics