A570 Underwater need to move the Alt button - page 4 - General Discussion and Assistance - CHDK Forum
supplierdeeply

A570 Underwater need to move the Alt button

  • 35 Replies
  • 10743 Views
*

Offline reyalp

  • ******
  • 12217
Re: A570 Underwater need to move the Alt button
« Reply #30 on: 20 / June / 2012, 23:15:05 »
Advertisements
just tried it and seems to be working . Thank you very much.
I'll post it once you've had time to do some testing and report back.
If you post the code, I'll be happy to verify it and check it in, since I actually have this camera.
Don't forget what the H stands for.

Re: A570 Underwater need to move the Alt button
« Reply #31 on: 21 / June / 2012, 00:05:32 »
If you post the code, I'll be happy to verify it and check it in, since I actually have this camera.
Wiil do - thanks.  Haven't looked at the dev trunk version yet but I think I remember how to do that too  :)

Note that in doing this change on an old platform,  I simply sucked the common generic/kbd.c code into the platform/a540 kbd.c code, made the necessary changes and removed the #include "../generic/kbd.c"  in the platform/kbd.c.

Which of coarse led to a little investigation and the discovery that there are about 12 other older cameras still using that old generic/kbd.c code.  So why stop at the A540 ?   (Besides the fact that the old code it touchy and the choice of buttons available may or may not change .... not much).

So do we make the changes for all those old cams or just do it on a case by case as requested basis ?

Update :  I think what I was really asking is do "we" change the code in generic/kbd.c for all the old cams or suck the code into each port when requested to do so ?
 

« Last Edit: 21 / June / 2012, 00:31:20 by waterwingz »
Ported :   A1200    SD940   G10    Powershot N    G16

*

Offline reyalp

  • ******
  • 12217
Re: A570 Underwater need to move the Alt button
« Reply #32 on: 21 / June / 2012, 00:43:27 »
I'd forgotten about the common kbd.c

Ideally, I'd say adjustable alt should be a standard feature. I'd expect all the cameras still using the common kbd.c have the same buttons available.

I hate copy/paste code but the vast majority of cameras aren't using the shared code, and it's kind of a mess so I guess moving it out isn't a big deal.

Have to think about this a little more.
Don't forget what the H stands for.

Re: A570 Underwater need to move the Alt button
« Reply #33 on: 21 / June / 2012, 00:46:23 »
I'd forgotten about the common kbd.c
Spend a little time there a few months ago ....

Quote
Ideally, I'd say adjustable alt should be a standard feature. I'd expect all the cameras still using the common kbd.c have the same buttons available.
Agreed.

Quote
I hate copy/paste code but the vast majority of cameras aren't using the shared code, and it's kind of a mess so I guess moving it out isn't a big deal.
Well,  I did clean up the C&P in the A540 code I posted.  And those cams are at least 5 years old so its not like its any rush all-of-a-sudden.   Especially with Canon pushing new cams out every 3-6 months these days.

Ported :   A1200    SD940   G10    Powershot N    G16


Re: A570 Underwater need to move the Alt button
« Reply #34 on: 21 / June / 2012, 19:02:30 »
Have to think about this a little more.
While you're thinking,  here's a patch file that converts every camera that uses the generic/kbd.c so that it has an adjustable <ALT> button.

This includes a little cleanup in generic/kbd.c  (#ifdefs for cams that don't include this file) and changes to these cameras  :

     a410   a420   a430   a530   a540   a610   a620
     a630   a640   a700   a710   ixus800_sd700


The rebuild for the a540 binary is here :  https://www.box.com/s/474784f27e4ec1c70851

Stable and dev trunk versions attached.  Built for each camera but not tested (obviously).

« Last Edit: 21 / June / 2012, 19:35:27 by waterwingz »
Ported :   A1200    SD940   G10    Powershot N    G16

Re: A570 Underwater need to move the Alt button
« Reply #35 on: 23 / June / 2012, 21:53:11 »
Code in the svn for the dev version was updated to support this today for all of the older cameras mentioned above.

Code for the stable branch will not be changed so if you want this feature,  you need to move on to the new trunk.

The patch file I posted can still be used to modify the stable branch if you are able to rebuild CHDK for yourself.

« Last Edit: 23 / June / 2012, 22:37:11 by waterwingz »
Ported :   A1200    SD940   G10    Powershot N    G16

 

Related Topics