difference between PROPCASE_FOCUS_MODE and wiki description - General Discussion and Assistance - CHDK Forum
« previous next »
Pages: [1]   Go Down

difference between PROPCASE_FOCUS_MODE and wiki description

  • 2 Replies
  • 3894 Views
*

Offline rudi

  • ***
  • 129
  • A590IS_101B, SX260HS_100B
difference between PROPCASE_FOCUS_MODE and wiki description
« on: 08 / March / 2010, 11:45:56 »
Advertisements
Hi,

I think there is a difference between wiki-PropertyCases description for "focus mode" and CHDK-Propcase definition.

 PROPCASE_FOCUS_MODE should better named PROPCASE_MANUAL_FOCUS.
 So I prepared for rename in PROPCASE_MANUAL_FOCUS and also changed lua/ubasic function in get_manual_focus.

All changes based on trunk 875 (trunk875_part1.diff). Successful tested on my A590 and compilertest for all cam's with CHDK-shell.

I have another diff for new propcases and lua/ubasic functions in this context.
Propset index tested by CHDKLover (A610) for Propset1, Mita (G11) for Propset3 and myself (A590) for Propset2.

- add PROPCASE_FOCUS_MODE equal wiki -> PropertyCase -> focus mode
- add PROPCASE_FOCUS_STATE

lua and ubasic
- add function get_focus_mode
    0:NORMAL; 1:MACRO
  NOT ON PROPSET3! (tested by Miata from german forum - here)
    3:INFINITY; 4:MANUAL; 5:SUPER_MACRO

- add function get_focus_state
  >0 focus ok
  =0 focus fail
  <0 manual focus
 
- add function get_focus_ok
    if PROPCASE_FOCUS_STATE!=0 and PROPCASE_SHOOTING=1 then OK

All changes together at trunk875_FOCUS_MODE.diff and additional scripts for test.

rudi
Logged
*

Offline msl

  • *****
  • 1280
  • A720 IS, SX220 HS 1.01a
    • CHDK-DE links
Re: difference between PROPCASE_FOCUS_MODE and wiki description
« Reply #1 on: 12 / March / 2010, 15:10:55 »
good job rudi,

this seems  to be a very important correction for manual focus things.

But I am surprised that nobody here is interested. ???
Logged
CHDK-DE:  CHDK-DE links
*

Offline rudi

  • ***
  • 129
  • A590IS_101B, SX260HS_100B
Re: difference between PROPCASE_FOCUS_MODE and wiki description
« Reply #2 on: 14 / March / 2010, 11:03:41 »
An error was found in function get_focus_state on Propset1 cams. Manual focus don't show never negative value.

Patch attached.

rudi
« Last Edit: 14 / March / 2010, 16:43:27 by rudi »
Logged
Pages: [1]   Go Up
« previous next »
 

Related Topics


SimplePortal © 2008-2014, SimplePortal