SX200is Porting - page 42 - DryOS Development - CHDK Forum

SX200is Porting

  • 1105 Replies
  • 575967 Views
*

Offline reyalp

  • ******
  • 14128
Re: SX200is Porting
« Reply #410 on: 23 / September / 2009, 02:33:24 »
Advertisements
I've corrected the line endings on my end.

edit:
and the fact that the automatically found entry points in stubs_entry.S are identical between 100c and 100d suggests they will be compatible.
Don't forget what the H stands for.

*

Offline ihar

  • **
  • 55
Re: SX200is Porting
« Reply #411 on: 23 / September / 2009, 03:05:51 »
Quote
102    RO    Drive Mode (0,1,2 = single, continuous, custom timer) I have found this Options with debug Mode.

102    RO    Drive Mode (0,1 = single, continuous) that must have other Cams.
Hi
smartkiller
I look props in debug and change modes. With custom timer 102 props == 0!
therefore my path is worked.

Ihar


Re: SX200is Porting
« Reply #412 on: 23 / September / 2009, 03:37:59 »
- in edgeoverlay.c and gui_osd.c someone has added draw_txt_string calls with various debug messages, but this will not really be effective since they will only last until the next display update. Are they actually useful ?

Thanks, sorry, it's my fault. I have send my debug version. I'll send the right one this afternoon. The debug lines are all obsolete.








*

Offline OldGit

  • ****
  • 303
Re: SX200is Porting
« Reply #413 on: 23 / September / 2009, 04:01:03 »
Hi,
Dev-svn has been updated to replace CR LF pairs with LF in affected files.

Also I did not list the changed file core/gui_grid.c, I will edit the original list I posted.
OldGit
SX200 IS-100C

*

Offline OldGit

  • ****
  • 303
Re: SX200is Porting
« Reply #414 on: 23 / September / 2009, 04:18:25 »
I'll send the right one this afternoon. The debug lines are all obsolete.
@nandoide,
can you see if any other code in the core files you updated could be increasing the size of other camera builds, as reported by @whim.
I don't want to change anything in the files you are dealing with so it would be better if you could take a look.

Thanks,
OldGit
SX200 IS-100C

*

Offline reyalp

  • ******
  • 14128
Re: SX200is Porting
« Reply #415 on: 23 / September / 2009, 04:23:55 »
I'll send the right one this afternoon. The debug lines are all obsolete.
@nandoide,
can you see if any other code in the core files you updated could be increasing the size of other camera builds, as reported by @whim.
I don't want to change anything in the files you are dealing with so it would be better if you could take a look.

Thanks,
OldGit
It's OK, I have no trouble removing those lines. Same for the list of files changed, I can clearly see what has changed using SVN.

I'm not worried about a few hundred bytes. There's a bunch of changes in the core and ifdefing them all doesn't necessarily make sense.
Don't forget what the H stands for.

Re: SX200is Porting
« Reply #416 on: 23 / September / 2009, 04:49:55 »
OldGit, yes, I'll take a look also to patches. Revisiting edgeoverlay.c for the debug lines issue, I think I should be a bit more conservative here.

Re: SX200is Porting
« Reply #417 on: 23 / September / 2009, 07:23:14 »
OldGit, yes, I'll take a look also to patches. Revisiting edgeoverlay.c for the debug lines issue, I think I should be a bit more conservative here.


Hi, I see that simply it's necessary to change this directive on camera.h, at line 82

 #define ASPECT_VIEWPORT_XCORRECTION(x) ( ((x)<<1) )

to

 #define ASPECT_VIEWPORT_XCORRECTION(x) ( (x) )

*

Offline reyalp

  • ******
  • 14128
Re: SX200is Porting
« Reply #418 on: 23 / September / 2009, 22:31:29 »
How about  ASPECT_GRID_XCORRECTION(x) ?
Don't forget what the H stands for.

Re: SX200is Porting
« Reply #419 on: 24 / September / 2009, 01:01:09 »
How about  ASPECT_GRID_XCORRECTION(x) ?

The code that uses this macro is patched by CAM_USES_ASPECT_CORRECTION, but well, it's more clean than default values are left as ((x)), that implies no correction.

 

Related Topics


SimplePortal © 2008-2014, SimplePortal