errors in some modemaps - page 2 - General Discussion and Assistance - CHDK Forum supplierdeeply

errors in some modemaps

  • 18 Replies
  • 6050 Views
*

Offline reyalp

  • ******
  • 13400
Re: errors in some modemaps
« Reply #10 on: 04 / October / 2009, 17:23:21 »
Advertisements
The debug data display has been used to author (most?) platform/*/main.c modemaps, which in turn are (only?) used by mode_get()....mode_get() in turn is (only, I hope) used by CHDK to check PLAY/REC modes (and I guess swivel screen status), but not the modemap.
Not quite true. There are some checks for manual, sports, stitch assist etc. As I noted in the mantis issue linked above, the whole system basically sucks. Most of the modes are meaningless to CHDK, but in some cases they aren't.

Quote
And yes, mode_get reads the propcase value into an int as does shooting_get_prop().
No, shooting_get_prop reads it into a short. This gets returned as an int, at which point it gets sign extended. This is probably wrong.

mode_get (on the platforms I checked anyway) reads into an int to start with.
Don't forget what the H stands for.

*

Offline reyalp

  • ******
  • 13400
Re: errors in some modemaps
« Reply #11 on: 28 / November / 2009, 05:25:47 »
Another fun one, s2is
Code: [Select]
    { MODE_AUTO,                5 },
    { MODE_P,                   1 },
    { MODE_TV,                  3 },
    { MODE_AV,                  2 },
    { MODE_M,                   0 },
    { MODE_PORTRAIT,            6 },
    { MODE_NIGHT,               8 },
    { MODE_LANDSCAPE,           7 },
    { MODE_VIDEO_STD,           16  },
    { MODE_STITCH,              0xFF },
    { MODE_MY_COLORS,           4 },
    { MODE_SCN_NIGHT,           14 },
    { MODE_SCN_CHILD,           0xFF },
    { MODE_SCN_PARTY,           13 },
    { MODE_SCN_GRASS,           9 },
    { MODE_SCN_SNOW,            10 },
    { MODE_SCN_BEACH,           11 },
    { MODE_SCN_FIREWORK,        12 },
    { MODE_SCN_COLOR_ACCENT,    0xFF }
modemap is currently only used to lookup from canon mode to CHDK mode.  So if the 0xFF values are what canon actually uses, then MODE_STITCH will be returned for all of these.

According to canon this camera does have a stitch mode, so these aren't just (misguided) placeholders for non existent modes.

Anyone have one of these and want to test ?

Don't forget what the H stands for.

*

Offline ewavr

  • ****
  • 1057
  • A710IS
Re: errors in some modemaps
« Reply #12 on: 28 / November / 2009, 07:25:00 »
S2IS 1.00E
Code: [Select]
ROM:FF983778 dword_FF983778  DCD 0                                       ; DATA XREF: ROM:off_FF9837CCo
ROM:FF98377C                 DCD 1
ROM:FF983780                 DCD 2
ROM:FF983784                 DCD 3
ROM:FF983788                 DCD 4
ROM:FF98378C                 DCD 5
ROM:FF983790                 DCD 6
ROM:FF983794                 DCD 7
ROM:FF983798                 DCD 8
ROM:FF98379C                 DCD 9
ROM:FF9837A0                 DCD 0xA
ROM:FF9837A4                 DCD 0xB
ROM:FF9837A8                 DCD 0xC
ROM:FF9837AC                 DCD 0xD
ROM:FF9837B0                 DCD 0xE
ROM:FF9837B4                 DCD 0xF
ROM:FF9837B8                 DCD 0x10
ROM:FF9837BC                 DCD 0x20011
ROM:FF9837C0                 DCD 0x30012

*

Offline msl

  • *****
  • 1276
  • A720 IS, SX220 HS 1.01a
    • CHDK-DE links
Re: errors in some modemaps
« Reply #13 on: 28 / November / 2009, 10:43:08 »
here is a test by a S2 user from german CHDK forum:
Code: [Select]
{ MODE_AUTO,                5 },=5
{ MODE_P,                   1 },=1
{ MODE_TV,                  3 },=3
{ MODE_AV,                  2 },=2
{ MODE_M,                   0 },=0
{ MODE_PORTRAIT,            6 },=6
{ MODE_NIGHT,               8 },=8
{ MODE_LANDSCAPE,           7 },=7
{ MODE_VIDEO_STD,         16  },=16
{ MODE_STITCH,           0xFF },=15
{ MODE_MY_COLORS,           4 },=4
{ MODE_SCN_NIGHT,          14 },=14
{ MODE_SCN_CHILD,        0xFF },= n.a.
{ MODE_SCN_PARTY,          13 },=13 Indoor
{ MODE_SCN_GRASS,           9 },=9 Foliage
{ MODE_SCN_SNOW,           10 },=10
{ MODE_SCN_BEACH,          11 },=11
{ MODE_SCN_FIREWORK,       12 },=12
{ MODE_SCN_COLOR_ACCENT, 0xFF }= n.a.
CHDK-DE:  CHDK-DE links


*

Offline reyalp

  • ******
  • 13400
Re: errors in some modemaps
« Reply #14 on: 28 / November / 2009, 19:39:19 »
Great, fixed in changeset 845
Don't forget what the H stands for.

*

Offline reyalp

  • ******
  • 13400
Re: errors in some modemaps
« Reply #15 on: 03 / December / 2009, 21:41:05 »
a640, ixus 630, and ixus_izoom still have problems, see ewavrs post  http://chdk.setepontos.com/index.php/topic,3228.90.html

Also, in the newer cameras (ones that use numbers like AUTO= 32768, VIDEO_STD=25xx etc) the common modes like M, P, TV use exactly the same values, but the scene and video modes do not.

edit:
also a630, a700 have problems
« Last Edit: 04 / December / 2009, 01:08:20 by reyalp »
Don't forget what the H stands for.

*

Offline reyalp

  • ******
  • 13400
Re: errors in some modemaps
« Reply #16 on: 04 / December / 2009, 01:36:36 »
In changeset 855 I've adjusted a630, a640, a700, ixus60, ixus65. These are not verified, but probably better than what was there before.
Don't forget what the H stands for.

*

Offline ewavr

  • ****
  • 1057
  • A710IS
Re: errors in some modemaps
« Reply #17 on: 04 / December / 2009, 03:43:08 »
About http://tools.assembla.com/chdk/changeset/856 :
Indeed, for a710  MODE_SCN_COLOR_SWAP must be used instead of MODE_MY_COLORS.


*

Offline reyalp

  • ******
  • 13400
Re: errors in some modemaps
« Reply #18 on: 04 / December / 2009, 22:17:19 »
I've updated a710, a630 and a640 in changeset 857. All of these appear to have "color swap" instead of "my colors"
Don't forget what the H stands for.

 

Related Topics