Histogram bug - General Discussion and Assistance - CHDK Forum

Histogram bug

  • 8 Replies
  • 3399 Views
*

Offline RaduP

  • *****
  • 908
Histogram bug
« on: 09 / October / 2009, 16:15:12 »
Advertisements
Well, the histogram would not be shown during the PLAY mode. I tracked it to this code in gui.c
Code: [Select]
    if ((gui_mode==GUI_MODE_NONE || gui_mode==GUI_MODE_ALT) && ((kbd_is_key_pressed(KEY_SHOOT_HALF) && ((conf.show_histo==SHOW_HALF)/* || (m&MODE_MASK) == MODE_PLAY*/)) ||
     ((conf.show_histo==SHOW_ALWAYS)  &&  !((m&MODE_MASK) == MODE_PLAY) && (recreview_hold==0))
    ) &&
    (mode_photo || (m&MODE_SHOOTING_MASK)==MODE_STITCH)) {

The problem is this part: &&  !((m&MODE_MASK) == MODE_PLAY)
Why is it there in the first place?

*

Offline Atnas

  • *
  • 29
Re: Histogram bug
« Reply #1 on: 09 / October / 2009, 18:05:21 »
Because the camera has a built in histogram when in play mode?
And because the CHDK histogram is going off what the sensor sees, and not already taken images.
A710 - SD1000(IXUS70)

*

Offline RaduP

  • *****
  • 908
Re: Histogram bug
« Reply #2 on: 09 / October / 2009, 18:39:27 »
Because the camera has a built in histogram when in play mode?
And because the CHDK histogram is going off what the sensor sees, and not already taken images.

Did you look at the source code?

*

Offline reyalp

  • ******
  • 13792
Re: Histogram bug
« Reply #3 on: 09 / October / 2009, 20:23:36 »
Did you look at the source code?
Histogram already shows in play mode if you half shoot. It's hard to say exactly what the intended behavior of that mess was.
Don't forget what the H stands for.


*

Offline Atnas

  • *
  • 29
Re: Histogram bug
« Reply #4 on: 09 / October / 2009, 20:31:32 »
Did you look at the source code?

No, just guessing.

But why would you want it to be shown in play mode at all?
A710 - SD1000(IXUS70)

*

Offline RaduP

  • *****
  • 908
Re: Histogram bug
« Reply #5 on: 09 / October / 2009, 21:00:25 »
Did you look at the source code?
Histogram already shows in play mode if you half shoot. It's hard to say exactly what the intended behavior of that mess was.

Well, at least on my camera, half shooting in play mode switches the camera to record mode.. So it is impossible to view the histogram of the already taken photos.

*

Offline RaduP

  • *****
  • 908
Re: Histogram bug
« Reply #6 on: 09 / October / 2009, 21:01:15 »
But why would you want it to be shown in play mode at all?

Consistency. And being able to view the image on the whole screen with the histogram there.

*

Offline reyalp

  • ******
  • 13792
Re: Histogram bug
« Reply #7 on: 09 / October / 2009, 22:51:06 »
Well, at least on my camera, half shooting in play mode switches the camera to record mode.. So it is impossible to view the histogram of the already taken photos.
Good point, this is true of most newer cameras.
Don't forget what the H stands for.


*

Offline RaduP

  • *****
  • 908
Re: Histogram bug
« Reply #8 on: 09 / October / 2009, 23:03:04 »
Anyway, the reason why I called it a bug is that in the configuration menu you can set the histogram to "Always", so that implies playback too. Maybe there should be a different setting then or something.

 

Related Topics