I've noticed that in the new releases in the autobuild server this fix is not implemented yet, will be inthe future??
Quote from: sparky72 on 04 / November / 2009, 02:34:56I've noticed that in the new releases in the autobuild server this fix is not implemented yet, will be inthe future??Yes, I actually started looking at that tonight. However, I'm a bit wary of putting it in the way it is, because it affects all cameras (well, all that implement extended tv), all the time.It should be OK I guess, because only changes the value if the incoming value is different from the propcase, but I'd be a lot happier if it only got invoked when overrides were specifically requested by the user or script. Unfortunately, we can't determine the second one with existing variables, because the script override is cleared before that point.I'm currently undecided as to whether to check it in as is. Feedback from people who have used builds with this in place on different cameras, with and without overrides would be appreciated. I'm not worried about how much override you get, I'm only concerned that it works correctly on all cameras when you aren't using an override.
I would think it shouldn't cause any problems with any other cameras. As you said, it only kicks in when the TV setting comes up different than that set, so on cameras where things are working fine, it would be ignored.But, if wanted, I suppose a conditional compile option could be inserted to implement it only on the cameras desired.For now, I know that it affects the SX10 and likely the SX1 as it has a similar build. People would need to confirm what other cameras need it.If you'd like, I can try to make a new patch with a conditional build.
int apex2us(int apex_tv){#if CAM_EXT_TV_RANGE || CAM_EXT_TV_RANGE_HS #if CAM_EXT_TV_RANGE_HS short tv; tv = shooting_get_tv96(); if (tv<-576 || tv!=apex_tv) return 1000000.0*pow(2.0, -tv/96.0); #else if (apex_tv<-576) return 1000000.0*pow(2.0, -apex_tv/96.0); #endif else return _apex2us(apex_tv);#else return 0;#endif}
#if CAM_EXT_TV_RANGE || CAM_EXT_TV_RANGE_HS if (my_ncmp(name, "tExpDrvTas", 10) == 0){ *entry = (long)exp_drv_task; } #endif
I would think it shouldn't cause any problems with any other cameras. As you said, it only kicks in when the TV setting comes up different than that set, so on cameras where things are working fine, it would be ignored.
Assuming that the propcase read by shooting_get_tv96() contains the correct value at that point, and that it is safe to call that function there. These are both probably true, but the more I thought about it last night, the less I liked it. I'm probably just being paranoid My preferred approach would be to decide this at run time. If no overrides or script overrides are engaged, use the stock apex2us. That way, if something was broken, it wouldn't affect normal camera operation. But as I said earlier, there's no easy way to see if script override was used at that point. This could be added, but I'm not sure it's worth it.
Hello, after some time I'm back...I've noticed that the patch is not working with the latest build, there is a way to fix it?Kind regardsGiorgio
Started by polishruben « 1 2 » General Discussion and Assistance
Started by zeljan DSLR Hack development
Started by PhyrePhoX Feature Requests
Started by mlietchnyipout General Discussion and Assistance
Started by barberofcivil « 1 2 3 4 » General Discussion and Assistance
