Already fixed bug reintroduced again with 'changeset by EWAVR' - General Discussion and Assistance - CHDK Forum

Already fixed bug reintroduced again with 'changeset by EWAVR'

  • 13 Replies
  • 12038 Views
Already fixed bug reintroduced again with 'changeset by EWAVR'
« on: 01 / February / 2008, 02:34:32 »
Advertisements

in trunk/platform/ixus800_sd700/main.c:

Has to be this way otherwise Tv override will dye again:

} modemap[] = {
    { MODE_AUTO,               32768 },
//    { MODE_M,                  32772 },
    { MODE_P,                  32772 },

Thank you

Re: Already fixed bug reintroduced again with 'changeset by EWAVR'
« Reply #1 on: 01 / February / 2008, 12:05:39 »
Should I fix it myself ?

Is it allowed ?

What are the rules ?

*

Offline ewavr

  • ****
  • 1057
  • A710IS
Re: Already fixed bug reintroduced again with 'changeset by EWAVR'
« Reply #2 on: 01 / February / 2008, 12:57:26 »
"changeset [281] by EWAVR" ???
Changelog r251->r281
On assembla.com in ANY version of trunc was "MODE_M" for IXUS800.
 This bug will be fixed at next commit.
« Last Edit: 01 / February / 2008, 13:07:33 by ewavr »

Re: Already fixed bug reintroduced again with 'changeset by EWAVR'
« Reply #3 on: 01 / February / 2008, 13:41:53 »
I reported the bug two times, to Fingalo and AllBest.
Both said it will be fixed in the next release, but obviously never was.

This is frustrating, therefore I have to ask again:

Should I fix such bugs in the trunk myself ?

Is it allowed ?

What are the rules ?

Or should I better stop reporting bugs at all and fix my private build only ?


*

Offline ewavr

  • ****
  • 1057
  • A710IS
Re: Already fixed bug reintroduced again with 'changeset by EWAVR'
« Reply #4 on: 02 / February / 2008, 01:45:59 »

Re: Already fixed bug reintroduced again with 'changeset by EWAVR'
« Reply #5 on: 02 / February / 2008, 02:31:43 »
Nobody willing to answer my questions ?

*

Offline ewavr

  • ****
  • 1057
  • A710IS
Re: Already fixed bug reintroduced again with 'changeset by EWAVR'
« Reply #6 on: 02 / February / 2008, 02:45:00 »
Nobody willing to answer my questions ?

chdk space on assembla.com team. "Members" can write files, "owners" can everything  ;)

*

Offline ewavr

  • ****
  • 1057
  • A710IS
Re: Already fixed bug reintroduced again with 'changeset by EWAVR'
« Reply #7 on: 02 / February / 2008, 02:46:14 »
-deleted message-
« Last Edit: 02 / February / 2008, 02:48:23 by ewavr »

Re: Already fixed bug reintroduced again with 'changeset by EWAVR'
« Reply #8 on: 02 / February / 2008, 05:15:21 »

Thank you, ewavr.

I do programming for a living. But never did open source in a globally distributed team.
Was always locked away in a closet. Sorry for my ignorance...  ::)


I will check-in IXUS800 specific fixes myself in the future.


I'm working on super macro and manual focusing, as you surely already noticed.
Proof of concept was successful!

Can I create a temporary 'nirschi' trunk to exchange with other IXUS developers ?
If not, please do it for me.

Is there anywhere a discussion of global concepts and changes - at developers level - in English ?

Re: Already fixed bug reintroduced again with 'changeset by EWAVR'
« Reply #9 on: 03 / February / 2008, 00:13:47 »
Did my first commit to assembla.com/chdk late in the evening yesterday: http://tools.assembla.com/chdk/changeset/285

There are changes reported which differ in white space only. A bug in SVN commit? A feature? ???

I'm using Inprise (aka Borland) multi-language IDEs, which are highly configurable therefore.
There are some interresting 'Editor Options', see my settings:
- Use tab character: no
- Tab stops: 4
- Keep trailing blanks: no

Should I turn on 'Keep trailing blanks' as a workaround or - should the source be cleaned up?
(I know about the annoying 'White space changes' tick in the Browser)

What's about tabs ?

EDIT:
What's about BUILD_NUMBER := ?

Should I swap lines this way to ease reading in SVN diff browser ?
Code: [Select]
//#if !defined (CAMERA_ixus700_sd500) && !defined (CAMERA_ixus800_sd700) && !defined(CAMERA_a560)
//nirschi: IXUS800(me) and IXUS950(whoever) tested OK, a560 and ixus800+ should not crash calling ...
#if !defined (CAMERA_ixus700_sd500)

NOTE: Comments will be removed when this test level is over.
« Last Edit: 03 / February / 2008, 01:54:03 by nirschi »

 

Related Topics


SimplePortal © 2008-2014, SimplePortal