Brand new edge overlay. Please test.

f_m_b

Re: Brand new edge overlay. Please test.

« Reply #30 on: 27 / August / 2010, 16:34:59 »

Advertisements

Quote from: ultimA on 27 / August / 2010, 13:41:20

I can't seem to reproduce it. But since the corruptions are only visible for 1/2 sec, this is a minor issue. I will try to correct them if I manage to reproduce somehow. Currently, I do not see any place in the code that could be responsible for such things. In any case, this is not a blocker and I consider the patch final (with the minor adjustments described in this post)

This is no showkiller.

Some adicional informations: It is not always exactly 1/2 screen. It vary from 1/3 up to 1/2 screen. So i don't think it is a y-indices problem. Probably it is a timing problem in the draw method?
I have looked some closer in the code, an tried some changes in it, but without finding a track.

Logged

Greetings Frank
SX20 (1.02b)

ultimA

Re: Brand new edge overlay. Please test.

« Reply #31 on: 27 / August / 2010, 19:26:29 »

Quote from: f_m_b on 27 / August / 2010, 04:45:13

- pano off: From frozen mode to live mode (pressing shutter) there are for 0.5 second not valid edges shown on the upper half of display.
-play mode: switching from one foto to the next. ...

Oh I got what you mean now. Yes I can see it. I am pretty sure this is a result of two things: i) asynchronous refresh of screen by factory fw, and ii) lag time so that it becomes visible because the edge drawing takes long. This same artifact you should have with zebra too, but you can not see it there because it is happening too fast. Drawing the screen for the edge overlay takes much longer because the bitvector has to be decompressed. I am almost 100% sure that this is not a bug in the code.

Logged

whoever

280
IXUS950

Re: Brand new edge overlay. Please test.

« Reply #32 on: 28 / August / 2010, 10:40:04 »

How about using raw buffer to satisfy your memory needs without compression/decompression? Large chunk of memory, free most of the time... Just an idea -- I haven't tried anything such.

Logged

ultimA

Re: Brand new edge overlay. Please test.

« Reply #33 on: 28 / August / 2010, 11:02:46 »

Quote from: whoever on 28 / August / 2010, 10:40:04

How about using raw buffer to satisfy your memory needs without compression/decompression? Large chunk of memory, free most of the time... Just an idea -- I haven't tried anything such.

I don't think it would work. Zebra, for example, does not need a buffer since it only needs to be displayed on the screen, so it can be drawn to the screen directly. But edge overlay must be preserved *across shots*, so what would happen if I use the raw buffer to store the overlay and someone makes a picture? Either the picture or the edge overlay would get corrupted. Am I right?

Logged

whoever

280
IXUS950

Re: Brand new edge overlay. Please test.

« Reply #34 on: 28 / August / 2010, 11:09:40 »

Quote from: ultimA on 28 / August / 2010, 11:02:46

But edge overlay must be preserved *across shots*, so what would happen if I use the raw buffer to store the overlay and someone makes a picture?
...
Am I right?

Of course you are. You see, I didn't look at the code and don't know how these things work. I just thought it could be processed faster with more temporary storage at hands.

Logged

reyalp

12690

Re: Brand new edge overlay. Please test.

« Reply #35 on: 28 / August / 2010, 16:52:21 »

Quote from: whoever on 28 / August / 2010, 10:40:04

How about using raw buffer to satisfy your memory needs without compression/decompression? Large chunk of memory, free most of the time... Just an idea -- I haven't tried anything such.

AFAIK the camera already uses it for other purposes when it isn't being used for raw data. You would have to actually allocate the memory from the EXMEM system if you to be sure it will stay untouched. AFAIK Ewavr has successfully used large chunks of EMMEM_RAMDISK without serious problems.

Logged

Don't forget what the H stands for.

NormanA

Re: Brand new edge overlay. Please test.

« Reply #36 on: 02 / September / 2010, 00:25:24 »

I am using it on my SD790, works great, great work. :-)

Logged