Brand new edge overlay. Please test. - General Discussion and Assistance - CHDK Forum
« previous next »
Pages: [1] 2 3 4   Go Down

Brand new edge overlay. Please test.

  • 36 Replies
  • 25492 Views
*

Offline ultimA

  • ***
  • 137
Brand new edge overlay. Please test.
« on: 22 / August / 2010, 06:22:16 »
Advertisements
« Last Edit: 29 / August / 2010, 11:17:54 by ultimA »
Logged
*

Offline neszt

  • ***
  • 174
Re: Brand new edge overlay. Please test.
« Reply #1 on: 22 / August / 2010, 10:27:42 »
Sounds good, but i can't access the diff (The file you are trying to access is temporarily unavailable)

Edit: While don't you attach a zipped source-diff to your post?
Logged
*

Offline zeno

  • *****
  • 891
Re: Brand new edge overlay. Please test.
« Reply #2 on: 22 / August / 2010, 10:32:05 »
Download worked for me
Logged
A570, S100, Ixus 127
Author of ASSIST, STICK, WASP, ACID, SDMInst, LICKS, WICKS, MacBoot, UBDB, CFGEdit
*

Offline neszt

  • ***
  • 174
Re: Brand new edge overlay. Please test.
« Reply #3 on: 22 / August / 2010, 12:28:42 »
Download the patch worked for me also from another computer. Interested..

I tested your new-edge detection on my SX20 IS firmware version 1.00F, with the following result:

1. The new edge-detect is works continuously when i press half the shoot button. (the old worked only when i released the half-shoot) Therefore it's looks like faster. :)

2. The save crashes the camera (the old worked well)

3. The filter option works very well! (gives fine result on noisy scenes)

Keep up the good work!
Logged
*

Offline ultimA

  • ***
  • 137
Re: Brand new edge overlay. Please test.
« Reply #4 on: 22 / August / 2010, 13:43:41 »
Quote from: neszt on 22 / August / 2010, 12:28:42
1. The new edge-detect is works continuously when i press half the shoot button. (the old worked only when i released the half-shoot) Therefore it's looks like faster. :)
Do you like the new behavior or should I change back? I decided to only display the edge overlay when the shutter is half-pressed because else it overwrites everything on the screen. This way you can reenable other OSD elements by simply releasing the button. But if you people like the old behavior better, I can change it back.

Quote from: neszt on 22 / August / 2010, 12:28:42
2. The save crashes the camera (the old worked well)
Thx for reporting and testing. I fixed it now and the diff file in the original post is updated with the fix. It doesn't crash now.
Logged
*

Offline ultimA

  • ***
  • 137
Re: Brand new edge overlay. Please test.
« Reply #5 on: 22 / August / 2010, 14:02:07 »
Quote from: neszt on 22 / August / 2010, 10:27:42
Edit: While don't you attach a zipped source-diff to your post?

I'd be glad to, but I cannot find how, I see no option for it. Can you help me?
Logged
*

Offline reyalp

  • ******
  • 14140
Re: Brand new edge overlay. Please test.
« Reply #6 on: 22 / August / 2010, 15:16:27 »
I think attachments got turned off in the last round of forum problems.

edit: nice work too :)
Logged
Don't forget what the H stands for.
*

Offline NewbieToobie

  • ***
  • 102
Re: Brand new edge overlay. Please test.
« Reply #7 on: 22 / August / 2010, 17:12:25 »
Does this "continuous" mode display the edges in real-time? If so ... this will be a boon to all macrophotographers. Something similar was implemented in early Sony cameras. As a way to detect which edges are in sharp focus, highlighting them. I use a similar principle for manual focus for macro-photography. Whatever pixels in the EVF are scintillating with slight movement of the camera, I know those edges, areas, and textures are in sharp focus.

Logged
*

Offline neszt

  • ***
  • 174
Re: Brand new edge overlay. Please test.
« Reply #8 on: 22 / August / 2010, 17:32:16 »
Quote from: ultimA on 22 / August / 2010, 13:43:41
Do you like the new behavior or should I change back? I decided to only display the edge overlay when the shutter is half-pressed because else it overwrites everything on the screen. This way you can reenable other OSD elements by simply releasing the button. But if you people like the old behavior better, I can change it back.
No, i am not an edge-detect user, so i just noticed this change. However it seems better than before. (looks more user friendly)

Quote
Thx for reporting and testing. I fixed it now and the diff file in the original post is updated with the fix. It doesn't crash now.

Now, i can't save, because the edge data disappears where i press the menu button, so no overlay to save.

P.s.: If you make diff, try to step one directory inner, so your diff should begin with

Code: [Select]
Index: include/conf.h
===================================================================
--- include/conf.h      (revision 924)
+++ include/conf.h      (working copy)
@@ -250,11 +250,12 @@
     int mute_on_zoom;
     int bad_pixel_removal;
     int video_af_key;
-
+

instead of

Code: [Select]
Index: chdk/include/conf.h
===================================================================
--- chdk/include/conf.h (revision 924)
+++ chdk/include/conf.h (working copy)
@@ -250,11 +250,12 @@
     int mute_on_zoom;
     int bad_pixel_removal;
     int video_af_key;
-   
+
Logged
*

Offline ultimA

  • ***
  • 137
Re: Brand new edge overlay. Please test.
« Reply #9 on: 22 / August / 2010, 17:45:00 »
Quote from: NewbieToobie on 22 / August / 2010, 17:12:25
Does this "continuous" mode display the edges in real-time? If so ... this will be a boon to all macrophotographers. Something similar was implemented in early Sony cameras. As a way to detect which edges are in sharp focus, highlighting them. I use a similar principle for manual focus for macro-photography. Whatever pixels in the EVF are scintillating with slight movement of the camera, I know those edges, areas, and textures are in sharp focus.

I was already thinking about a menu option that would make the overlay display continuously on the screen without having to press the shutter button. So this seems like a good suggestion. However, I personally do not think that that this edge overlay is suitable for focus adjustments. This is because the edges drawn are too thick. I use it for panoramas and stereo photographing, not for macrophotography. Maybe, if you could try out the patch, can you tell me if it's suitable for the macro-users?

The whole reason I opened this topic is because I want to perfect the patch before submitting it for inclusion in the trunk. If you have *any* suggestions, please don't hesitate to post.
« Last Edit: 22 / August / 2010, 17:51:28 by ultimA »
Logged
Pages: [1] 2 3 4   Go Up
« previous next »
 

Related Topics


SimplePortal © 2008-2014, SimplePortal