Disable Display Off Always Option added - patch file included - General Discussion and Assistance

atalwar

Disable Display Off Always Option added - patch file included

« on: 21 / November / 2010, 17:29:21 »

Advertisements

I Have added an Option "Yes" to Disable LCD OFF so that even in non 'alt' mode manual focus in not lost after 3 mins of inactivity.
This way one can shoot from hip without worrying about losing MF mode (i.e fixed to hyperfocal).
It also allows for playing with the scene (macro in my case between shots, and not lose the focus).

The Diff patch file is attached. Kindly check and include in future builds if feasible.
I have compiled and tested it

983_display_off_option_patch.diff (2.01 kB - downloaded 118 times.)

Logged

atalwar

Re: Disable Display Off Always Option added - patch file included

« Reply #1 on: 22 / November / 2010, 09:44:05 »

can mods/gurus acknowledge this post? am i posting in wrong forum?

I did't put into my camera specific post as this is a generic update.

If for some reason this solution is deemed unsuitable to masses, kindly let me know so i can atleast host my build version (g11 100L) for those who might need this capability.

Thank you.

« Last Edit: 22 / November / 2010, 09:53:53 by atalwar »

Logged

reyalp

13359

Re: Disable Display Off Always Option added - patch file included

« Reply #2 on: 22 / November / 2010, 12:24:21 »

Quote from: atalwar on 22 / November / 2010, 09:44:05

can mods/gurus acknowledge this post? am i posting in wrong forum?

This is the correct forum. Haven't had a chance to look at it.

Logged

Don't forget what the H stands for.

reyalp

13359

Re: Disable Display Off Always Option added - patch file included

« Reply #3 on: 26 / November / 2010, 21:54:37 »

This will not work correctly if the value 'Yes' is saved in conf and you start the camera but don't ever go into alt mode. Probably want to add a setter func to conf.c

Also, how about 'Always' / 'Never' instead of 'Yes' / 'No' ?

Logged

Don't forget what the H stands for.

atalwar

Re: Disable Display Off Always Option added - patch file included

« Reply #4 on: 27 / November / 2010, 13:20:50 »

I agree with the naming convention of "never" and "always", however, it already had "no" in there, so i went with the previous convention.

I have made the modifications to the code. and added the setter in conf.c

However i feel that to avoid some confusion, the label "Disable lcd off" should be changed to something more meaningful like "Prevent Auto Shutdown" or "Disable Auto Shutdown".

attached is an updated diff file tested with the latest build 985.

patch.diff (3.46 kB - downloaded 92 times.)

« Last Edit: 27 / November / 2010, 13:36:09 by atalwar »

Logged

reyalp

13359

Re: Disable Display Off Always Option added - patch file included

« Reply #5 on: 27 / November / 2010, 19:08:24 »

I've checked this in, with some changes so all the logic to figure out if power saving should be disabled or not is in one place.

Logged

Don't forget what the H stands for.