SD990 - page 21 - DryOS Development - CHDK Forum supplierdeeply
« previous next »
Pages: 1 ... 16 17 18 19 20 [21]   Go Down

SD990

  • 206 Replies
  • 76730 Views
*

Offline nafraf

  • *****
  • 1308
Re: SD990
« Reply #200 on: 28 / October / 2014, 00:08:03 »
Advertisements
Thanks. Changes committed to trunk. Changeset 3698.

I'd like to post patches for ixus95_sd1200 and a1100, could you check palettes, active_palette_buffer values and post to the corresponding porting threads?
Logged
*

Offline koshy

  • *****
  • 1086
Re: SD990
« Reply #201 on: 28 / October / 2014, 20:45:55 »
Quote from: nafraf on 28 / October / 2014, 00:08:03
I'd like to post patches for ixus95_sd1200 and a1100, could you check palettes, active_palette_buffer values and post to the corresponding porting threads?
Sure, I did.
Logged
Koshy had a little ELPH which wasn't white as snow but everywhere that Koshy went the ELPH was sure to go. (actually an SD, but that detail ruins the rhyme...)
*

Offline koshy

  • *****
  • 1086
Re: SD990
« Reply #202 on: 02 / November / 2014, 07:43:04 »
Quote from: nafraf on 28 / October / 2014, 00:08:03
Thanks. Changes committed to trunk. Changeset 3698.

I'd like to post patches for ixus95_sd1200 and a1100, could you check palettes, active_palette_buffer values and post to the corresponding porting threads?
In trunk 3708 this is broken again for IXUS 980. I'll post screen shots of the palette later. I'll also re-check A1100 and IXUS 95 which we worked on at the same time if the situation also applies to them.
Logged
Koshy had a little ELPH which wasn't white as snow but everywhere that Koshy went the ELPH was sure to go. (actually an SD, but that detail ruins the rhyme...)
*

Offline koshy

  • *****
  • 1086
Re: SD990
« Reply #203 on: 02 / November / 2014, 12:09:08 »
Quote from: koshy on 02 / November / 2014, 07:43:04
In trunk 3708 this is broken again for IXUS 980. I'll post screen shots of the palette later. I'll also re-check A1100 and IXUS 95 which we worked on at the same time if the situation also applies to them.
A1100 also has a problem I'll post on it's thread and IXUS 95 was fine.

It might be interesting to check what happened between Changeset 3698 and 3708 that broke this. I guess 3706 did. And to ponder if any of the other previously working cameras with custom colors would be affected. I think I could test some of them but I don't have all.

In CHDKPTP all works as before but on the camera it does not.
« Last Edit: 02 / November / 2014, 12:12:17 by koshy »
Logged
Koshy had a little ELPH which wasn't white as snow but everywhere that Koshy went the ELPH was sure to go. (actually an SD, but that detail ruins the rhyme...)
*

Offline philmoz

  • *****
  • 3387
    • Photos
Re: SD990
« Reply #204 on: 02 / November / 2014, 13:49:57 »
Quote from: koshy on 02 / November / 2014, 12:09:08
Quote from: koshy on 02 / November / 2014, 07:43:04
In trunk 3708 this is broken again for IXUS 980. I'll post screen shots of the palette later. I'll also re-check A1100 and IXUS 95 which we worked on at the same time if the situation also applies to them.
A1100 also has a problem I'll post on it's thread and IXUS 95 was fine.

It might be interesting to check what happened between Changeset 3698 and 3708 that broke this. I guess 3706 did. And to ponder if any of the other previously working cameras with custom colors would be affected. I think I could test some of them but I don't have all.

In CHDKPTP all works as before but on the camera it does not.

In revision 3698 this line:
Code: [Select]
    extern char** palette_buffer_ptr;
was changed to:
Code: [Select]
    extern int** palette_buffer_ptr;
I think the new (second) version is wrong as it causes the offset added in the next line to be multiplied by 4. I think this is why the palette sent to chdkptp is wrong.

Phil.

Logged
CHDK ports:
  sx30is (1.00c, 1.00h, 1.00l, 1.00n & 1.00p)
  g12 (1.00c, 1.00e, 1.00f & 1.00g)
  sx130is (1.01d & 1.01f)
  ixus310hs (1.00a & 1.01a)
  sx40hs (1.00d, 1.00g & 1.00i)
  g1x (1.00e, 1.00f & 1.00g)
  g5x (1.00c, 1.01a, 1.01b)
  g7x2 (1.01a, 1.01b, 1.10b)
*

Offline koshy

  • *****
  • 1086
Re: SD990
« Reply #205 on: 04 / November / 2014, 12:27:45 »
Quote from: nafraf on 03 / November / 2014, 20:17:40
For ixus980, please test philmoz suggestion:
Code: [Select]
Index: platform/ixus980_sd990/lib.c
===================================================================
--- platform/ixus980_sd990/lib.c (revision 3716)
+++ platform/ixus980_sd990/lib.c (working copy)
@@ -108,6 +108,6 @@
 void *vid_get_bitmap_active_palette()
 {
     extern int active_palette_buffer;
-    extern int** palette_buffer_ptr;
+    extern char** palette_buffer_ptr;
     return (palette_buffer_ptr[active_palette_buffer]+16);
 }
That change was not included in posted patch, probably I added that bug before committing the patch.
I tested this today and it woks just fine when it's a char** again.
A1100 also needs to be checked, there was a problem with it, too.

@philmoz: Thank you very much.
Logged
Koshy had a little ELPH which wasn't white as snow but everywhere that Koshy went the ELPH was sure to go. (actually an SD, but that detail ruins the rhyme...)
*

Offline nafraf

  • *****
  • 1308
Re: SD990
« Reply #206 on: 04 / November / 2014, 20:47:26 »
Patch commited to trunk, changeset 3718. Thanks
Logged
Pages: 1 ... 16 17 18 19 20 [21]   Go Up
« previous next »
 

Related Topics