Comments on the patch from http://chdk.setepontos.com/index.php?topic=650.msg59036#msg59036Some of this is for g12 as well, but I don't want a bunch of discussion in the sticky threadfor viewport buffer width, can we have a weak default function that just returns viewport width, and allows the cams that need it to override ? Would be nice to have less ifdefs scattered around the code. Looks like some places would still need extra code, e.g. histogram.On the AF video key, would be (gui.c gui_video_af_key_enum) would be nice to not have the camera specific ifdefs, but we really need a generic way of specifying which keys cameras have.In raw.c:What's the deal with the gamma special case for these cams?The double buffer raw code is also a bit ifdef spaghetti, not clear how to make it cleaner.In kbd.h/kbd.c new keys are added, but they aren't added to keyid_by_name, so script won't be able to use them. Intentional ? I haven't really looked at the implications of adding new keys.
Thanks for taking the time to review and comment, really appreciated.I'll take a look at the viewport stuff and see if I can clean it up (not sure about the weak function concept, will do some research).
I'm not too keen on all the #ifdef code; but I couldn't see a way to do it without breaking all the existing code.I've got even more coming up - I'm trying to fix the variable size viewport and screen buffer window for the different image sizes (G12 has 4:3, 3:2, 1:1, 4:5 and 16:9 image sizes). Will try and do this as cleanly as possible.
The raw gamma was my attempt to improve the DNG thumbnail generation which was really bad on the SX30. This give a slight boost to darker shades and gives me a slightly better DNG thumbnail on both cameras. Happy to lose it if you want.
Does anyone have a download link for sx30 100e dump somwhere ?
So has no progress been made past a BETA version? That seems to be all I can locate for the SX30.
Started by kandrews
« 1 2 3 4 »
Started by philmoz
« 1 2 ... 28 29 »
Started by markoneswift
Started by hulland
« 1 2 3 4 »
Hello, I'm a NEWBIE - HELP!! (Newbies assistance, User Guides and thank you notes)
Started by speedlite
« 1 2 »