Multiple Bug's (Live View / Zoom / Shoot) - page 8 - General Discussion and Assistance - CHDK Forum

Multiple Bug's (Live View / Zoom / Shoot)

  • 76 Replies
  • 2247 Views
*

Offline srsa_4c

  • ******
  • 4000
Re: Multiple Bug's (Live View / Zoom / Shoot)
« Reply #70 on: 13 / October / 2019, 14:02:50 »
Advertisements
:( What happened between...?
Effectively nothing, both ztest5 and ztest6 have this:
Code: [Select]
Index: platform/sx210is/platform_camera.h
===================================================================
--- platform/sx210is/platform_camera.h (revision 5278)
+++ platform/sx210is/platform_camera.h (working copy)
@@ -107,6 +107,10 @@
 
     #define CAM_AV_OVERRIDE_IRIS_FIX        1
 
+    #define CAM_USE_OPTICAL_MAX_ZOOM_STATUS 1   // Use ZOOM_OPTICAL_MAX to reset zoom_status when switching from digital to optical zoom in gui_std_kbd_process()
+    #define CAM_USE_ALT_SET_ZOOM_POINT      1    // Define to use the alternate code in lens_set_zoom_point()
+    #define CAM_USE_ALT_PT_MoveOpticalZoomAt 1    // Define to use the PT_MoveOpticalZoomAt() function in lens_set_zoom_point()
+
     #define CAM_SD_OVER_IN_AFL              1
     #define CAM_SD_OVER_IN_MF               1
So, you should not be seeing distortion after set_zoom.

*

Offline Caefix

  • *
  • 40
  • Sorry, busy deleting test shots...
Re: Multiple Bug's (Live View / Zoom / Shoot)
« Reply #71 on: 13 / October / 2019, 15:31:14 »
 ;)    :( <> :)
Of course I don´t see distortion...
but cam does after swapping ztest5 & 6folder. (Sx210)
& no numbers never. What else could trouble ztest6zip?

++ added shoot() option to ook out for all? that zoom & focus traps.


shooting.c line 41
typedef struct {
    short av96;
    short tv96;
    short sv96;
    short subj_dist; // should´t such values be int for newer /hizoom cams?
    short nd_filter;
} PHOTO_PARAM;
« Last Edit: 13 / October / 2019, 16:00:30 by Caefix »
All lifetime is a loan from eternity.

*

Offline srsa_4c

  • ******
  • 4000
Re: Multiple Bug's (Live View / Zoom / Shoot)
« Reply #72 on: 13 / October / 2019, 15:39:41 »
but cam does after swapping ztest5 & 6folder. (Sx210)
& no numbers never. What else could trouble ztest6zip?
You should only swap the diskboot.bin file in the card root. The CHDK folder on card can remain as is.
If you don't see the 0:0 display, you're not using the latest test build.

*

Offline reyalp

  • ******
  • 12104
Re: Multiple Bug's (Live View / Zoom / Shoot)
« Reply #73 on: 13 / October / 2019, 22:25:09 »
This isn't due to your code, but both SX710 and G7X crash after set_zoom in video mode, unless MF or AF lock is set. They appear to be in continuous AF (propcase is 1), with no option to disable it outside of MF/AF Lock. shooting_can_focus has an exception that always allows SD over in movie mode, regardless of the propcase.
I poked at this a bit more.

sx160 also sets continuous AF propcase in video mode.

However, if video recording is started in still mode with the video button, these cameras effectively still do cont AF (sd continually changing) but the cont AF propcase reflects whatever the setting is for the still mode. The same is true for elph130 and elph180, which don't have a dedicated video mode.
For all of these, zoom and sd override work fine while recording if MF is set.

D10 doesn't appear to do cont AF in video. It doesn't have a cont AF firmware option, but does do it (and sets the propcase) in AUTO. Starting video in AUTO turns the propcase off.

I guess an extra check in shooting_set_zoom() could help with that.
I think it probably belongs in shooting_can_focus(). The existing video mode check there is clearly wrong (this was recognized when the code was refactored to its current state, hence the fixme) but the question is what should replace it.

I think just taking the check out would be an improvement. The cont AF check should be correct for dedicated video modes, and the MF / AF lock logic is probably valid for most cams, if not all: that is, if a camera can SD over in MF for stills, it can probably do it in video MF as well.

That leaves cameras that implicitly set cont AF without setting the propcase while recording. I suspect all but quite old cameras do this. We could have a define like CAM_VIDEO_AF_IS_CONT, and default it on for Dry 39 and newer or something like that.
Don't forget what the H stands for.


*

Offline Caefix

  • *
  • 40
  • Sorry, busy deleting test shots...
Re: Multiple Bug's (Live View / Zoom / Shoot)
« Reply #74 on: Yesterday at 10:16:10 »
 :(::) :xmas
Touchdown Sx230!
Numbers! The right one is counting & No distortion!
The finally found trick was : Making SD bootable, set sd lock & run it.
Booting ztest6 is other then update method, where numbers are gone or disappear after fwUpdate.

SX50 ,1. impression. Making SD bootable on cam...
The usual FocusLensController-romlogs...
using autozum leads to counting right with the !MF setting. No )( !

SX210  :o : :blink:  :-X
Getting that booting... from formatting on...
Surprisingly the first but seldom counts for the hometeam ~(x:xyz).
There´s a different behaviour/stability between testing click "shoot_half" and shoot() in autozum6.lua.
More fouls on the left...
&&!! no )( after booting, but upper ))(( scenario follows fwUpdate.
Other/repeating tests follow...
« Last Edit: Yesterday at 13:17:21 by Caefix »
All lifetime is a loan from eternity.

*

Offline srsa_4c

  • ******
  • 4000
Re: Multiple Bug's (Live View / Zoom / Shoot)
« Reply #75 on: Yesterday at 12:02:07 »
We could have a define like CAM_VIDEO_AF_IS_CONT, and default it on for Dry 39 and newer or something like that.
FWIW, a3200 (r47) doesn't have continuous focus during video recording.

The finally found trick was : Making SD bootable, set sd lock & run it.
Yeah, I forgot to specifically mention that the test builds only support autoboot (did not provide .fi2 files).

Quote
Numbers! The right one is counting & No distortion!
(...)
SX50
(...)
using autozum leads to counting right with the !MF setting.
Strange, you're the first to see those numbers increment. But, it's possible that we'll have a new method for zooming, soon.

Your bugreport* seems valid, please post it here so it doesn't get forgotten.

edit:
* this one
shooting.c line 41
typedef struct {
    short av96;
    short tv96;
    short sv96;
    short subj_dist; // should´t such values be int for newer /hizoom cams?
    short nd_filter;
} PHOTO_PARAM;
« Last Edit: Yesterday at 13:43:05 by srsa_4c »

*

Offline reyalp

  • ******
  • 12104
Re: Multiple Bug's (Live View / Zoom / Shoot)
« Reply #76 on: Yesterday at 23:30:12 »
FWIW, a3200 (r47) doesn't have continuous focus during video recording.
Figures it isn't that simple.
Quote
Your bugreport* seems valid, please post it here so it doesn't get forgotten.
That's a good catch, I'm looking into it. Bracketing related SD values are also shorts.

edit:
Checked in, trunk 5729. I'll merge it to stable if no one sees problems.

This would mainly have affected SD override in AF, when MF or AF Lock was used, it would pass the integer values. Bracketing would also be affected. Prior to fixing, I was able to observe incorrect behavior on elph180, setting SD = 70000 would result in ~4400 being set.
« Last Edit: Today at 01:05:45 by reyalp »
Don't forget what the H stands for.

 

Related Topics