Adding new cameras, applying patches into trunk (with source code prepared) - page 102 - General Discussion and Assistance - CHDK Forum

Adding new cameras, applying patches into trunk (with source code prepared)

  • 1685 Replies
  • 859260 Views
*

Offline nafraf

  • *****
  • 1308
Re: Adding new cameras, applying patches into trunk (with source code prepared)
« Reply #1010 on: 23 / February / 2013, 16:48:38 »
Advertisements
a2300, a3400, a810, a1300: makefile.inc. Patch to fix comments of how EXMEM_HEAP_SKIP was obtained.
a2300: unused variables deleted


*

Offline philmoz

  • *****
  • 3450
    • Photos
Re: Adding new cameras, applying patches into trunk (with source code prepared)
« Reply #1011 on: 23 / February / 2013, 22:04:03 »
a2300, a3400, a810, a1300: makefile.inc. Patch to fix comments of how EXMEM_HEAP_SKIP was obtained.
a2300: unused variables deleted



Added in revision 2593 (trunk) and 2594 (release-1.1).

Phil.
CHDK ports:
  sx30is (1.00c, 1.00h, 1.00l, 1.00n & 1.00p)
  g12 (1.00c, 1.00e, 1.00f & 1.00g)
  sx130is (1.01d & 1.01f)
  ixus310hs (1.00a & 1.01a)
  sx40hs (1.00d, 1.00g & 1.00i)
  g1x (1.00e, 1.00f & 1.00g)
  g5x (1.00c, 1.01a, 1.01b)
  g7x2 (1.01a, 1.01b, 1.10b)

*

Offline srsa_4c

  • ******
  • 4451
Re: Adding new cameras, applying patches into trunk (with source code prepared)
« Reply #1012 on: 24 / February / 2013, 17:33:25 »
For vxworks, we need to find sys_mempart_id, which I haven't finished doing for all cameras. Baring typos, I think to should be safe to turn on for all that have been found.
From a quick look, sys_mempart_id could be found by looking at an eventproc named "memShow" which is a wrapper for memPartShow. The latter needs sys_mempart_id as its first param.
Done. I have also verified the already found values (A, G series) except for a570 101a (that dump seems to be missing from the "collection"). Patch attached, enables CAM_FIRMWARE_MEMINFO  for all VxWorks ports which support it.
I chose not to commit this without consent, as it has impact on many ports and the only one I can test is the Ixus65.

Perhaps add the stubs_min.S values with a comment that it is untested and to enable the option in platform_camera.h to test.
Add the values in platform_camera.h commented out with instructions to enable & test.

That way the info is not lost; but won't break any existing ports.

Phil.
I don't think there are many people out there who compile CHDK from source. Probably even less who look into the source before. And probably only a fraction of those will ever mess with an old (= VxWorks) camera.
My main concern about enabling CAM_FIRMWARE_MEMINFO for all Vx ports is that I have not verified the memPartInfoGet function for most of them. That said, the sigfinder appears to be 100% certain about its address in all cases.
Memory information is used (I may have missed something):
- when someone clicks on that menu entry
- from Lua (get_meminfo)
- in PTP, performance is horrible without it

*

Offline reyalp

  • ******
  • 14128
Re: Adding new cameras, applying patches into trunk (with source code prepared)
« Reply #1013 on: 24 / February / 2013, 17:55:03 »
My main concern about enabling CAM_FIRMWARE_MEMINFO for all Vx ports is that I have not verified the memPartInfoGet function for most of them. That said, the sigfinder appears to be 100% certain about its address in all cases.
I think I missed this discussion the first time around. IMO, enabling something based on 100% sig finder match, and manual spot checks on a few ports is OK. I enabled it for all dryos cams in the trunk on the same basis.
Don't forget what the H stands for.

Re: Adding new cameras, applying patches into trunk (with source code prepared)
« Reply #1014 on: 24 / February / 2013, 17:57:29 »
And probably only a fraction of those will ever mess with an old (= VxWorks) camera.
My guess is that the fraction of all the people who use CHDK and mess with old (= VxWorks) cameras is probably just one person.
Ported :   A1200    SD940   G10    Powershot N    G16

*

Offline srsa_4c

  • ******
  • 4451
Re: Adding new cameras, applying patches into trunk (with source code prepared)
« Reply #1015 on: 24 / February / 2013, 18:04:13 »
I think I missed this discussion the first time around. IMO, enabling something based on 100% sig finder match, and manual spot checks on a few ports is OK. I enabled it for all dryos cams in the trunk on the same basis.
OK, I will check 1-2 firmware out of each "generation", then I'll risk the commit...
And probably only a fraction of those will ever mess with an old (= VxWorks) camera.
My guess is that the fraction of all the people who use CHDK and mess with old (= VxWorks) cameras is probably just one person.
8)

Re: Adding new cameras, applying patches into trunk (with source code prepared)
« Reply #1016 on: 24 / February / 2013, 20:50:42 »
Small fix for the A1200 - stable & unstable branch.   Per this post : http://chdk.setepontos.com/index.php?topic=9482.msg97203#msg97203  it appears that shooting_get_prop(PROPCASE_ASPECT_RATIO) very occassionally returns a value out of the expected 0-3 range.  The code was returning the same value regardless when the value was in range so I just locked it there.
Ported :   A1200    SD940   G10    Powershot N    G16

*

Offline philmoz

  • *****
  • 3450
    • Photos
Re: Adding new cameras, applying patches into trunk (with source code prepared)
« Reply #1017 on: 25 / February / 2013, 04:29:23 »
Small fix for the A1200 - stable & unstable branch.   Per this post : http://chdk.setepontos.com/index.php?topic=9482.msg97203#msg97203  it appears that shooting_get_prop(PROPCASE_ASPECT_RATIO) very occassionally returns a value out of the expected 0-3 range.  The code was returning the same value regardless when the value was in range so I just locked it there.


Added in revisions 2598 (trunk) and 2599 (release-1.1).

Phil.
CHDK ports:
  sx30is (1.00c, 1.00h, 1.00l, 1.00n & 1.00p)
  g12 (1.00c, 1.00e, 1.00f & 1.00g)
  sx130is (1.01d & 1.01f)
  ixus310hs (1.00a & 1.01a)
  sx40hs (1.00d, 1.00g & 1.00i)
  g1x (1.00e, 1.00f & 1.00g)
  g5x (1.00c, 1.01a, 1.01b)
  g7x2 (1.01a, 1.01b, 1.10b)

*

Offline nafraf

  • *****
  • 1308
a2300 100c port (ALPHA)
tested by akiro021 and mainakm

EDIT: I posted the patch again, to include changes in camera_list.csv.
« Last Edit: 01 / March / 2013, 19:48:05 by nafraf »

*

Offline philmoz

  • *****
  • 3450
    • Photos
a2300 100c port (ALPHA)
tested by akiro021 and mainakm

EDIT: I posted the patch again, to include changes in camera_list.csv.

Added in revision 2608 (trunk) and 2609 (release-1.1).

Phil.
CHDK ports:
  sx30is (1.00c, 1.00h, 1.00l, 1.00n & 1.00p)
  g12 (1.00c, 1.00e, 1.00f & 1.00g)
  sx130is (1.01d & 1.01f)
  ixus310hs (1.00a & 1.01a)
  sx40hs (1.00d, 1.00g & 1.00i)
  g1x (1.00e, 1.00f & 1.00g)
  g5x (1.00c, 1.01a, 1.01b)
  g7x2 (1.01a, 1.01b, 1.10b)

 

Related Topics


SimplePortal © 2008-2014, SimplePortal