supplierdeeply

Adding new cameras, applying patches into trunk (with source code prepared)

  • 1484 Replies
  • 194360 Views
*

Online blackhole

  • ****
  • 469
  • A590IS 101b
    • Planetary astrophotography
Re: Adding new cameras, applying patches into trunk (with source code prepared)
« Reply #1480 on: 04 / January / 2017, 04:06:55 »
Advertisements
SX410_100c NR_hook patch.
Related with this discussion.

EDIT:Patch is replaced.
« Last Edit: 04 / January / 2017, 14:33:59 by blackhole »

*

Offline srsa_4c

  • ******
  • 3316
Re: Adding new cameras, applying patches into trunk (with source code prepared)
« Reply #1481 on: 04 / January / 2017, 20:58:43 »
SX410_100c NR_hook patch.
Related with this discussion.

EDIT:Patch is replaced.
Thanks. Committed with some modifications (moved the hooks closer to sub_FF9B4AF8 where the nr flag is evaluated).

change to allow user enable/disable of RAW toggle keyboard shortcut
« Reply #1482 on: 07 / January / 2017, 16:10:22 »
Attached is a small patch to allow user activation/deactivation of the RAW toggle keyboard shortcut. 

This removes a major annoyance that happens when RAW is accidentally enabled by unknowingly pressing the secret RAW toggle shortcut key in shooting mode.

The patch allows three choices :
  • RAW toggle short cut key disabled
  • RAW toggle short cut key enabled
  • RAW toggle short cut key enabled and RAW OSD indicator activated when the toggle occurs

The third option is a handy way to remember that you have enabled RAW (other than finding out when your memory card fills up really quickly).

I chose option 0 (Off) to be the default.  This is a change from the  current CHDK operation but I think it's the correct option as this "feature" is better disabled unless you consciously select it.

edit :  fixed comment about default option = 1 (should have been 0).
« Last Edit: 07 / January / 2017, 23:02:05 by waterwingz »

*

Offline reyalp

  • ******
  • 10244
Re: change to allow user enable/disable of RAW toggle keyboard shortcut
« Reply #1483 on: 07 / January / 2017, 22:53:49 »
Attached is a small patch to allow user activation/deactivation of the RAW toggle keyboard shortcut. 
Nice. Checked in, trunk r4751.

Quote
This is a change from the  current CHDK operation but I think it's the correct option as this "feature" is better disabled unless you consciously select it.
I agree with having it disabled by default. It's a behavior change, but far less likely to frustrate new users.

I'm not entirely fond of tying in the OSD, since the OSD only shows when raw is enabled anyway, but I do see the logic of ensuring the OSD shows when you use the shortcut, so I left it in for now.
Don't forget what the H stands for.


Re: change to allow user enable/disable of RAW toggle keyboard shortcut
« Reply #1484 on: 07 / January / 2017, 22:59:14 »
I'm not entirely fond of tying in the OSD, since the OSD only shows when raw is enabled anyway, but I do see the logic of ensuring the OSD shows when you use the shortcut, so I left it in for now.
Understood. 

Another limitation is that it does nothing if the OSD is not enabled. So you get no warning even though you might have believed you'd selected a "warning" option.

So it's not perfect but then again, a user does not have to enable it. And compared to many of he other "historical" secret shortcut keys I updated the documented for in the CHDK 1.4.0 manual today, it's pretty innocuous.

 

Related Topics