supplierdeeply

Adding new cameras, applying patches into trunk (with source code prepared)

  • 1581 Replies
  • 234276 Views
*

Offline blackhole

  • *****
  • 518
  • A590IS 101b
    • Planetary astrophotography
Re: Adding new cameras, applying patches into trunk (with source code prepared)
« Reply #1480 on: 04 / January / 2017, 04:06:55 »
Advertisements
SX410_100c NR_hook patch.
Related with this discussion.

EDIT:Patch is replaced.
« Last Edit: 04 / January / 2017, 14:33:59 by blackhole »

*

Offline srsa_4c

  • ******
  • 3466
Re: Adding new cameras, applying patches into trunk (with source code prepared)
« Reply #1481 on: 04 / January / 2017, 20:58:43 »
SX410_100c NR_hook patch.
Related with this discussion.

EDIT:Patch is replaced.
Thanks. Committed with some modifications (moved the hooks closer to sub_FF9B4AF8 where the nr flag is evaluated).

change to allow user enable/disable of RAW toggle keyboard shortcut
« Reply #1482 on: 07 / January / 2017, 16:10:22 »
Attached is a small patch to allow user activation/deactivation of the RAW toggle keyboard shortcut. 

This removes a major annoyance that happens when RAW is accidentally enabled by unknowingly pressing the secret RAW toggle shortcut key in shooting mode.

The patch allows three choices :
  • RAW toggle short cut key disabled
  • RAW toggle short cut key enabled
  • RAW toggle short cut key enabled and RAW OSD indicator activated when the toggle occurs

The third option is a handy way to remember that you have enabled RAW (other than finding out when your memory card fills up really quickly).

I chose option 0 (Off) to be the default.  This is a change from the  current CHDK operation but I think it's the correct option as this "feature" is better disabled unless you consciously select it.

edit :  fixed comment about default option = 1 (should have been 0).
« Last Edit: 07 / January / 2017, 23:02:05 by waterwingz »
Ported : A1200  SD940  G10  Powershot N  G16*

*

Offline reyalp

  • ******
  • 10921
Re: change to allow user enable/disable of RAW toggle keyboard shortcut
« Reply #1483 on: 07 / January / 2017, 22:53:49 »
Attached is a small patch to allow user activation/deactivation of the RAW toggle keyboard shortcut. 
Nice. Checked in, trunk r4751.

Quote
This is a change from the  current CHDK operation but I think it's the correct option as this "feature" is better disabled unless you consciously select it.
I agree with having it disabled by default. It's a behavior change, but far less likely to frustrate new users.

I'm not entirely fond of tying in the OSD, since the OSD only shows when raw is enabled anyway, but I do see the logic of ensuring the OSD shows when you use the shortcut, so I left it in for now.
Don't forget what the H stands for.


Re: change to allow user enable/disable of RAW toggle keyboard shortcut
« Reply #1484 on: 07 / January / 2017, 22:59:14 »
I'm not entirely fond of tying in the OSD, since the OSD only shows when raw is enabled anyway, but I do see the logic of ensuring the OSD shows when you use the shortcut, so I left it in for now.
Understood. 

Another limitation is that it does nothing if the OSD is not enabled. So you get no warning even though you might have believed you'd selected a "warning" option.

So it's not perfect but then again, a user does not have to enable it. And compared to many of he other "historical" secret shortcut keys I updated the documented for in the CHDK 1.4.0 manual today, it's pretty innocuous.
Ported : A1200  SD940  G10  Powershot N  G16*

Here is a SX60HS patch for v4785. It standardizes the loader code,  changes the direction of the jogdial, and adds CAM_QUALITY_OVERRIDE.

*

Offline reyalp

  • ******
  • 10921
Here is a SX60HS patch for v4785. It standardizes the loader code,  changes the direction of the jogdial, and adds CAM_QUALITY_OVERRIDE.
Thanks. Added in trunk 4786

A couple questions:
* Usually, we add CAM_QUALITY_OVERRIDE for cameras that don't expose "super fine" in the Canon UI. According the manual, the SX60 has "Fine" and "Super Fine", but not "Normal". Are the PROPACASE_QUALITY values set via the Canon menu the same as the equivalent item in the CHDK menu (so 1 = Fine, 2 = Super Fine, CHDK adds the ability to set lower quality "normal")? Or is what Canon calls "Super Fine" the same as "Normal" in the CHDK menu?

* CAM_VIDEO_QUALITY_ONLY is enabled, but CAM_CHDK_HAS_EXT_VIDEO_MENU and the actual video override code is not.  I'd suggest leaving this undefined, and removing the unused movie_rec files as in the g7x port.
Don't forget what the H stands for.

*

Offline Ant

  • ****
  • 317
EOS M3:
SV96 fixed
focal_length functions reworked
get_zoom_x implemented
iso 100 added
black level changed to 2047
semaphore related stubs modified


*

Offline reyalp

  • ******
  • 10921
EOS M3:
Thanks, added in r4789

A few comments:
Quote
focal_length functions reworked
If you describe how this works, that would be useful for anyone else trying to support interchangeable lens cameras.

From stubs_entry.s it appears the mode map still needs some correction. CHDK doesn't support "C" modes, but the others should be fixed.

You can also remove any stubs from stubs_entry_2.S which are found correctly by the sig finder. These are noted with == or < veneer in stubs_entry.S

The notes still says "movie_status is wrong". I'd suggest implementing "simple_movie_status" like the other digic 6 cams if possible.
Don't forget what the H stands for.

*

Offline Ant

  • ****
  • 317
If you describe how this works, that would be useful for anyone else trying to support interchangeable lens cameras.

Now it geting focal_length from canon's variable(like M10 port). Previously it was getting focal_length directly from lens.

 

Related Topics