Adding new cameras, applying patches into trunk (with source code prepared) - page 43 - General Discussion and Assistance - CHDK Forum
« previous next »
Pages: 1 ... 38 39 40 41 42 [43] 44 45 46 47 48 ... 169   Go Down

Adding new cameras, applying patches into trunk (with source code prepared)

  • 1685 Replies
  • 845946 Views
*

Offline srsa_4c

  • ******
  • 4451
Re: Adding new cameras, applying patches into trunk (with source code prepared)
« Reply #420 on: 07 / August / 2011, 18:06:13 »
Advertisements
Attached is a patch for the A410

- subject distance override made possible by duplicating (and disabling an assert in) MoveFocusLensToDistance(). I'm not sure whether I chose the proper place for its declaration (I put it into /include/lolevel.h) or a proper name for it ( MoveFocusLensToDistanceA410() ).
- movie time limit fix (the standard, 60min one) was tested, I no longer call it experimental.
- included CAM_DETECT_SCREEN_ERASE
- typo fixed in /platform/a410/shooting.c

I didn't include any MFOn() MFOff() stuff. While it does make manual focus work better in these cameras (A410, 420, ...) by eliminating the unnecessary af-scan, it would be too much work for now to implement it. Its state would need to be properly tracked, if not, it causes more problems than it solves.

Oh, and about that assert: I strongly believe, that removing it won't cause any hardware trouble, everything seems to work just fine.

edit:
grammar fix
« Last Edit: 07 / August / 2011, 20:14:56 by srsa_4c »
Logged
*

Offline philmoz

  • *****
  • 3450
    • Photos
Re: Adding new cameras, applying patches into trunk (with source code prepared)
« Reply #421 on: 08 / August / 2011, 04:34:01 »
Quote from: funnel on 06 / August / 2011, 07:08:43
Includes:
-fix in generic/shooting.c that caused Av bracketing to not calculate the lowest Av value http://chdk.setepontos.com/index.php?topic=6726.0
-in generic/shooting.c disabled bracketing when camera in best image selection mode (MODE_SCN_BEST_IMAGE). In this mode the camera shoots 4 images and auto selects the best one.
-added new keys for sx220 to include/keyboard.h
-added new key "playback" for sx220 in adjustable alt button in gui.c
-key changes in sx220 kbd.c
-from sx220 platform_camera.h removed unneeded define entries and comments cleanup.
-in sx220 lib.c corrected the led_table.

Added all but the first change to generic\shooting.c in changeset 1285.

My concern with the first update is that it changes the current behaviour which may cause unintended consequences (possibly in scripts).
Currently you select an amount to bracket by and if applying that amount to the Av value is out of range the bracketed value is not changed - your update causes it to use the largest aperture which amounts to a bracketed change of less than the requested amount.
Hope this makes sense, and I'm happy to be overruled by someone more knowledgable in this area.

Phil.
Logged
CHDK ports:
  sx30is (1.00c, 1.00h, 1.00l, 1.00n & 1.00p)
  g12 (1.00c, 1.00e, 1.00f & 1.00g)
  sx130is (1.01d & 1.01f)
  ixus310hs (1.00a & 1.01a)
  sx40hs (1.00d, 1.00g & 1.00i)
  g1x (1.00e, 1.00f & 1.00g)
  g5x (1.00c, 1.01a, 1.01b)
  g7x2 (1.01a, 1.01b, 1.10b)
*

Offline funnel

  • ****
  • 349
Re: Adding new cameras, applying patches into trunk (with source code prepared)
« Reply #422 on: 08 / August / 2011, 05:56:35 »
Quote from: philmoz on 08 / August / 2011, 04:34:01
Currently you select an amount to bracket by and if applying that amount to the Av value is out of range the bracketed value is not changed - your update causes it to use the largest aperture which amounts to a bracketed change of less than the requested amount.

Makes sense. If I want 1/3EV changes in the last shot I would actually get an ~1/6EV (-14 in place of -32) which is not what I requested. But why would canon call it a f3.1 when is actually a f3.3? I'll try to compare the images in software if I can see the EV difference between the last images.
Logged
*

Offline funnel

  • ****
  • 349
Re: Adding new cameras, applying patches into trunk (with source code prepared)
« Reply #423 on: 08 / August / 2011, 08:04:29 »
edit: ignore the first post I wrote.

I made a test between f3.5 and f3.1 raw files and looks like it's true that even if it substracts just -14 and not -32 the difference between the two final images is 1/3EV (-32).

I tested by comparing:
-DNG f3.5 (0EV) vs DNG 3.1 (-0.33EV in photoshop) --->no noticable difference in brightness
-JPG f3.5 (0EV) vs JPG 3.1 (-0.33EV) --->no noticable difference in brightness

Of course philmoz you're right when bracketing with 1EV,2EV... the final image would not be the right EV someone requested.
« Last Edit: 08 / August / 2011, 09:25:25 by funnel »
Logged
*

Offline philmoz

  • *****
  • 3450
    • Photos
Re: Adding new cameras, applying patches into trunk (with source code prepared)
« Reply #424 on: 12 / August / 2011, 04:39:05 »
Quote from: srsa_4c on 07 / August / 2011, 18:06:13
Attached is a patch for the A410

- subject distance override made possible by duplicating (and disabling an assert in) MoveFocusLensToDistance(). I'm not sure whether I chose the proper place for its declaration (I put it into /include/lolevel.h) or a proper name for it ( MoveFocusLensToDistanceA410() ).
- movie time limit fix (the standard, 60min one) was tested, I no longer call it experimental.
- included CAM_DETECT_SCREEN_ERASE
- typo fixed in /platform/a410/shooting.c

I didn't include any MFOn() MFOff() stuff. While it does make manual focus work better in these cameras (A410, 420, ...) by eliminating the unnecessary af-scan, it would be too much work for now to implement it. Its state would need to be properly tracked, if not, it causes more problems than it solves.

Oh, and about that assert: I strongly believe, that removing it won't cause any hardware trouble, everything seems to work just fine.

edit:
grammar fix

Added in changeset 1287.

Phil.
Logged
CHDK ports:
  sx30is (1.00c, 1.00h, 1.00l, 1.00n & 1.00p)
  g12 (1.00c, 1.00e, 1.00f & 1.00g)
  sx130is (1.01d & 1.01f)
  ixus310hs (1.00a & 1.01a)
  sx40hs (1.00d, 1.00g & 1.00i)
  g1x (1.00e, 1.00f & 1.00g)
  g5x (1.00c, 1.01a, 1.01b)
  g7x2 (1.01a, 1.01b, 1.10b)
*

Offline msl

  • *****
  • 1280
  • A720 IS, SX220 HS 1.01a
    • CHDK-DE links
Re: Adding new cameras, applying patches into trunk (with source code prepared)
« Reply #425 on: 12 / August / 2011, 05:35:22 »
Quote from: philmoz on 12 / August / 2011, 04:39:05
Added in changeset 1287.

I added missing focushack.c in changeset 1288

msl
Logged
CHDK-DE:  CHDK-DE links
*

Offline funnel

  • ****
  • 349
Re: Adding new cameras, applying patches into trunk (with source code prepared)
« Reply #426 on: 12 / August / 2011, 08:38:45 »
SX220 patch:
-fix for save raw file counter not being updated correctly
-fix for ISO overrides in capt_seq.c and shooting.c
-fix for jogdial task in boot.c and kbd.c

Thx to philmoz.
Logged
*

Offline philmoz

  • *****
  • 3450
    • Photos
Re: Adding new cameras, applying patches into trunk (with source code prepared)
« Reply #427 on: 12 / August / 2011, 09:05:56 »
Quote from: msl on 12 / August / 2011, 05:35:22
Quote from: philmoz on 12 / August / 2011, 04:39:05
Added in changeset 1287.

I added missing focushack.c in changeset 1288

msl

Sorry about that chief :)
Logged
CHDK ports:
  sx30is (1.00c, 1.00h, 1.00l, 1.00n & 1.00p)
  g12 (1.00c, 1.00e, 1.00f & 1.00g)
  sx130is (1.01d & 1.01f)
  ixus310hs (1.00a & 1.01a)
  sx40hs (1.00d, 1.00g & 1.00i)
  g1x (1.00e, 1.00f & 1.00g)
  g5x (1.00c, 1.01a, 1.01b)
  g7x2 (1.01a, 1.01b, 1.10b)
*

Offline philmoz

  • *****
  • 3450
    • Photos
Re: Adding new cameras, applying patches into trunk (with source code prepared)
« Reply #428 on: 12 / August / 2011, 09:11:24 »
Quote from: funnel on 12 / August / 2011, 08:38:45
SX220 patch:
-fix for save raw file counter not being updated correctly
-fix for ISO overrides in capt_seq.c and shooting.c
-fix for jogdial task in boot.c and kbd.c

Thx to philmoz.


Added in changeset 1290.

Phil.
Logged
CHDK ports:
  sx30is (1.00c, 1.00h, 1.00l, 1.00n & 1.00p)
  g12 (1.00c, 1.00e, 1.00f & 1.00g)
  sx130is (1.01d & 1.01f)
  ixus310hs (1.00a & 1.01a)
  sx40hs (1.00d, 1.00g & 1.00i)
  g1x (1.00e, 1.00f & 1.00g)
  g5x (1.00c, 1.01a, 1.01b)
  g7x2 (1.01a, 1.01b, 1.10b)
*

Offline mipa87

  • *
  • 11
Re: Adding new cameras, applying patches into trunk (with source code prepared)
« Reply #429 on: 19 / August / 2011, 14:30:26 »
Patch for a580:
  • added SDHC multi-partition support
  • fixed keys (disabled erase button, half shutter (zebra, OSD, histogram)
  • user menu works
  • + adjustable Alt button
  • video fully working
  • code revised
« Last Edit: 19 / August / 2011, 19:02:00 by mipa87 »
Logged
Pages: 1 ... 38 39 40 41 42 [43] 44 45 46 47 48 ... 169   Go Up
« previous next »
 

Related Topics


SimplePortal © 2008-2014, SimplePortal