Adding new cameras, applying patches into trunk (with source code prepared) - page 55 - General Discussion and Assistance - CHDK Forum
supplierdeeply

Adding new cameras, applying patches into trunk (with source code prepared)

  • 1654 Replies
  • 580849 Views
*

Online philmoz

  • *****
  • 3320
    • Photos
Re: Adding new cameras, applying patches into trunk (with source code prepared)
« Reply #540 on: 22 / November / 2011, 21:42:26 »
Advertisements
While big changes are on hold, try to go on with small interface improvements.

What patch contain:
1. Forgotten change to make item#3 of  1407changeset workable
2. Text reader become default action of filemanager (before filemanager just quit)
3. We return from text reader to filemanager, instead of menu. Much easier to press Menu once more, then select text reader again and browse through directory hierarcy in case if select wrong or would like to read something more (for me this is especially useful, because during development a lot of debug log files created and I don't wont remove card from camera to read it comfortable).

Before implementing this, I've updated the file selector logic to be able to pass in the previous file name and it will then open with that file selected in the list (changeset 1423).

When you select 'Open New File' you will now be in the directory of the last read file with that file pre-selected.

Personally I still think that exiting the text reader should always take you back to the same place regardless of how you entered; but I'm open to it working either way. Perhaps a configuration option to allow you to exit the text reader to either the menu or file selector could be used.

Phil.
CHDK ports:
  sx30is (1.00c, 1.00h, 1.00l, 1.00n & 1.00p)
  g12 (1.00c, 1.00e, 1.00f & 1.00g)
  sx130is (1.01d & 1.01f)
  ixus310hs (1.00a & 1.01a)
  sx40hs (1.00d, 1.00g & 1.00i)
  g1x (1.00e, 1.00f & 1.00g)
  g5x (1.00c, 1.01a, 1.01b)
  g7x2 (1.01a, 1.01b, 1.10b)

Re: Adding new cameras, applying patches into trunk (with source code prepared)
« Reply #541 on: 22 / November / 2011, 21:52:04 »
Personally I still think that exiting the text reader should always take you back to the same place regardless of how you entered; but I'm open to it working either way. Perhaps a configuration option to allow you to exit the text reader to either the menu or file selector could be used.

Gee phil - while you're at it,  how about fixing the "<- Back" menu item in the Script menu so that it works when you enter that menu via the Func/Set key rather than the Main Menu. :-X

Ported :   A1200    SD940   G10    Powershot N    G16

*

Online philmoz

  • *****
  • 3320
    • Photos
Re: Adding new cameras, applying patches into trunk (with source code prepared)
« Reply #542 on: 22 / November / 2011, 21:59:33 »

Gee phil - while you're at it,  how about fixing the "<- Back" menu item in the Script menu so that it works when you enter that menu via the Func/Set key rather than the Main Menu. :-X


Where should it go 'back' to?

Phil.
CHDK ports:
  sx30is (1.00c, 1.00h, 1.00l, 1.00n & 1.00p)
  g12 (1.00c, 1.00e, 1.00f & 1.00g)
  sx130is (1.01d & 1.01f)
  ixus310hs (1.00a & 1.01a)
  sx40hs (1.00d, 1.00g & 1.00i)
  g1x (1.00e, 1.00f & 1.00g)
  g5x (1.00c, 1.01a, 1.01b)
  g7x2 (1.01a, 1.01b, 1.10b)

Re: Adding new cameras, applying patches into trunk (with source code prepared)
« Reply #543 on: 22 / November / 2011, 22:01:21 »
Where should it go 'back' to?
The blank <ALT> screen it "came" from ?  Much like the second time you press the Menu key in <ALT> mode.
Ported :   A1200    SD940   G10    Powershot N    G16


*

Online philmoz

  • *****
  • 3320
    • Photos
Re: Adding new cameras, applying patches into trunk (with source code prepared)
« Reply #544 on: 22 / November / 2011, 23:17:53 »
Where should it go 'back' to?
The blank <ALT> screen it "came" from ?  Much like the second time you press the Menu key in <ALT> mode.

Simple solution is in the gui_menu_back() function (gui_menu.c), if there is no parent menu to go back to then exit to <ALT> mode.

This has the side effect that the 'Disp' button will now exit from the main menu back to <ALT> mode as well (Disp is a shortcut for the 'Back' menu option).

Is this a reasonable solution?

Phil.
CHDK ports:
  sx30is (1.00c, 1.00h, 1.00l, 1.00n & 1.00p)
  g12 (1.00c, 1.00e, 1.00f & 1.00g)
  sx130is (1.01d & 1.01f)
  ixus310hs (1.00a & 1.01a)
  sx40hs (1.00d, 1.00g & 1.00i)
  g1x (1.00e, 1.00f & 1.00g)
  g5x (1.00c, 1.01a, 1.01b)
  g7x2 (1.01a, 1.01b, 1.10b)

Re: Adding new cameras, applying patches into trunk (with source code prepared)
« Reply #545 on: 23 / November / 2011, 00:45:14 »
Is this a reasonable solution?
Sounds good to me.  Its obviously really not a big deal - just a minor annoyance that came to mind when you were commenting on the correct way to leave the file viewer.
Ported :   A1200    SD940   G10    Powershot N    G16

Re: Adding new cameras, applying patches into trunk (with source code prepared)
« Reply #546 on: 24 / November / 2011, 09:32:38 »
No real changes.
1. Just well documenting script.c module before its upcoming improvement
2. Minor renames ( conf.ubasic_vars -> conf.script_vars) to match name to usage.

Also some changes are produced because tab to space replacing.

*

Offline tommi2water

  • ***
  • 157
  • IXUS 220 HS Firmware: 1.00c
Please integrate first CHDK port for ixus220_elph300hs
« Reply #547 on: 26 / November / 2011, 06:30:33 »
Update:
A new request for integration has been posted below.
--------------------------------------------------------------------------------------

I've set this request to OnHold until we have reached a better stage than only Alpha.  :D
As soon as I'm able to provide an improved version I will create a new request in this thread.

--------------------------------------------------------------------------------------
« Last Edit: 28 / November / 2011, 10:35:02 by tommi2water »


*

Offline srsa_4c

  • ******
  • 4414
Re: Adding new cameras, applying patches into trunk (with source code prepared)
« Reply #548 on: 26 / November / 2011, 08:56:48 »
A while ago I complained about the memory dump debug function, here: http://chdk.setepontos.com/index.php?topic=7067.msg75696#msg75696 (also see reyalp's answer).

Attached is a patch which aims to correct it.

Another possibility to fix write() with NULL as source address would be this:

write(fd, (void*)0 | CAM_UNCACHED_BIT, 0x1900);

I'd also like to note that on at least the Ixus30/40 models, these addresses only work when specified as uncached. It's just a note, I don't think it will affect anyone else than me :)

CAM_RAM_SIZE_IN_MB would have to be corrected for cameras which have more or less RAM than 32MB - but that's only up to the interested developers.

I hope this is not unpolite, didn't want to open a thread for this.

*

Offline tommi2water

  • ***
  • 157
  • IXUS 220 HS Firmware: 1.00c
Please integrate first CHDK port for ixus220_elph300hs
« Reply #549 on: 28 / November / 2011, 10:33:58 »
Dear Developers,

this is my request to add a first Beta version of CHDK port for ixus220_elph300hs camera with firmware version 1.00c/1.01a/1.01c (related thread: http://chdk.setepontos.com/index.php?topic=6341).

I cleaned up my code and moved it to trunk revision 1432, built and tested it for firmware 1.00c. Binaries for firmware versions 1.01a and 1.01c have been tested by other developers and are also working fine for this first version (http://chdk.setepontos.com/index.php?topic=6341.210).

SVN Patch (File: ixus220_elph300hs_20111128.zip) is attached to this post.
Update: If not yet integrated, please integrate Patch_ixus220_elph300hs_20111128_01.zip (instead of ixus220_elph300hs_20111128.zip). It contains one additional small change for each of the three firmware versions. Thank you!  :)

This first port of ixus220_elph300hs is based on trunk1432 of CHDK.

changes have been made to the following files/folders:
Code: [Select]
/core/gui.c // add support for ixus220_elph300hs
/core/kbd.c // add support for ixus220_elph300hs
/camera_list.csv // add BETA Status entry for ixus220_elph300hs
/loader/ // add new folder "ixus220_elph300hs" with loader files for ixus220_elph300hs
/platform/ // add new folder "ixus220_elph300hs" with platform files for ixus220_elph300hs Firmware 1.00c/1.01a/1.01c

Can you please integrate the patch into the subversion repository on assembla?

Firmware 1.00c for camera ixus220_elph300hs was taken from here:
http://www.box.com/shared/tscho3m30j/4/55272271/669226134

Firmware 1.01a for camera ixus220_elph300hs was taken from here:
http://www.box.com/shared/tscho3m30j/4/55272271/881231820

Firmware 1.01c for camera ixus220_elph300hs was taken from here:
http://www.box.com/shared/tscho3m30j/4/55272271/1165249041


Thanks in advance and best regards,
Tommi
« Last Edit: 28 / November / 2011, 15:36:54 by tommi2water »

 

Related Topics