Adding new cameras, applying patches into trunk (with source code prepared) - page 97 - General Discussion and Assistance - CHDK Forum  

Adding new cameras, applying patches into trunk (with source code prepared)

  • 1666 Replies
  • 695915 Views
*

Offline nafraf

  • *****
  • 1308
Re: Adding new cameras, applying patches into trunk (with source code prepared)
« Reply #960 on: 17 / January / 2013, 21:45:51 »
Advertisements
patch to sx110is 100b: new loader tested and exp_drv task implemented.

Report and comments here.
« Last Edit: 17 / January / 2013, 22:45:09 by nafraf »

Re: Adding new cameras, applying patches into trunk (with source code prepared)
« Reply #961 on: 17 / January / 2013, 22:54:34 »
I have a proposal which would be of help for cameras that have too few buttons (and no touchscreen). This would enable normal camera use for inexperienced users, and also enable more comfortable camera control for those who don't mind that the camera's On/Off button behaves differently when in ALT mode.
If I understand the patch file correctly,  this allows the On/Off button to substitute in <ALT> mode for one of the buttons that the CHDK code expects the camera to have but which is in fact not available on that camera.  Is that right ?
Ported :   A1200    SD940   G10    Powershot N    G16

*

Offline philmoz

  • *****
  • 3441
    • Photos
Re: Adding new cameras, applying patches into trunk (with source code prepared)
« Reply #962 on: 18 / January / 2013, 03:12:26 »
patch to sx110is 100b: new loader tested and exp_drv task implemented.

Report and comments here.

Added in revision 2490 (trunk) and 2491 (release-1.1).

Phil.
CHDK ports:
  sx30is (1.00c, 1.00h, 1.00l, 1.00n & 1.00p)
  g12 (1.00c, 1.00e, 1.00f & 1.00g)
  sx130is (1.01d & 1.01f)
  ixus310hs (1.00a & 1.01a)
  sx40hs (1.00d, 1.00g & 1.00i)
  g1x (1.00e, 1.00f & 1.00g)
  g5x (1.00c, 1.01a, 1.01b)
  g7x2 (1.01a, 1.01b, 1.10b)

*

Offline philmoz

  • *****
  • 3441
    • Photos
Re: Adding new cameras, applying patches into trunk (with source code prepared)
« Reply #963 on: 18 / January / 2013, 03:26:50 »
I have a proposal which would be of help for cameras that have too few buttons (and no touchscreen). This would enable normal camera use for inexperienced users, and also enable more comfortable camera control for those who don't mind that the camera's On/Off button behaves differently when in ALT mode.

Background info: this kind of remap is currently permanently enabled in the Ixus110 port (which can be confusing for some).

The patch makes changes in core in order to introduce a new configurable option and a new menu item. Since I don't do this usually, I'd like to ask for a quick look and some advice from those who do. My question is: is this acceptable?

Looks ok - the only suggestion I have is to change the text slightly (the use of the word 'Off' could be confusing).
So instead of the default menu entry being
      OFF button in <ALT> mode       [Off    ]
change it to
      Power button in <ALT> mode   [Power]

Phil.

CHDK ports:
  sx30is (1.00c, 1.00h, 1.00l, 1.00n & 1.00p)
  g12 (1.00c, 1.00e, 1.00f & 1.00g)
  sx130is (1.01d & 1.01f)
  ixus310hs (1.00a & 1.01a)
  sx40hs (1.00d, 1.00g & 1.00i)
  g1x (1.00e, 1.00f & 1.00g)
  g5x (1.00c, 1.01a, 1.01b)
  g7x2 (1.01a, 1.01b, 1.10b)


*

Offline srsa_4c

  • ******
  • 4450
Re: Adding new cameras, applying patches into trunk (with source code prepared)
« Reply #964 on: 18 / January / 2013, 15:58:24 »
Looks ok - the only suggestion I have is to change the text slightly (the use of the word 'Off' could be confusing).
So instead of the default menu entry being
      OFF button in <ALT> mode       [Off    ]
change it to
      Power button in <ALT> mode   [Power]
Thanks for the review and the suggestion. I used "Off" because that's what's written on the camera (considering non-English users, and the fact that the #define'd strings can not be localized).

There's one more thing I'm uncertain of. There are several issues with the buttons in general:
- there are new cameras (A series) with a fair amount of available buttons, but some of those are not used (KEY_VIDEO, KEY_HELP) except when chosen for the ALT button.
- there are cameras with more buttons (for ALT mode use) than needed, but some of those have no use in ALT mode (KEY_FACE for example), again, when not selected as ALT button. They could be configured as shortcuts (shooting / scripting / modules related use), according to one's liking.
- there may be a generic solution that doesn't need to be implemented individually for each camera

I don't know whether there are plans to address the above issues. If there's a plan, my current work may be in conflict.

If it's not a problem, I'll commit my (corrected) solution.

If I understand the patch file correctly,  this allows the On/Off button to substitute in <ALT> mode for one of the buttons that the CHDK code expects the camera to have but which is in fact not available on that camera.  Is that right ?
Yes, although it could be implemented for a button other than "power" too. In that case the menu text will have to be changed.

*

Offline philmoz

  • *****
  • 3441
    • Photos
Re: Adding new cameras, applying patches into trunk (with source code prepared)
« Reply #965 on: 18 / January / 2013, 16:20:55 »
Looks ok - the only suggestion I have is to change the text slightly (the use of the word 'Off' could be confusing).
So instead of the default menu entry being
      OFF button in <ALT> mode       [Off    ]
change it to
      Power button in <ALT> mode   [Power]
Thanks for the review and the suggestion. I used "Off" because that's what's written on the camera (considering non-English users, and the fact that the #define'd strings can not be localized).

Hadn't thought of that, good point. On all my cameras the button is labelled ON/OFF (in caps) so perhaps the menu should be:
     ON/OFF button in <ALT> mode  [OFF  ]
Are cameras labelled with ON/OFF in non-English countries?

Quote
There's one more thing I'm uncertain of. There are several issues with the buttons in general:
- there are new cameras (A series) with a fair amount of available buttons, but some of those are not used (KEY_VIDEO, KEY_HELP) except when chosen for the ALT button.
- there are cameras with more buttons (for ALT mode use) than needed, but some of those have no use in ALT mode (KEY_FACE for example), again, when not selected as ALT button. They could be configured as shortcuts (shooting / scripting / modules related use), according to one's liking.
- there may be a generic solution that doesn't need to be implemented individually for each camera

I don't know whether there are plans to address the above issues. If there's a plan, my current work may be in conflict.


Adding user configurable shortcuts is something I've been thinking about for a while; but the number of cameras and button combinations makes any generic solution very hard (at least I haven't found a simple way to do it yet).

Unless someone else has any issues with this, I don't see any reason not to add it.

Phil.
CHDK ports:
  sx30is (1.00c, 1.00h, 1.00l, 1.00n & 1.00p)
  g12 (1.00c, 1.00e, 1.00f & 1.00g)
  sx130is (1.01d & 1.01f)
  ixus310hs (1.00a & 1.01a)
  sx40hs (1.00d, 1.00g & 1.00i)
  g1x (1.00e, 1.00f & 1.00g)
  g5x (1.00c, 1.01a, 1.01b)
  g7x2 (1.01a, 1.01b, 1.10b)

*

Offline srsa_4c

  • ******
  • 4450
Re: Adding new cameras, applying patches into trunk (with source code prepared)
« Reply #966 on: 18 / January / 2013, 16:29:31 »
Hadn't thought of that, good point. On all my cameras the button is labelled ON/OFF (in caps) so perhaps the menu should be:
     ON/OFF button in <ALT> mode  [OFF  ]
Are cameras labelled with ON/OFF in non-English countries?
According to a quick image search for a random "Ixy" model, even Japanese cameras have English labels.

Quote
Unless someone else has any issues with this, I don't see any reason not to add it.
OK, if no objections, I'll check it in.

edit: https://trac.assembla.com/chdk/changeset/2498/
« Last Edit: 19 / January / 2013, 10:52:32 by srsa_4c »

Re: Adding new cameras, applying patches into trunk (with source code prepared)
« Reply #967 on: 19 / January / 2013, 13:23:44 »
When CHDK gets a GPS fix from gps_get_data(), it doesn't check whether the latitude coordinates are North or South or if the longitude coordinates are East or West. The attached patch fixes this behaviour by making the latitude/longitude negative if it is South/West respectively, which is what the rest of the code expects.

I've tested the patch on my SX230HS when I was somewhere with coordinates which were North and West and it worked correctly.


*

Offline nafraf

  • *****
  • 1308
Re: Adding new cameras, applying patches into trunk (with source code prepared)
« Reply #968 on: 19 / January / 2013, 23:10:12 »
a3400 100f port ALPHA version. Tested by TuDo.

capt_seq.c in a3400 101a was updated, but this version remains untested.
« Last Edit: 19 / January / 2013, 23:24:57 by nafraf »

*

Offline philmoz

  • *****
  • 3441
    • Photos
Re: Adding new cameras, applying patches into trunk (with source code prepared)
« Reply #969 on: 19 / January / 2013, 23:38:23 »
a3400 100f port ALPHA version. Tested by TuDo.

capt_seq.c in a3400 101a was updated, but this version remains untested.

Added in revision 2500 (trunk) and 2501 (release-1.1).

Phil.
CHDK ports:
  sx30is (1.00c, 1.00h, 1.00l, 1.00n & 1.00p)
  g12 (1.00c, 1.00e, 1.00f & 1.00g)
  sx130is (1.01d & 1.01f)
  ixus310hs (1.00a & 1.01a)
  sx40hs (1.00d, 1.00g & 1.00i)
  g1x (1.00e, 1.00f & 1.00g)
  g5x (1.00c, 1.01a, 1.01b)
  g7x2 (1.01a, 1.01b, 1.10b)

 

Related Topics