Adding new cameras, applying patches into trunk (with source code prepared)

srsa_4c

4437

Re: Adding new cameras, applying patches into trunk (with source code prepared)

« Reply #1270 on: 01 / December / 2013, 14:41:48 »

Advertisements

Two patches, I'm not completely confident to check these in.

sx210:
[OK] keymap corrections, makes shoot (the script command) work
[??] I have changed two firmware variable addresses (simply enabled the automatically found ones), the test builds contained this change, but I didn't ask for confirmation
[??] I have enabled alternative ALT buttons, it's probably OK.

If the tester's words are not convincing enough, perhaps I / someone should ask him again?

sx230:
Enabled ARAM instead of EXMEM.
Here's an early reaction (not my patch), here's another (using a build with the v2 aram patch with sx230 added). edit: another report.

I didn't touch anything else in the patched files to make the patches "noiseless", some of them look really ugly.

sx210_keymapfix_adjustablealtbttn_fwvarfix.diff (4.87 kB - downloaded 19 times.)

sx230_aram_instead_of_exmem.diff (2.85 kB - downloaded 19 times.)

« Last Edit: 03 / December / 2013, 12:36:27 by srsa_4c »

Logged

Menu jumping/flickering on M10?

reyalp

13619

Re: Adding new cameras, applying patches into trunk (with source code prepared)

« Reply #1271 on: 03 / December / 2013, 17:10:11 »

Sorry I haven't looked at the actual patches carefully yet.

SX230 in aram seems like it should be fine. It would be good to know how much canon heap is available, if it is really low exmem might still be required.

For SX210, keymap and adjustable alt should be fine. For the firmware variables, it would be good to either sanity check in the disassembly (look for equivalent code on a known working camera) or get a direct report from the test. recreview_hold being wrong in the original port would not be a surprise at all.

Logged

Don't forget what the H stands for.

srsa_4c

4437

Re: Adding new cameras, applying patches into trunk (with source code prepared)

« Reply #1272 on: 06 / December / 2013, 11:59:26 »

Quote from: reyalp on 03 / December / 2013, 17:10:11

SX230 in aram seems like it should be fine. It would be good to know how much canon heap is available, if it is really low exmem might still be required.

I have posted a request for malloc heap details. Enabling aram beside exmem would not bring much visible improvements, so I hope there's enough Canon heap...

Quote

For SX210, keymap and adjustable alt should be fine.

Committed.

Quote

For the firmware variables, it would be good to either sanity check in the disassembly (look for equivalent code on a known working camera) or get a direct report from the test. recreview_hold being wrong in the original port would not be a surprise at all.

Problem is, these may not be too easy to test (unless you have an idea), and I don't know whether the other r43 ports are a reliable source. I'll try to trace things in the disassembly...

Logged

Menu jumping/flickering on M10?